Re: [PATCH] D12169: Relax constexpr rules to improve __builtin_object_size's accuracy

george.burgess.iv added inline comments. Comment at: lib/AST/ExprConstant.cpp:51 @@ -50,1 +50,3 @@ +#include + vsk wrote: > Do you need ? Artifact of print debugging. Thanks for catching that :) http://reviews.llvm.org/D12169 __

Re: [PATCH] D12169: Relax constexpr rules to improve __builtin_object_size's accuracy

george.burgess.iv updated this revision to Diff 32662. george.burgess.iv added a comment. Removed advanced debugging tools (iostream) http://reviews.llvm.org/D12169 Files: lib/AST/ExprConstant.cpp test/CXX/expr/expr.const/p2-0x.cpp test/CodeGen/object-size.c Index: test/CodeGen/object-si

Re: [PATCH] D12182: Fix a typo: "overriden" -> "overridden" in libcxx/src/new.cpp

EricWF closed this revision. EricWF added a comment. Committed as r245539. http://reviews.llvm.org/D12182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r245539 - Fix a typo: overidden -> overridden - Patch from Kai Zhao

Author: ericwf Date: Thu Aug 20 00:23:16 2015 New Revision: 245539 URL: http://llvm.org/viewvc/llvm-project?rev=245539&view=rev Log: Fix a typo: overidden -> overridden - Patch from Kai Zhao Modified: libcxx/trunk/src/new.cpp Modified: libcxx/trunk/src/new.cpp URL: http://llvm.org/viewvc/ll

Re: [PATCH] D12183: Fix a typo: "abreviated" -> "abbreviated"

EricWF closed this revision. EricWF added a comment. commited as r245538. http://reviews.llvm.org/D12183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r245538 - Fix a typo: abreviated -> abbreviated - Patch from Kai Zhao

Author: ericwf Date: Thu Aug 20 00:20:29 2015 New Revision: 245538 URL: http://llvm.org/viewvc/llvm-project?rev=245538&view=rev Log: Fix a typo: abreviated -> abbreviated - Patch from Kai Zhao Modified: libcxx/trunk/test/std/localization/locale.categories/category.time/locale.time.get.byname

Re: [PATCH] D12183: Fix a typo: "abreviated" -> "abbreviated"

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Thanks again! A lot of these look like my mistakes :S http://reviews.llvm.org/D12183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

Re: [PATCH] D12183: Fix a typo: "abreviated" -> "abbreviated"

loverszhaokai added a comment. I am not a committer. It would be great if you can commit this revision. Thanks. http://reviews.llvm.org/D12183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D12183: Fix a typo: "overriden" -> "overridden"

loverszhaokai created this revision. loverszhaokai added a reviewer: EricWF. loverszhaokai added a subscriber: cfe-commits. Fix a typo: "overriden" -> "overridden" in libcxx/test/std/localization/locale.categories/category.time/locale.time.get.byname/get_monthname.pass.cpp libcxx/test/std/locali

Re: [PATCH] D12182: Fix a typo: "overriden" -> "overridden" in libcxx/src/new.cpp

loverszhaokai added a comment. @EricWF Yes. I am not a committer. It would be great if you can commit this revision. Thanks. http://reviews.llvm.org/D12182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

Re: r240188 - Handle 'instancetype' in ParseDeclarationSpecifiers.

On Fri, Jun 19, 2015 at 4:18 PM, Douglas Gregor wrote: > Author: dgregor > Date: Fri Jun 19 18:18:00 2015 > New Revision: 240188 > > URL: http://llvm.org/viewvc/llvm-project?rev=240188&view=rev > Log: > Handle 'instancetype' in ParseDeclarationSpecifiers. > > ...instead of as a special case in Pa

Re: [PATCH] D12152: [OPENMP] Info about OpenMP Support in Users Manual

ABataev updated this revision to Diff 32653. ABataev added a comment. Update after review http://reviews.llvm.org/D12152 Files: docs/UsersManual.rst Index: docs/UsersManual.rst === --- docs/UsersManual.rst +++ docs/UsersManual.r

Re: [PATCH] D12182: Fix a typo: "overriden" -> "overridden" in libcxx/src/new.cpp

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Do you need somebody to commit this for you? http://reviews.llvm.org/D12182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D12182: Fix a typo: "overriden" -> "overridden" in libcxx/src/new.cpp

loverszhaokai created this revision. loverszhaokai added a reviewer: EricWF. loverszhaokai added a subscriber: cfe-commits. Fix a typo: "overriden" -> "overridden" in libcxx/src/new.cpp http://reviews.llvm.org/D12182 Files: src/new.cpp Index: src/new.cpp ==

Re: [PATCH] D12163: [Patch] [Analyzer] BugReporter.cpp:2869: Assertion failed: !RemainingNodes.empty() && "No error node found in the trimmed graph" (PR 24184)

zaks.anna added a comment. I have some minor nits but looks good otherwise. Thanks for fixing this! Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:290 @@ -289,2 +289,3 @@ const ProgramPointTag *Tag = nullptr) { -

[clang-tools-extra] r245533 - [clang-tidy] Add back a test with a custom NULL macro. Remove redundant default.

Author: alexfh Date: Wed Aug 19 20:44:14 2015 New Revision: 245533 URL: http://llvm.org/viewvc/llvm-project?rev=245533&view=rev Log: [clang-tidy] Add back a test with a custom NULL macro. Remove redundant default. Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrCheck.cpp

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

The tests are passing now . Will now try to add back the piece of test that was removed and see whether it works. On Thu, Aug 20, 2015 at 2:00 AM, Alexander Kornienko wrote: > After looking at the code once again, I found an o

[libcxxabi] r245531 - Fix or disable C++11 tests in C++03 mode

Author: ericwf Date: Wed Aug 19 20:22:17 2015 New Revision: 245531 URL: http://llvm.org/viewvc/llvm-project?rev=245531&view=rev Log: Fix or disable C++11 tests in C++03 mode Modified: libcxxabi/trunk/test/catch_in_noexcept.pass.cpp libcxxabi/trunk/test/catch_pointer_nullptr.pass.cpp l

Re: [PATCH] D12180: [clang-tidy] Use a python script instead of a shell script to run clang-tidy tests.

alexfh updated this revision to Diff 32645. alexfh added a comment. Removed an unused import. http://reviews.llvm.org/D12180 Files: test/clang-tidy/arg-comments.cpp test/clang-tidy/check_clang_tidy.py test/clang-tidy/google-explicit-constructor.cpp test/clang-tidy/google-explicit-make-p

[libcxx] r245529 - Cleanup unique_ptr failure tests and convert them to Clang verify

Author: ericwf Date: Wed Aug 19 20:08:03 2015 New Revision: 245529 URL: http://llvm.org/viewvc/llvm-project?rev=245529&view=rev Log: Cleanup unique_ptr failure tests and convert them to Clang verify Modified: libcxx/trunk/test/std/utilities/memory/unique.ptr/unique.ptr.single/unique.ptr.sing

[PATCH] D12180: [clang-tidy] Use a python script instead of a shell script to run clang-tidy tests.

alexfh created this revision. alexfh added reviewers: aaron.ballman, chapuni. alexfh added a subscriber: cfe-commits. Add check_clang_tidy.py script that is functionally identical to the check_clang_tidy.py, but should also be functional on windows. I've verified that the script works on linux. W

Re: [PATCH] D12137: Fix 4 typos in test/CodeGenCXX/

loverszhaokai added a comment. Thanks. I am not a committer. @rnk, could you commit this revision ? Thanks. http://reviews.llvm.org/D12137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D12137: Fix 4 typos in test/CodeGenCXX/

timu added a comment. If you are a committer, commit via svn and then close the revision. If you are not, ask some committer to do that for you (sorry, I don't have anything set up right now) and close when it lands. http://reviews.llvm.org/D12137

Re: [PATCH] D12137: Fix 4 typos in test/CodeGenCXX/

loverszhaokai added a comment. What should I do now ? "Close Revision" ? Thanks. http://reviews.llvm.org/D12137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r245528 - Fix one last dynarray test

Author: ericwf Date: Wed Aug 19 19:20:05 2015 New Revision: 245528 URL: http://llvm.org/viewvc/llvm-project?rev=245528&view=rev Log: Fix one last dynarray test Modified: libcxx/trunk/test/libcxx/experimental/containers/sequences/dynarray/dynarray.overview/front_back.pass.cpp Modified: libc

[libcxx] r245525 - Fix more uses of uninitialized values in dynarray

Author: ericwf Date: Wed Aug 19 19:10:22 2015 New Revision: 245525 URL: http://llvm.org/viewvc/llvm-project?rev=245525&view=rev Log: Fix more uses of uninitialized values in dynarray Modified: libcxx/trunk/test/libcxx/experimental/containers/sequences/dynarray/dynarray.data/default.pass.cpp

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

After looking at the code once again, I found an obvious use-after-free bug which could have caused all of this (and for some reason only manifested itself on Darwin). r245524 should fix the issue. On Thu, Aug 20, 2015 at 1:44 AM, Justin Bogner wrote: > That didn't work either - both tests are s

[clang-tools-extra] r245524 - [clang-tidy] Fix use-after-free in UseNullptrCheck.

Author: alexfh Date: Wed Aug 19 18:57:34 2015 New Revision: 245524 URL: http://llvm.org/viewvc/llvm-project?rev=245524&view=rev Log: [clang-tidy] Fix use-after-free in UseNullptrCheck. Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrCheck.cpp clang-tools-extra/trunk/clang

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

That didn't work either - both tests are still failing. Alexander Kornienko writes: > Something weird happens with options reading. Submitted a possible workaround > in r245517. > > On Thu, Aug 20, 2015 at 12:48 AM, Justin Bogner wrote: > > Locally, it seems to fail two tests now: > >

[libcxx] r245522 - Cleanup failing dynarray tests

Author: ericwf Date: Wed Aug 19 18:33:18 2015 New Revision: 245522 URL: http://llvm.org/viewvc/llvm-project?rev=245522&view=rev Log: Cleanup failing dynarray tests Added: libcxx/trunk/test/libcxx/experimental/containers/sequences/dynarray/dynarray.cons/default_throws_bad_alloc.pass.cpp Modif

Re: [PATCH] D12123: [analyzer] Skip Pre/Post handlers for ObjC calls when receiver is nil.

dcoughlin marked 5 inline comments as done. Comment at: include/clang/StaticAnalyzer/Core/CheckerManager.h:96 @@ -95,1 +95,3 @@ +enum class ObjCCheckerKind { + PreVisit, xazax.hun wrote: > I do not really like the name ObjCCheckerKind, because it is not kind of

Re: [PATCH] D12123: [analyzer] Skip Pre/Post handlers for ObjC calls when receiver is nil.

dcoughlin updated the summary for this revision. dcoughlin updated this revision to Diff 32638. dcoughlin added a comment. Update patch to address review comments. I've also updated the CheckerDocumentation checker to document the new ObjCMessageNil callback. This version of the patch also resto

Re: [PATCH] D12169: Relax constexpr rules to improve __builtin_object_size's accuracy

vsk added a subscriber: vsk. vsk added a comment. Just a minor nitpick. Comment at: lib/AST/ExprConstant.cpp:51 @@ -50,1 +50,3 @@ +#include + Do you need ? http://reviews.llvm.org/D12169 ___ cfe-commits mailing

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

Something weird happens with options reading. Submitted a possible workaround in r245517. On Thu, Aug 20, 2015 at 12:48 AM, Justin Bogner wrote: > Locally, it seems to fail two tests now: > > Failing Tests (2): > Clang Tools :: clang-tidy/modernize-use-nullptr-basic.cpp > Clang Tools ::

[clang-tools-extra] r245517 - [clang-tidy] Work around failure in Darwin.

Author: alexfh Date: Wed Aug 19 18:03:23 2015 New Revision: 245517 URL: http://llvm.org/viewvc/llvm-project?rev=245517&view=rev Log: [clang-tidy] Work around failure in Darwin. Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseNullptrCheck.cpp Modified: clang-tools-extra/trunk/clang-

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

Justin Bogner writes: > Locally, it seems to fail two tests now: > > Failing Tests (2): > Clang Tools :: clang-tidy/modernize-use-nullptr-basic.cpp > Clang Tools :: clang-tidy/modernize-use-nullptr.cpp > > I'll poke at it for a minute and see if there's something obvious I can > do, but ru

Re: [PATCH] D12173: [libcxx] Constrain unique_ptr::operator=(unique_ptr) in C++03 mode

EricWF updated this revision to Diff 32631. EricWF added a comment. Update diff so it has more context. http://reviews.llvm.org/D12173 Files: include/memory Index: include/memory === --- include/memory +++ include/memory @@ -265

[PATCH] D12173: [libcxx] Constrain unique_ptr::operator=(unique_ptr) in C++03 mode

EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. This patch properly constrains the converting assignment operator in C++03. It also fixes a bug where std::forward was given the wrong type. The following two tests begin passing in C++03:

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

Locally, it seems to fail two tests now: Failing Tests (2): Clang Tools :: clang-tidy/modernize-use-nullptr-basic.cpp Clang Tools :: clang-tidy/modernize-use-nullptr.cpp I'll poke at it for a minute and see if there's something obvious I can do, but running the run line manually just seem

r245514 - Fix the layout of bitfields in ms_struct unions: their

Author: rjmccall Date: Wed Aug 19 17:42:36 2015 New Revision: 245514 URL: http://llvm.org/viewvc/llvm-project?rev=245514&view=rev Log: Fix the layout of bitfields in ms_struct unions: their alignment is ignored, and they always allocate a complete storage unit. Also, change the dumping of AST rec

[libcxx] r245513 - Add files that got missed in r245512.

Author: ericwf Date: Wed Aug 19 17:35:56 2015 New Revision: 245513 URL: http://llvm.org/viewvc/llvm-project?rev=245513&view=rev Log: Add files that got missed in r245512. Added: libcxx/trunk/test/std/utilities/memory/unique.ptr/unique.ptr.single/unique.ptr.single.asgn/move_convert.pass.cpp R

[libcxx] r245512 - More unique_ptr test cleanup. Fixes in to come later.

Author: ericwf Date: Wed Aug 19 17:35:07 2015 New Revision: 245512 URL: http://llvm.org/viewvc/llvm-project?rev=245512&view=rev Log: More unique_ptr test cleanup. Fixes in to come later. Modified: libcxx/trunk/test/std/utilities/memory/unique.ptr/deleter.h libcxx/trunk/test/std/utilitie

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

Yep, works for me locally. Thanks for fixing it. Pete > On Aug 19, 2015, at 3:24 PM, Alexander Kornienko wrote: > > I've committed the check with minor modifications and without the offending > test in r245511. Could you verify that it works in your setup? > > -- Alex > > On Wed, Aug 19, 201

[PATCH] D12169: Relax constexpr rules to improve __builtin_object_size's accuracy

george.burgess.iv created this revision. george.burgess.iv added a reviewer: rsmith. george.burgess.iv added a subscriber: cfe-commits. (Hoping the formatting works as one would expect) Motivating examples: Pre-patch: ``` __builtin_object_size((char*)&foo, 0) != __builtin_object_size(&foo, 0) //

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

I've committed the check with minor modifications and without the offending test in r245511. Could you verify that it works in your setup? -- Alex On Wed, Aug 19, 2015 at 11:41 PM, Pete Cooper wrote: > > On Aug 19, 2015, at 2:38 PM, Alexander Kornienko > wrote: > > The check has been reverted

[clang-tools-extra] r245511 - [clang-tidy] Add modernize-use-nullptr check, attempt 2.

Author: alexfh Date: Wed Aug 19 17:21:37 2015 New Revision: 245511 URL: http://llvm.org/viewvc/llvm-project?rev=245511&view=rev Log: [clang-tidy] Add modernize-use-nullptr check, attempt 2. This patch re-applies r245434 and r245471 reverted in r245493, and changes the way custom null macros are c

Re: patch: clarify diagnostic when returned value doesn't match function return type

On 10 August 2015 at 19:08, Nick Lewycky wrote: > This simple-minded patch extends the case where we report "no viable > conversion from 'X' to 'Y'" to emit a more useful diagnostic "no viable > conversion from returned value of type 'X' to function return type 'Y'" > when used in that context. >

Re: [clang-tools-extra] r245434 - [clang-tidy] Add use-nullptr check to clang-tidy.

Sorry for the breakage. I was hoping that r245471 fixes it, but apparently, it didn't. And yes, we may need help reproducing the issue / testing possible fixes, as the only platform where the test fails, is Darwin. On Wed, Aug 19, 2015 at 10:32 PM, Justin Bogner wrote: > Justin Bogner writes: >

[clang-tools-extra] r245510 - Remove empty destructors added in r245500. I got confused by my

Author: djasper Date: Wed Aug 19 17:04:55 2015 New Revision: 245510 URL: http://llvm.org/viewvc/llvm-project?rev=245510&view=rev Log: Remove empty destructors added in r245500. I got confused by my YouCompleteMe setup which apparently doesn't find the base classes and thus doesn't understand that

r245509 - Add missing comment.

Author: rsmith Date: Wed Aug 19 16:59:52 2015 New Revision: 245509 URL: http://llvm.org/viewvc/llvm-project?rev=245509&view=rev Log: Add missing comment. Modified: cfe/trunk/include/clang/Sema/Sema.h Modified: cfe/trunk/include/clang/Sema/Sema.h URL: http://llvm.org/viewvc/llvm-project/cfe/

Re: [PATCH] D11950: [CUDA] Check register names on appropriate side of cuda compilation only.

eliben accepted this revision. eliben added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D11950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: FunctionDecl::getBody() returning nullptr

On Wed, Aug 19, 2015 at 5:23 PM, Richard Smith wrote: > It looks like this would only happen for a late-parsed template that the > analysis code is checking before it is parsed. Should we really be running > these checks at all in that case? This code is being called from DataRecursiveASTVisitor

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

eugenis added a comment. The test for virtual base that you added effectively disables the aliasing test, because Derived now has non-trivial members. Move it to a separate file. Comment at: test/CodeGenCXX/sanitize-dtor-repress-aliasing.cpp:38 @@ +37,3 @@ +// Declaration of vi

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

> On Aug 19, 2015, at 2:38 PM, Alexander Kornienko wrote: > > The check has been reverted in r245493. Sorry for the breakage, I was hoping > that this commit fixes it. No problem. Thanks for taking a look. If you think the rest of the code is good and want to land it again then thats fine.

Re: [PATCH] D12164: Stop treating -static as overriding -fPIC: they are distinct.

joerg accepted this revision. joerg added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D12164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

The check has been reverted in r245493. Sorry for the breakage, I was hoping that this commit fixes it. On Wed, Aug 19, 2015 at 10:31 PM, Pete Cooper wrote: > Looks like its only a single test thats failing. > > Would you mind if I remove this piece of the test until we can get to the > bottom o

r245507 - Fix -Wlogical-not-parentheses to work better with C code.

Author: rtrieu Date: Wed Aug 19 16:33:54 2015 New Revision: 245507 URL: http://llvm.org/viewvc/llvm-project?rev=245507&view=rev Log: Fix -Wlogical-not-parentheses to work better with C code. Remove the assumption of a Boolean type by checking if an expression is known to have a boolean value. Di

Re: FunctionDecl::getBody() returning nullptr

It looks like this would only happen for a late-parsed template that the analysis code is checking before it is parsed. Should we really be running these checks at all in that case? Also, it looks like this code doesn't actually want the body at all, and just wants to get the location of the defin

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

rsmith added a subscriber: rsmith. Comment at: include/clang/Frontend/CodeGenOptions.def:164-165 @@ -163,1 +163,4 @@ +CODEGENOPT(DebugTypeExtRefs, 1, 0) ///< Whether or not debug info should contain + ///< external references to a PCH or module

Re: [PATCH] D11694: [CUDA] Added stubs for __nvvm_atom_add*_d()

This revision was automatically updated to reflect the committed changes. Closed by commit rL245502: [CUDA] Added stubs for __nvvm_atom_add_*_d() builtins. (authored by tra). Changed prior to commit: http://reviews.llvm.org/D11694?vs=31157&id=32616#toc Repository: rL LLVM http://reviews.llv

r245502 - [CUDA] Added stubs for __nvvm_atom_add_*_d() builtins.

Author: tra Date: Wed Aug 19 16:11:37 2015 New Revision: 245502 URL: http://llvm.org/viewvc/llvm-project?rev=245502&view=rev Log: [CUDA] Added stubs for __nvvm_atom_add_*_d() builtins. They show up in CUDA headers but are not currently supported by NVPTX back-end. Differential Revision: http://r

r245501 - [modules] Don't needlessly bounce through Sema when updating exception specifications.

Author: rsmith Date: Wed Aug 19 16:09:32 2015 New Revision: 245501 URL: http://llvm.org/viewvc/llvm-project?rev=245501&view=rev Log: [modules] Don't needlessly bounce through Sema when updating exception specifications. Modified: cfe/trunk/lib/Serialization/ASTReader.cpp Modified: cfe/trunk

Re: [clang-tools-extra] r244586 - Add an IncludeInserter to clang-tidy.

On Tue, Aug 11, 2015 at 1:37 PM, Manuel Klimek via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: klimek > Date: Tue Aug 11 06:37:48 2015 > New Revision: 244586 > > URL: http://llvm.org/viewvc/llvm-project?rev=244586&view=rev > Log: > Add an IncludeInserter to clang-tidy. > > Will be u

[clang-tools-extra] r245500 - Fix IncludeInserter to allow for more than one added header per file.

Author: djasper Date: Wed Aug 19 16:02:27 2015 New Revision: 245500 URL: http://llvm.org/viewvc/llvm-project?rev=245500&view=rev Log: Fix IncludeInserter to allow for more than one added header per file. Also adapt tests a bit to make it possible to test this. Removed checking the number of error

Re: [PATCH] D11950: [CUDA] Check register names on appropriate side of cuda compilation only.

tra added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5944 @@ -5943,3 +5943,3 @@ ProcessDeclAttributes(S, NewVD, D); - + bool ShouldHandleTargetErrors = DeclAttrsMatchCUDAMode(getLangOpts(), NewVD); if (getLangOpts().CUDA) { eliben wrote: > Since thi

Re: [PATCH] D11950: [CUDA] Check register names on appropriate side of cuda compilation only.

tra updated this revision to Diff 32611. tra added a comment. Removed rarely used temp var. http://reviews.llvm.org/D11950 Files: lib/Sema/SemaDecl.cpp lib/Sema/SemaStmtAsm.cpp test/SemaCUDA/asm-constraints-mixed.cu Index: test/SemaCUDA/asm-constraints-mixed.cu ==

Re: [PATCH] D11694: [CUDA] Added stubs for __nvvm_atom_add*_d()

eliben accepted this revision. eliben added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D11694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

Thanks for the spot yaron. I had only tested x64 at the time as that's what the original bug report was for. I can confirm that your fix does infact fix i686 Many Thanks Martell On Wed, Aug 19, 2015 at 1:22 PM, Yaron Keren wrote: > Yes, worth merging with Richard approval. > > 2015-08-19 23:16

Re: [PATCH] D11694: [CUDA] Added stubs for __nvvm_atom_add*_d()

tra added a comment. Ping. http://reviews.llvm.org/D11694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

nmusgrave updated this revision to Diff 32608. nmusgrave added a comment. - More complex testing for destruction order. Tests class with base, virtual base, trivial, and nontrivial member to ensure destruction order is correct. http://reviews.llvm.org/D12022 Files: lib/CodeGen/CGCXX.cpp li

r245497 - Internal-linkage variables with constant-evaluatable initializers do not need to be emitted. (Also reduces the set of variables that need to be eagerly deserialized when using PCH / modules.

Author: rsmith Date: Wed Aug 19 15:49:38 2015 New Revision: 245497 URL: http://llvm.org/viewvc/llvm-project?rev=245497&view=rev Log: Internal-linkage variables with constant-evaluatable initializers do not need to be emitted. (Also reduces the set of variables that need to be eagerly deserialize

r245496 - [CUDA] Add appropriate host/device attribute to builtins.

Author: tra Date: Wed Aug 19 15:48:20 2015 New Revision: 245496 URL: http://llvm.org/viewvc/llvm-project?rev=245496&view=rev Log: [CUDA] Add appropriate host/device attribute to builtins. Differential Revision: http://reviews.llvm.org/D12122 Added: cfe/trunk/test/SemaCUDA/builtins.cu Modifie

Re: [PATCH] D12122: [CUDA] Add appropriate host/device attribute to target-specific builtins.

This revision was automatically updated to reflect the committed changes. Closed by commit rL245496: [CUDA] Add appropriate host/device attribute to builtins. (authored by tra). Changed prior to commit: http://reviews.llvm.org/D12122?vs=32481&id=32607#toc Repository: rL LLVM http://reviews.

Re: FunctionDecl::getBody() returning nullptr

The attached patch resolves the null pointer crash I am seeing. ~Aaron On Wed, Aug 19, 2015 at 1:24 PM, Aaron Ballman wrote: > On Wed, Aug 19, 2015 at 11:33 AM, Aaron Ballman > wrote: >> When I run the following test code through clang-tidy -checks=*, I get >> a crash from some relatively stra

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

Looks like its only a single test thats failing. Would you mind if I remove this piece of the test until we can get to the bottom of it? void test_macro_expansion4() { #define MY_NULL NULL int *p = MY_NULL; // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: use nullptr [modernize-use-nullptr] /

Re: [clang-tools-extra] r245434 - [clang-tidy] Add use-nullptr check to clang-tidy.

Justin Bogner writes: > Alexander Kornienko via cfe-commits writes: >> Author: alexfh >> Date: Wed Aug 19 08:13:12 2015 >> New Revision: 245434 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=245434&view=rev >> Log: >> [clang-tidy] Add use-nullptr check to clang-tidy. >> >> Move UseNullptr fro

[clang-tools-extra] r245493 - Revert "[clang-tidy] Add use-nullptr check to clang-tidy."

Author: bogner Date: Wed Aug 19 15:30:07 2015 New Revision: 245493 URL: http://llvm.org/viewvc/llvm-project?rev=245493&view=rev Log: Revert "[clang-tidy] Add use-nullptr check to clang-tidy." The new test is failing on darwin: http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/10

[clang-tools-extra] r245492 - Replacing a custom AST matcher with some builtin AST matchers; NFC, and existing tests should provide sufficient coverage.

Author: aaronballman Date: Wed Aug 19 15:26:22 2015 New Revision: 245492 URL: http://llvm.org/viewvc/llvm-project?rev=245492&view=rev Log: Replacing a custom AST matcher with some builtin AST matchers; NFC, and existing tests should provide sufficient coverage. Modified: clang-tools-extra/tr

Fwd: [PATCH] Have clang list the imported modules in the debug info

(add the right list) -- Forwarded message -- From: David Blaikie Date: Wed, Aug 19, 2015 at 1:20 PM Subject: Re: [PATCH] Have clang list the imported modules in the debug info To: Adrian Prantl Cc: Eric Christopher , Zachary Turner < ztur...@google.com>, "Robinson, Paul" , Richard

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

Yes, worth merging with Richard approval. 2015-08-19 23:16 GMT+03:00 Hans Wennborg : > I assume this is a merge request? > > Richard: what do you think about r245459+r245462? > > > > On Wed, Aug 19, 2015 at 10:22 AM, Yaron Keren > wrote: > > Sorry to notice late (just diagnosed the issue from a

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

> On Aug 19, 2015, at 1:12 PM, David Blaikie wrote: > > > > On Tue, Aug 11, 2015 at 1:49 PM, Adrian Prantl > wrote: > aprantl created this revision. > aprantl added reviewers: dblaikie, echristo. > aprantl added a subscriber: cfe-commits. > aprantl set the repository

Re: r220305 - Driver: Move crash report command mangling into Command::Print

On Wed, Aug 12, 2015 at 5:00 PM, Justin Bogner wrote: > On Wed, Aug 12, 2015 at 3:09 PM, David Blaikie wrote: > > On Tue, Oct 21, 2014 at 10:24 AM, Justin Bogner > > wrote: > >> Author: bogner > >> Date: Tue Oct 21 12:24:44 2014 > >> New Revision: 220305 > >> > >> URL: http://llvm.org/viewvc/ll

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

I assume this is a merge request? Richard: what do you think about r245459+r245462? On Wed, Aug 19, 2015 at 10:22 AM, Yaron Keren wrote: > Sorry to notice late (just diagnosed the issue from a failing boost::math > test), according to i686 ABI, long double size on x86 is 12 bytes (the > memory

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

On Tue, Aug 11, 2015 at 1:49 PM, Adrian Prantl wrote: > aprantl created this revision. > aprantl added reviewers: dblaikie, echristo. > aprantl added a subscriber: cfe-commits. > aprantl set the repository for this revision to rL LLVM. > > This patch adds a -gmodules option to the driver and a -d

r245489 - Generating available_externally vtables bugfix

Author: prazek Date: Wed Aug 19 15:09:09 2015 New Revision: 245489 URL: http://llvm.org/viewvc/llvm-project?rev=245489&view=rev Log: Generating available_externally vtables bugfix Bugfix revealed in r245264. http://reviews.llvm.org/D12128 Modified: cfe/trunk/include/clang/AST/VTableBuilder.

Re: [clang-tools-extra] r245434 - [clang-tidy] Add use-nullptr check to clang-tidy.

Alexander Kornienko via cfe-commits writes: > Author: alexfh > Date: Wed Aug 19 08:13:12 2015 > New Revision: 245434 > > URL: http://llvm.org/viewvc/llvm-project?rev=245434&view=rev > Log: > [clang-tidy] Add use-nullptr check to clang-tidy. > > Move UseNullptr from clang-modernize to modernize mod

Re: [PATCH] D10556: [Headers][X86] Replace avx2.pbroadcast intrinsics with native IR.

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. LGTM. See discussion in http://reviews.llvm.org/D10555. http://reviews.llvm.org/D10556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

nmusgrave updated this revision to Diff 32600. nmusgrave added a comment. - CFE test for dtor aliasing, and repression of aliasing in dtor code generation. http://reviews.llvm.org/D12022 Files: lib/CodeGen/CGCXX.cpp lib/CodeGen/CGClass.cpp test/CodeGenCXX/sanitize-dtor-repress-aliasing.c

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

Hi Alexander We’re still getting a green dragon failure on the null ptr check test. Mind taking a look? http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/10351/consoleFull#50560140149ba4694-19c4-4d7e-bec5-911270d8a58c

Re: [PATCH] D12143: [X86][AVX2] Replace avx2.pbroadcast / avx2.vbroadcast intrinsics usage in avx2intrin.h with __builtin_shufflevector

RKSimon abandoned this revision. RKSimon added a comment. In http://reviews.llvm.org/D12143#228006, @ab wrote: > Heh, this is http://reviews.llvm.org/D10556, no? :P Yes you're right (and you remembered to kill the builtin defs) - please can you add some more reviewers so that we can get it dea

Re: [PATCH] D11194: Instantiate function declarations in instantiated functions.

sepavloff updated this revision to Diff 32597. sepavloff added a comment. Lambda functions are now treated as local classes. http://reviews.llvm.org/D11194 Files: include/clang/AST/DeclBase.h lib/AST/DeclBase.cpp lib/Sema/SemaTemplateInstantiate.cpp lib/Sema/SemaTemplateInstantiateDecl.

[clang-tools-extra] r245484 - Replacing a custom AST matcher with some builtin AST matchers; NFC, and existing tests should provide sufficient coverage.

Author: aaronballman Date: Wed Aug 19 14:29:23 2015 New Revision: 245484 URL: http://llvm.org/viewvc/llvm-project?rev=245484&view=rev Log: Replacing a custom AST matcher with some builtin AST matchers; NFC, and existing tests should provide sufficient coverage. Modified: clang-tools-extra/tr

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

eugenis added a comment. +cfe-commits http://reviews.llvm.org/D12022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

ahatanak updated this revision to Diff 32592. ahatanak added a comment. This patch makes changes to record function attribute "force-align-stack" instead of recording it as a subtarget feature. http://reviews.llvm.org/D11815 Files: include/clang/Driver/CC1Options.td include/clang/Frontend/

Re: [PATCH] D11781: Refactored pthread usage in libcxx

EricWF added a comment. In http://reviews.llvm.org/D11781#227606, @espositofulvio wrote: > In http://reviews.llvm.org/D11781#227446, @EricWF wrote: > > > This patch has a long way to go but it has also come a long way. Here are a > > couple of problems I see with it. > > > > 2. This patch adds a

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

Yes, it looks like a legacy issue. Documentation says so: *https://gcc.gnu.org/onlinedocs/gcc-4.8.2/gcc/i386-and-x86-64-Options.html * -m96bit-long-double-m128bit-long-doubleThese switches control the size of long double t

Re: [PATCH] D12047: test/SemaObjC: Remove cruft in unused getter test

rjmccall added a comment. Sure, fine to me. http://reviews.llvm.org/D12047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12128: Generating available_externally vtables bugfix

Prazek updated this revision to Diff 32587. http://reviews.llvm.org/D12128 Files: include/clang/AST/VTableBuilder.h lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/vtable-available-externally.cpp Index: test/CodeGenCXX/vtable-available-externally.cpp =

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

On Wed, Aug 19, 2015 at 10:02 AM, Yaron Keren via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: yrnkrn > Date: Wed Aug 19 12:02:32 2015 > New Revision: 245459 > > URL: http://llvm.org/viewvc/llvm-project?rev=245459&view=rev > Log: > According to i686 ABI, long double size on x86 is 12

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

jroelofs added a comment. In http://reviews.llvm.org/D11963#228024, @EricWF wrote: > Wouldn't it still be a mess if you build both libc++ and libc++abi > out-of-tree? The user would have to be aware of these weird requirements. Oh, yeah, true. Do we have any out-of-tree builders to make sure t

  1   2   >