Re: [cdesktopenv-devel] nsgmls symbol collision on illumos/OpenIndiana

2018-06-15 Thread Jon Trulson
merged to master, thanks! -jon On 06/15/2018 12:05 AM, Matthew R. Trower wrote: Jon Trulson writes: I can add this, but for safety/clarity, can you change the comparison from: #if __SUNPRO_CC == 0x5100 to #if defined(__SUNPRO_CC) && __SUNPRO_CC == 0x5100 This is a little clearer and won't

Re: [cdesktopenv-devel] nsgmls symbol collision on illumos/OpenIndiana

2018-06-14 Thread Matthew R. Trower
Jon Trulson writes: > I can add this, but for safety/clarity, can you change the comparison from: > > #if __SUNPRO_CC == 0x5100 > > to > > #if defined(__SUNPRO_CC) && __SUNPRO_CC == 0x5100 > > This is a little clearer and won't emit warnings under -Wundef on > non-studio c compilers... Certainly

Re: [cdesktopenv-devel] nsgmls symbol collision on illumos/OpenIndiana

2018-06-14 Thread Jon Trulson
On 06/13/2018 09:45 PM, Matthew R. Trower wrote: d...@blackshard.net (Matthew R. Trower) writes: I'll try to set up an environment with 12.3 tomorrow, and see what happens. Alright, so... SolarisStudio12.3 compiles this fine. SunStudio12.1 encounters the problem. It seems to me this is p

Re: [cdesktopenv-devel] nsgmls symbol collision on illumos/OpenIndiana

2018-06-13 Thread Matthew R. Trower
d...@blackshard.net (Matthew R. Trower) writes: > I'll try to set up an environment with 12.3 tomorrow, and see what > happens. > > Alright, so... SolarisStudio12.3 compiles this fine. SunStudio12.1 encounters the problem. It seems to me this is probably a compiler bug, then. However... Poli

Re: [cdesktopenv-devel] nsgmls symbol collision on illumos/OpenIndiana

2018-06-11 Thread Matthew R. Trower
Ulrich Wilkens writes: > On 06/11/18 04:30, Matthew R. Trower wrote: > >> >> Nah. The issue is traceable back to Ptr.C and Ptr.h. Stripping out >> preprocessor #if noise, the generated entmgr_inst.C tries to do this: >> >> --- >>template class Ptr; >>template class ConstPtr; >> --- >> >

Re: [cdesktopenv-devel] nsgmls symbol collision on illumos/OpenIndiana

2018-06-10 Thread Ulrich Wilkens
On 06/11/18 04:30, Matthew R. Trower wrote: Nah. The issue is traceable back to Ptr.C and Ptr.h. Stripping out preprocessor #if noise, the generated entmgr_inst.C tries to do this: --- template class Ptr; template class ConstPtr; --- class Ptr defines and implements a 'clear()' method

Re: [cdesktopenv-devel] nsgmls symbol collision on illumos/OpenIndiana

2018-06-10 Thread Matthew R. Trower
d...@blackshard.net (Matthew R. Trower) writes: > Here's a potential patch which solves this issue for me. It should, in > my estimation, be functionally equivalent. Though, I'm still curious as > to whether Ulrich gets a clean build without it, and if so, why. > > Thoughts? Heck, even better..

Re: [cdesktopenv-devel] nsgmls symbol collision on illumos/OpenIndiana

2018-06-10 Thread Matthew R. Trower
Here's a potential patch which solves this issue for me. It should, in my estimation, be functionally equivalent. Though, I'm still curious as to whether Ulrich gets a clean build without it, and if so, why. Thoughts? -- Matthew R. Trower >From 35f1b6ad5d76effa03793d3e8ff9bbd756c22e46 Mon S

Re: [cdesktopenv-devel] nsgmls symbol collision on illumos/OpenIndiana

2018-06-10 Thread Matthew R. Trower
Jon Trulson writes: > > That looks like the compiler can't tell the difference between a const > and non-const definition. Perhaps you need to define: > > -DSP_VOLATILE=volatile -DSP_CONST=const > > for your architecture in programs/nsgmls/Imakefile like Linux and BSD. > > You might look an see

Re: [cdesktopenv-devel] nsgmls symbol collision on illumos/OpenIndiana

2018-06-09 Thread Jon Trulson
On 06/09/2018 05:23 PM, Matthew R. Trower wrote: Build log attached. Also attached is a WorksForMe patch, which I've been using to work around the issue for some time. Apparently these extra definitions are not a problem on other platforms, and presumedly there's some reason for them to be th

Re: [cdesktopenv-devel] nsgmls

2012-08-11 Thread Jon Trulson
On Sat, 11 Aug 2012, Pascal Stumpf wrote: > See patch. > Applied. -- Jon Trulson "If the Martian rope-a-dope don't get him, he'll get himself, he'll come in too fast and punch himself out." - one of my brothers, referring to the Curiosity landing. --

[cdesktopenv-devel] nsgmls

2012-08-11 Thread Pascal Stumpf
See patch. >From d6d86e42f39b750f965608e359b9d05efc1c7732 Mon Sep 17 00:00:00 2001 From: Pascal Stumpf Date: Sat, 11 Aug 2012 14:09:40 +0200 Subject: [PATCH] Make nsgmls compile on OpenBSD. As far as I can tell, the duplicate instantiations from entmgr_inst.m4 are unnecessary and only cause compi