On 06/13/2018 09:45 PM, Matthew R. Trower wrote:
d...@blackshard.net (Matthew R. Trower) writes:

I'll try to set up an environment with 12.3 tomorrow, and see what
happens.



Alright, so...

SolarisStudio12.3 compiles this fine.  SunStudio12.1 encounters the
problem.  It seems to me this is probably a compiler bug, then.

However...

Political reasons aside, SunStudio is available in-repo, from
OpenSolaris through latest OpenIndiana Hipster, with no Oracle account
required, no signed repos, no hassling with web downloads, etc... It's
there, and it won't be updated.  Seeing as it's just this one line of
code preventing a clean build, I'd really like to maintain support for
this version.

Jon, would you be willing to apply either my previous one-liner (which
Ulrich confirmed works fine for him), or the patch I've attached here
(which just wraps that one-liner to only compile on SunStudio 12.1, and
explains it so no one unwittingly reverts it)?


I can add this, but for safety/clarity, can you change the comparison from:

#if __SUNPRO_CC == 0x5100

to

#if defined(__SUNPRO_CC) && __SUNPRO_CC == 0x5100

This is a little clearer and won't emit warnings under -Wundef on non-studio c compilers...

-jon


-- Matthew R. Trower



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot



_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel


--
Jon Trulson

"Fire all weapons and open a hailing frequency for my victory yodle."

                              - Zapp Brannigan

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel

Reply via email to