This patch makes tooltalk useful, letting many features work: logout,
virtual desktop switching,
and calling the dtfile command while it is running (which before just
created a hung process).
Before all tooltalk messages failed during sending, giving
TT_ERR_INTERNAL results.
The original code that
On Sat, 11 Aug 2012, Frederic Koehler wrote:
> The first patch (for tttrace) actually does fix a potential issue
> [described in patch].
>
> Still tooltalk does not really work on 64-bit; by using tttrace, you
> can see that pretty much whenever
> tt_message_send is used, TT_ERR_INTERNAL comes bac
On Sat, 11 Aug 2012, Pascal Stumpf wrote:
> See patch.
>
Applied.
--
Jon Trulson
"If the Martian rope-a-dope don't get him, he'll get himself, he'll
come in too fast and punch himself out."
- one of my brothers, referring to the Curiosity landing.
--
On Sat, 11 Aug 2012, Pascal Stumpf wrote:
> See patch.
>
Applied.
--
Jon Trulson
"If the Martian rope-a-dope don't get him, he'll get himself, he'll
come in too fast and punch himself out."
- one of my brothers, referring to the Curiosity landing.
--
On Sat, 11 Aug 2012, Pascal Stumpf wrote:
> See patch.
>
Applied.
--
Jon Trulson
"If the Martian rope-a-dope don't get him, he'll get himself, he'll
come in too fast and punch himself out."
- one of my brothers, referring to the Curiosity landing.
--
On Sat, 11 Aug 2012, Pascal Stumpf wrote:
> See patch.
>
Applied.
--
Jon Trulson
"If the Martian rope-a-dope don't get him, he'll get himself, he'll
come in too fast and punch himself out."
- one of my brothers, referring to the Curiosity landing.
--
On Sat, 11 Aug 2012, Pascal Stumpf wrote:
> See patch.
>
Applied.
--
Jon Trulson
"If the Martian rope-a-dope don't get him, he'll get himself, he'll
come in too fast and punch himself out."
- one of my brothers, referring to the Curiosity landing.
-
On Sat, 11 Aug 2012, Pascal Stumpf wrote:
> See patch.
>
Applied.
--
Jon Trulson
"If the Martian rope-a-dope don't get him, he'll get himself, he'll
come in too fast and punch himself out."
- one of my brothers, referring to the Curiosity landing.
-
On Sat, 11 Aug 2012, Pascal Stumpf wrote:
> On Sat, 11 Aug 2012 13:52:08 +0200, Marc Balmer wrote:
>> Wouldn't it be better to avoid the multiplication in malloc here, too?
>>
>> i.e. instead of
>>
>>> sets = (std::ostrstream **)
>>> + malloc(sizeof(std::ostrstream *) * sets_max)
On Sat, 11 Aug 2012, Pascal Stumpf wrote:
> See patch.
>
Applied, thanks.
--
Jon Trulson
"If the Martian rope-a-dope don't get him, he'll get himself, he'll
come in too fast and punch himself out."
- one of my brothers, referring to the Curiosity landing.
-
On Sat, 11 Aug 2012, Pascal Stumpf wrote:
> dtcalc, dthelp, dtimsstart. Please also keep in mind that the Imakefile
> diffs really need to be committed in order to make things for me easier
> on OpenBSD.
>
Applied - and regarding the Imakefile patches. In the future could
you, when a patch is r
On Sat, 11 Aug 2012, William Schaub wrote:
> I also found a double free error in parser.c that caused me some grief.
> Attached are both the original patch and the parser.c patch for dtcreate.
>
Applied both of these, thanks!
--
Jon Trulson
"If the Martian rope-a-dope don't get him, he'll get
On Fri, 10 Aug 2012, ch...@chriswareham.net wrote:
> Hi folks,
>
> I've taken into account peoples comments with regard to patch format and not
> including changes that are just reformatting. The attached patch is solely for
> imake, adding function prototypes where they are missing, limiting link
On Fri, 10 Aug 2012, Marc Balmer wrote:
> Am 10.08.12 07:57, schrieb Marc Balmer:
>> Am 10.08.12 04:29, schrieb Aaron W. Hsu:
>>> Jon Trulson writes:
>>>
Hmmm... I'm leary of introducing further dependancies... Is it really
worth it? Do you have any idea how many strcpy et. al. are in
The first patch (for tttrace) actually does fix a potential issue
[described in patch].
Still tooltalk does not really work on 64-bit; by using tttrace, you
can see that pretty much whenever
tt_message_send is used, TT_ERR_INTERNAL comes back.
0001-tttrace-Fix-bad-usage-of-va_arg-with-enums.patc
I also found a double free error in parser.c that caused me some grief.
Attached are both the original patch and the parser.c patch for dtcreate.
>From 7f64a9c4e8f8108021f5f65e9210bdc994232e40 Mon Sep 17 00:00:00 2001
From: William Schaub
Date: Sat, 11 Aug 2012 04:02:17 -0400
Subject: [PATCH 1/2]
On Sat, 11 Aug 2012 13:52:08 +0200, Marc Balmer wrote:
> Wouldn't it be better to avoid the multiplication in malloc here, too?
>
> i.e. instead of
>
> > sets = (std::ostrstream **)
> > + malloc(sizeof(std::ostrstream *) * sets_max);
>
> use
>
> > sets = (std::ostrstream **)
>
See patch.
>From 5cb4665c3777b64fd1b6d56d9ec947dcef91301b Mon Sep 17 00:00:00 2001
From: Pascal Stumpf
Date: Sat, 11 Aug 2012 14:12:47 +0200
Subject: [PATCH] OpenBSD patches for ttsnoop.
Mostly adding std:: for strstream interfaces.
---
cde/programs/ttsnoop/DtTt.C | 26 +++
See patch.
>From d6d86e42f39b750f965608e359b9d05efc1c7732 Mon Sep 17 00:00:00 2001
From: Pascal Stumpf
Date: Sat, 11 Aug 2012 14:09:40 +0200
Subject: [PATCH] Make nsgmls compile on OpenBSD.
As far as I can tell, the duplicate instantiations from entmgr_inst.m4 are
unnecessary and only cause compi
See patch.
>From 8f32716f7b34ab01357b42e6040596b1b967653b Mon Sep 17 00:00:00 2001
From: Pascal Stumpf
Date: Sat, 11 Aug 2012 14:08:03 +0200
Subject: [PATCH] OpenBSD #ifdefs for imake templates for localisations.
---
cde/programs/localized/templates/French.tmpl |2 +-
cde/programs/loca
See patch.
>From 13e8eae8cc80c5e694c45ce0b10e37418fd7fb5b Mon Sep 17 00:00:00 2001
From: Pascal Stumpf
Date: Sat, 11 Aug 2012 14:04:50 +0200
Subject: [PATCH] Patches for dtscreen, dtsearchpath, dtsession on OBSD.
Do not redefine round(3), and provide a manpath for OpenBSD.
(this is one of the few
See patch.
>From 80a1a1b8552b51b0d4acc18e6756d5da5d8350dd Mon Sep 17 00:00:00 2001
From: Pascal Stumpf
Date: Sat, 11 Aug 2012 14:01:14 +0200
Subject: [PATCH] OpenBSD patches for dtpdmd and dtprintinfo.
Casts, #ifdefs, SIGCLD ...
---
cde/programs/dtpdmd/manager.c |2 +-
c
See patch.
>From 2ec9c4b8b1368229eaf4e458808d6121d882595a Mon Sep 17 00:00:00 2001
From: Pascal Stumpf
Date: Sat, 11 Aug 2012 13:57:26 +0200
Subject: [PATCH] Current state of my dtmail work.
Mostly #ifdefs and casts; also, do not redefine strcasestr(). This will
probably be needed for Linux too
Wouldn't it be better to avoid the multiplication in malloc here, too?
i.e. instead of
> sets = (std::ostrstream **)
> + malloc(sizeof(std::ostrstream *) * sets_max);
use
> sets = (std::ostrstream **)
> + calloc(sizeof(std::ostrstream *), sets_max);
(to
See patch.
>From 6081cf4c4ad8370c69bf0571a61d8adccc007712 Mon Sep 17 00:00:00 2001
From: Pascal Stumpf
Date: Sat, 11 Aug 2012 13:49:07 +0200
Subject: [PATCH] Make dtlogin compile on OpenBSD.
Most importantly, we *cannot* do the utmp stuff this code is attempting.
It is SysV-specific.
---
cde/pro
See patch.
>From e1739161c2bc99c37ccce4b74d1ef42f45279e77 Mon Sep 17 00:00:00 2001
From: Pascal Stumpf
Date: Sat, 11 Aug 2012 13:43:57 +0200
Subject: [PATCH] Make dtinfo work on OpenBSD.
strstream.h is now called "strstream" and is obsolete, but use it anyway until
all code is converted over. Th
dtcalc, dthelp, dtimsstart. Please also keep in mind that the Imakefile
diffs really need to be committed in order to make things for me easier
on OpenBSD.
>From 4aedd5a34ef2edd6f375be23753902fe659ae248 Mon Sep 17 00:00:00 2001
From: Pascal Stumpf
Date: Sat, 11 Aug 2012 13:38:22 +0200
Subject: [P
On 08/11/2012 04:25 AM, Pascal Stumpf wrote:
On Sat, 11 Aug 2012 04:16:49 -0400, William Schaub wrote:
On 08/11/2012 03:56 AM, William Schaub wrote:
On 08/11/2012 03:18 AM, Marc Balmer wrote:
A few comments:
Since sizeof(char) is 1, it is not needed to write
malloc(... + 5 * sizeof(char))
b
On Sat, 11 Aug 2012 04:16:49 -0400, William Schaub wrote:
> On 08/11/2012 03:56 AM, William Schaub wrote:
> > On 08/11/2012 03:18 AM, Marc Balmer wrote:
> >> A few comments:
> >>
> >> Since sizeof(char) is 1, it is not needed to write
> >>
> >> malloc(... + 5 * sizeof(char))
> >>
> >> but just
> >>
On 08/11/2012 03:56 AM, William Schaub wrote:
On 08/11/2012 03:18 AM, Marc Balmer wrote:
A few comments:
Since sizeof(char) is 1, it is not needed to write
malloc(... + 5 * sizeof(char))
but just
malloc(... + 5)
And actually, only 4 extra characters are needed, so don't waste that
byte ;)
On 08/11/2012 03:18 AM, Marc Balmer wrote:
> A few comments:
>
> Since sizeof(char) is 1, it is not needed to write
>
> malloc(... + 5 * sizeof(char))
>
> but just
>
> malloc(... + 5)
>
> And actually, only 4 extra characters are needed, so don't waste that
> byte ;)
>
> And never use a multiplicat
A few comments:
Since sizeof(char) is 1, it is not needed to write
malloc(... + 5 * sizeof(char))
but just
malloc(... + 5)
And actually, only 4 extra characters are needed, so don't waste that
byte ;)
And never use a multiplication in a malloc, never, ever. It has been
the source of remote-
32 matches
Mail list logo
