Review: Needs Fixing
Added a few comments -- my biggest issue is that the script is VACUUMing the
database, and locking it to do so. I'm generally of the opinion that VACUUM is
misunderstood and over-utilized, but here the ultimate purpose of this script
is to backup the database. In this case,
Hmmm, a thought occurred to me that I'm not actually sure VACUUM INTO *doesn't*
lock the database. I've always assumed that to be the case, but I can't say
I've used it in a concurrent circumstance before, and re-reading the
documentation doesn't explicitly say so (just that it's "... an alterna
Checked with the SQLite command line against a database being accessed by
separate processes; no issues running VACUUM INTO against the database whilst
another connection was holding a pending transaction with writes, so this
should be a reasonable option here.
--
https://code.launchpad.net/~an
> object_path = "%s/%s" % (now, DB_PATH.rsplit("/", maxsplit=1)[-1] + ".gz")
> AttributeError: 'PosixPath' object has no attribute 'rsplit'
Sorry, I'd meant to imply in the review that string manipulation generally
shouldn't be used for path handling now that pathlib.Path is part of the
stdl
Review: Needs Fixing
Added a bunch of notes but it's mostly trivial stuff (unnecessary globals).
There's a few bits that warrant a bit of attention though (and/or explanation
as to why they're actually correct). Looking much better though, thanks!
Diff comments:
> diff --git a/charms/focal/aut
Public bug reported:
I'm currently running through the ISO tests for Ubuntu 22.04.4
(https://iso.qa.ubuntu.com/qatracker/milestones/451/builds) on various
Raspberry Pi models. Unfortunately, the Pi 5 4GB and 8GB models are
listed as ones that should be tested (e.g.
https://iso.qa.ubuntu.com/qatrac
Now affecting the 22.04.4 jammy ISO
** Also affects: ubiquity (Ubuntu Jammy)
Importance: Undecided
Status: New
** Changed in: ubiquity (Ubuntu Jammy)
Status: New => Confirmed
--
You received this bug notification because you are a member of
Canonical's Ubuntu QA, which is subsc
** Changed in: ubiquity (Ubuntu Jammy)
Importance: Undecided => Low
** Changed in: ubiquity (Ubuntu Noble)
Milestone: ubuntu-24.03 => None
** Changed in: ubiquity (Ubuntu Noble)
Milestone: None => ubuntu-24.04
--
You received this bug notification because you are a member of
Canonica
Failed to reproduce this on the jammy .4 images during ISO testing.
Possibility it's either fixed or only occurs on later versions. Will
attempt to reproduce on mantic later, if I've got the time.
--
You received this bug notification because you are a member of
Canonical's Ubuntu QA, which is su
Occurred on the jammy .4 images during ISO testing
--
You received this bug notification because you are a member of
Canonical's Ubuntu QA, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1993347
Title:
Wrong audio output selected by default on Pi 4
Status in PipeWire:
New
St
Review: Approve
This looks much better! I see ConfigParser.read is still in use (as opposed to
ConfigParser.read_file), but there's no point blocking the merge for that as it
really wouldn't matter to production anyway; if the config file were missing
it'll fail with a missing key shortly after
Review: Needs Fixing
Left a few diff comments -- I very much like this approach though!
Diff comments:
> diff --git a/charms/focal/autopkgtest-web/webcontrol/sqlite-writer
> b/charms/focal/autopkgtest-web/webcontrol/sqlite-writer
> new file mode 100755
> index 000..3939bde
> --- /dev/null
>
I should have a read up on AMQP so I can review the queue stuff; in the
meantime, I've left one comment on the handling of failed INSERTs
Diff comments:
> diff --git a/charms/focal/autopkgtest-web/webcontrol/sqlite-writer
> b/charms/focal/autopkgtest-web/webcontrol/sqlite-writer
> new file mode
Review: Needs Fixing
Sorry for the delay!
> also just FYI - not ack'ing a message in the queue listener callback WILL
> cause the queue item to stay in the queue, so it is an option in callback
> functions to leave the message in the queue if you choose not to do something
> with it :)
Yeah,
Public bug reported:
autopkgtest is "clever" about when it resets the testbed betweens tests,
and this is a Bad Thing (tm) when it breaks assumptions about isolation.
Specifically, in lib/adt_testbed.py under Testbed.reset is found the
following code:
def reset(self, deps_new, with_recommends
> On 15-03-2024 3:49 p.m., Dave Jones wrote:
> > autopkgtest is "clever" about when it resets the testbed betweens
> > tests, and this is a Bad Thing (tm) when it breaks assumptions
> > about isolation.
>
> Ironically https://bugs.debian.org/1063533 has
Dave Jones has proposed merging ~waveform/ubuntu-manual-tests:tidy-up into
ubuntu-manual-tests:main.
Requested reviews:
Ubuntu Testcase Admins (ubuntu-testcase)
For more details, see:
https://code.launchpad.net/~waveform/ubuntu-manual-tests/+git/ubuntu-manual-tests/+merge/464929
Fixes for
Dave Jones has proposed merging ~waveform/ubuntu-manual-tests:desktop-alt-boot
into ubuntu-manual-tests:main.
Requested reviews:
Ubuntu Testcase Admins (ubuntu-testcase)
For more details, see:
https://code.launchpad.net/~waveform/ubuntu-manual-tests/+git/ubuntu-manual-tests/+merge/465423
Add
Is there anything left to do on this bug? Any further series to target
for lxc, and/or anything to do with the ubuntu-kernel-tests?
--
You received this bug notification because you are a member of Canonical
Platform QA Team, which is subscribed to ubuntu-kernel-tests.
https://bugs.launchpad.net/
Dave Jones has proposed merging ~waveform/ubuntu-manual-tests:pi5 into
ubuntu-manual-tests:main.
Commit message:
Several commits tidying up redundant Pi test cases and adding Pi 5 cases
Requested reviews:
Ubuntu Testcase Admins (ubuntu-testcase)
For more details, see:
https
Doh! You'd think, of all people, I'd remember to do that given I wrote the
bloody thing! Apparently not...
--
https://code.launchpad.net/~waveform/ubuntu-manual-tests/+git/ubuntu-manual-tests/+merge/452380
Your team Ubuntu Testcase Admins is requested to review the proposed merge of
~waveform/ub
Dave Jones has proposed merging ~waveform/ubuntu-manual-tests:pi-server-changes
into ubuntu-manual-tests:main.
Requested reviews:
Ubuntu Testcase Admins (ubuntu-testcase)
For more details, see:
https://code.launchpad.net/~waveform/ubuntu-manual-tests/+git/ubuntu-manual-tests/+merge/473755
Dave Jones has proposed merging ~waveform/ubuntu-manual-tests:pi-new-models
into ubuntu-manual-tests:main.
Requested reviews:
Ubuntu Testcase Admins (ubuntu-testcase)
For more details, see:
https://code.launchpad.net/~waveform/ubuntu-manual-tests/+git/ubuntu-manual-tests/+merge/480620
Fixed
Dave Jones has proposed merging ~waveform/ubuntu-manual-tests:pi-boot into
ubuntu-manual-tests:main.
Requested reviews:
Ubuntu Testcase Admins (ubuntu-testcase)
For more details, see:
https://code.launchpad.net/~waveform/ubuntu-manual-tests/+git/ubuntu-manual-tests/+merge/490120
Add A/B boot
Dave Jones has proposed merging
~waveform/ubuntu-manual-tests:pi-boot-with-the-right-path-this-time into
ubuntu-manual-tests:main.
Requested reviews:
Ubuntu Testcase Admins (ubuntu-testcase)
For more details, see:
https://code.launchpad.net/~waveform/ubuntu-manual-tests/+git/ubuntu-manual
25 matches
Mail list logo
