Re: Looks like bb2 has stopped?

2021-09-02 Thread Chesnay Schepler
After one (admittedly misguided) attempt to fix it, changes still aren't being picked up. :/ On 02/09/2021 08:30, Chesnay Schepler wrote: I'd wager a guess that this line causes a configuration error: https://github.com/apache/infrastructure-bb2/blob/ff501a60a7d216fe55957618f586225036b76882/to

Re: Looks like bb2 has stopped?

2021-09-02 Thread Gavin McDonald
I'll take a look On Thu, Sep 2, 2021 at 9:12 AM Chesnay Schepler wrote: > After one (admittedly misguided) attempt to fix it, changes still aren't > being picked up. :/ > > On 02/09/2021 08:30, Chesnay Schepler wrote: > > I'd wager a guess that this line causes a configuration error: > > > > > h

Re: Looks like bb2 has stopped?

2021-09-02 Thread Chesnay Schepler
I've opened a PR that might solve the issue: https://github.com/apache/infrastructure-bb2/pull/9 On 02/09/2021 09:56, Gavin McDonald wrote: I'll take a look On Thu, Sep 2, 2021 at 9:12 AM Chesnay Schepler wrote: After one (admittedly misguided) attempt to fix it, changes still aren't being

Re: Looks like bb2 has stopped?

2021-09-02 Thread sebb
I merged the fix. Still no attic build. The original BB did not stop running if someone committed a bad config. Instead it emailed details of the error to the committer and a mailing list. Can that not be implemented for BB2? Sebb On Thu, 2 Sept 2021 at 10:48, Chesnay Schepler wrote: > > I've

buildbot2 is not running

2021-09-02 Thread sebb
As the subject says; it looks like the buildbot service is not bing started successfully

Re: Dependabot-like solution for Apache projects

2021-09-02 Thread Olivier Lamy
Hi, Really? This sounds like a productivity killer to remove such feature... the bot never write to master branch it just creates a branch and pr which need to be validated/merged by a valid committer. FYI eclipse foundation definitely accepts this without problem so I guess we have a similar level

Re: Dependabot-like solution for Apache projects

2021-09-02 Thread David Jencks
After thinking about it for a couple of minutes I’m fully behind Apache policy forbidding automated commits to an Apache repository. If Eclipse allows such commits I’d rather suspect they haven’t noticed them. Assuming that dependabot can’t deal with making it’s branch in a separate repo it mig

Re: buildbot2 is not running

2021-09-02 Thread sebb
Seems to be running again On Thu, 2 Sept 2021 at 12:48, sebb wrote: > > As the subject says; it looks like the buildbot service is not bing > started successfully

Re: Dependabot-like solution for Apache projects

2021-09-02 Thread Olivier Lamy
So what happen here? If I understand correctly dependabot creates a branch in a fork repository with a commit then this commit is merged back to the Apache GitHub repo by a committer. In the previous model dependabot created a branch in the Apache GitHub repo then a committer merged this back to m

Re: Dependabot-like solution for Apache projects

2021-09-02 Thread sebb
On Fri, 3 Sept 2021 at 00:16, Olivier Lamy wrote: > > So what happen here? > If I understand correctly dependabot creates a branch in a fork repository > with a commit then this commit is merged back to the Apache GitHub repo by > a committer. > > In the previous model dependabot created a branch

Re: Dependabot-like solution for Apache projects

2021-09-02 Thread David Jencks
The difference is whether a non-committer has write access to an Apache repo. In this case the non-committer is some code GitHub maintains that we have no control over. Why should we trust it not to modify a real branch? To now argue on the other side of the issue, the git website publishing

Re: Dependabot-like solution for Apache projects

2021-09-02 Thread Olivier Lamy
I perfectly understand this. But my point was at the end the result is the same! If we follow such reasoning, why do we use github as we do not control what is happening there? but yeah I'm having an already lost discussion :) On Fri, 3 Sept 2021 at 09:32, David Jencks wrote: > The difference is

Re: Dependabot-like solution for Apache projects

2021-09-02 Thread David Jencks
I’m afraid I don’t understand your “the result is the same” argument. Let's say a company has 2 employees, Arthur, who is not an Apache committer on project X, and Bernadette who is. Arthur writes some code and submits a PR to project X. In scenario 1, Bernadette merges the PR and in scenario

Re: Dependabot-like solution for Apache projects

2021-09-02 Thread Chris Lambertus
> On Sep 2, 2021, at 4:31 PM, David Jencks wrote: > > The difference is whether a non-committer has write access to an Apache repo. > In this case the non-committer is some code GitHub maintains that we have no > control over. Why should we trust it not to modify a real branch? > > To now

Re: Dependabot-like solution for Apache projects

2021-09-02 Thread Olivier Lamy
On Fri, 3 Sept 2021 at 09:57, David Jencks wrote: > I’m afraid I don’t understand your “the result is the same” argument. > result == Apache committer merging the bot commit > > Let's say a company has 2 employees, Arthur, who is not an Apache > committer on project X, and Bernadette who is.