I merged the fix. Still no attic build.
The original BB did not stop running if someone committed a bad config. Instead it emailed details of the error to the committer and a mailing list. Can that not be implemented for BB2? Sebb On Thu, 2 Sept 2021 at 10:48, Chesnay Schepler <ches...@apache.org> wrote: > > I've opened a PR that might solve the issue: > https://github.com/apache/infrastructure-bb2/pull/9 > > On 02/09/2021 09:56, Gavin McDonald wrote: > > I'll take a look > > > > On Thu, Sep 2, 2021 at 9:12 AM Chesnay Schepler <ches...@apache.org> wrote: > > > >> After one (admittedly misguided) attempt to fix it, changes still aren't > >> being picked up. :/ > >> > >> On 02/09/2021 08:30, Chesnay Schepler wrote: > >>> I'd wager a guess that this line causes a configuration error: > >>> > >>> > >> https://github.com/apache/infrastructure-bb2/blob/ff501a60a7d216fe55957618f586225036b76882/tomcat.py#L220 > >>> > >>> It doesn't look like buildnumber is properly added to the path. It > >>> should use Interpolate I suppose. > >>> > >>> Are configuration errors still sent to us...@infra.apache.org? > >>> > >>> On 02/09/2021 00:51, sebb wrote: > >>>> As the subject says. > >>>> > >>>> I made a change to attic-site.py and then updated attic, but no build > >>>> has occurred. > >>>> Previously the build would happen immediately. > >>>> > >>>> Sebb > >>> > >> >
