Re: Triggering CI rebuilds for GitHub pull requests

2015-07-29 Thread Andrew Bayer
Thanks! On Wed, Jul 29, 2015 at 12:54 PM, Ismael Juma wrote: > On Tue, Jul 28, 2015 at 3:01 PM, Andrew Bayer > wrote: > > > Yes, please. =) > > > > Here it is: > > https://issues.apache.org/jira/browse/BUILDS-102 > > Best, > Ismael >

Re: Triggering CI rebuilds for GitHub pull requests

2015-07-29 Thread Ismael Juma
On Tue, Jul 28, 2015 at 3:01 PM, Andrew Bayer wrote: > Yes, please. =) > Here it is: https://issues.apache.org/jira/browse/BUILDS-102 Best, Ismael

Re: Triggering CI rebuilds for GitHub pull requests

2015-07-28 Thread Andrew Bayer
Yes, please. =) On Jul 28, 2015 15:53, "Ismael Juma" wrote: > On Tue, Jul 28, 2015 at 2:14 PM, Andrew Bayer > wrote: > > > I have not yet - sorry. > > > > Thanks anyway. :) Should I file a JIRA ticket for this feature request? > > Ismael >

Re: Triggering CI rebuilds for GitHub pull requests

2015-07-28 Thread Ismael Juma
On Tue, Jul 28, 2015 at 2:14 PM, Andrew Bayer wrote: > I have not yet - sorry. > Thanks anyway. :) Should I file a JIRA ticket for this feature request? Ismael

Re: Triggering CI rebuilds for GitHub pull requests

2015-07-28 Thread Andrew Bayer
I have not yet - sorry. A. On Tue, Jul 28, 2015 at 3:09 PM, Ismael Juma wrote: > Hi Andrew, > > Did you have a chance to look into this? As the number of people using pull > requests in Kafka increases, it becomes more important to have a solution > for this. Even if the actual solution may not

Re: Triggering CI rebuilds for GitHub pull requests

2015-07-28 Thread Ismael Juma
Hi Andrew, Did you have a chance to look into this? As the number of people using pull requests in Kafka increases, it becomes more important to have a solution for this. Even if the actual solution may not be available immediately, it would still be good to know if there will be one. Thanks for

Re: Triggering CI rebuilds for GitHub pull requests

2015-07-23 Thread Ismael Juma
On Thu, Jul 23, 2015 at 10:20 AM, Andrew Bayer wrote: > I'll find a way. =) > Excellent, thanks. :) Ismael

Re: Triggering CI rebuilds for GitHub pull requests

2015-07-23 Thread Andrew Bayer
I'll find a way. =) On Jul 23, 2015 11:19, "Ismael Juma" wrote: > On Thu, Jul 23, 2015 at 9:36 AM, Andrew Bayer > wrote: > > > At the time I set us up with the plugin, the OSS one required a lot more > > privileges on the Github side than we are able to give it. I'll check to > > see if it's any

Re: Triggering CI rebuilds for GitHub pull requests

2015-07-23 Thread Ismael Juma
On Thu, Jul 23, 2015 at 9:36 AM, Andrew Bayer wrote: > At the time I set us up with the plugin, the OSS one required a lot more > privileges on the Github side than we are able to give it. I'll check to > see if it's any more reasonable now. =) > I see, that makes sense. Spark seems to use the o

Re: Triggering CI rebuilds for GitHub pull requests

2015-07-23 Thread Andrew Bayer
At the time I set us up with the plugin, the OSS one required a lot more privileges on the Github side than we are able to give it. I'll check to see if it's any more reasonable now. =) On Jul 23, 2015 10:18, "Ismael Juma" wrote: > On Wed, Jul 22, 2015 at 5:46 PM, Andrew Bayer > wrote: > > > I t

Re: Triggering CI rebuilds for GitHub pull requests

2015-07-23 Thread Ismael Juma
On Wed, Jul 22, 2015 at 5:46 PM, Andrew Bayer wrote: > I think it only triggers on changes to the pull request - i.e., a new > commit. I'll talk to the cloudbees people (we are using the Jenkins > Enterprise GH PR plugin, not the open source one) and see if they have any > ideas. > Thank you And

Re: Triggering CI rebuilds for GitHub pull requests

2015-07-22 Thread Andrew Bayer
I think it only triggers on changes to the pull request - i.e., a new commit. I'll talk to the cloudbees people (we are using the Jenkins Enterprise GH PR plugin, not the open source one) and see if they have any ideas. On Wednesday, July 22, 2015, Ismael Juma wrote: > Hi, > > Any feedback on th

Re: Triggering CI rebuilds for GitHub pull requests

2015-07-22 Thread Ismael Juma
Hi, Any feedback on the below? "retest this please" did not seem to work when a committer tried it. On Mon, Jul 20, 2015 at 4:15 PM, Ismael Juma wrote: > Hi, > > At Kafka, we intend to change our contribution flow to be based on GitHub > pull requests. An important part of this flow is running

Triggering CI rebuilds for GitHub pull requests

2015-07-20 Thread Ismael Juma
Hi, At Kafka, we intend to change our contribution flow to be based on GitHub pull requests. An important part of this flow is running CI builds on pull requests. The basics are now working[1] thanks to Andrew Bayer's help. I have a few questions that I could not find an answer for (if this is inf