Re: RFR: 8334598: Default classlist in JDK is not deterministic after JDK-8293980

2024-06-24 Thread Calvin Cheung
On Mon, 24 Jun 2024 21:22:48 GMT, Ioi Lam wrote: > More filtering is needed when building the default archive in the JDK: > constant pool resolution when running the > `build.tools.classlist.HelloClasslist` program is not deterministic (due to > concurrency in core library classes). This could

Re: RFR: 8309634: Resolve CONSTANT_MethodRef at CDS dump time

2024-06-25 Thread Calvin Cheung
On Mon, 24 Jun 2024 17:21:18 GMT, Ioi Lam wrote: > Resolve `CONSTANT_MethodRef` entries during CDS dump time to improve start-up > performance. > > - This PR uses the same framework introduced in #19355 and just added > handling for methods. > - Support for getstatic/putstatic/invokestatic wil

Re: RFR: 8309634: Resolve CONSTANT_MethodRef at CDS dump time [v2]

2024-06-27 Thread Calvin Cheung
On Wed, 26 Jun 2024 03:11:41 GMT, Ioi Lam wrote: >> Resolve `CONSTANT_MethodRef` entries during CDS dump time to improve >> start-up performance. >> >> - This PR uses the same framework introduced in #19355 and just added >> handling for methods. >> - Support for getstatic/putstatic/invokestat

RFR: 8283238: make/scripts/compare.sh should show the diff when classlist does not match

2022-11-16 Thread Calvin Cheung
Please review this change for enabling verbose (-vv) when running the compare.sh script so that the diff between files will be available in the build stdout file. This is for troubleshooting the two bugs ([JDK-8283220](https://bugs.openjdk.org/browse/JDK-8283220), [JDK-8295951](https://bugs.ope

Re: RFR: 8283238: make/scripts/compare.sh should show the diff when classlist does not match

2022-11-16 Thread Calvin Cheung
On Wed, 16 Nov 2022 19:21:14 GMT, Magnus Ihse Bursie wrote: > Have you tested that -vv gives you the diff for classlist files? I did tested it but not seeing the diff for classlist files since the bugs in question only happened intermittently. For a normal run, the build stdout file would incl

Re: RFR: 8283238: make/scripts/compare.sh should show the diff when classlist does not match

2022-11-16 Thread Calvin Cheung
On Wed, 16 Nov 2022 18:32:47 GMT, Calvin Cheung wrote: > Please review this change for enabling verbose (-vv) when running the > compare.sh script so that the diff between files will be available in the > build stdout file. This is for troubleshooting the two bugs > ([JDK-82

Integrated: 8283238: make/scripts/compare.sh should show the diff when classlist does not match

2022-11-16 Thread Calvin Cheung
On Wed, 16 Nov 2022 18:32:47 GMT, Calvin Cheung wrote: > Please review this change for enabling verbose (-vv) when running the > compare.sh script so that the diff between files will be available in the > build stdout file. This is for troubleshooting the two bugs > ([JDK-82

Re: RFR: 8296754: AutoCreateSharedArchive in JDK 20 is not compatible with JDK 19 [v5]

2022-11-21 Thread Calvin Cheung
On Thu, 17 Nov 2022 21:46:45 GMT, Matias Saavedra Silva wrote: >> The -XX:+AutoCreateSharedArchive flag was implemented in JDK 19, however, >> this flag doesn't work across JDK 19 and 20. >> >> Expected: JDK 20 should recreate the specified CDS archive >> Actual: JDK 20 cannot recognize the ar

RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives

2024-11-12 Thread Calvin Cheung
With this change, the compact object headers related CDS archives (`classes_coh.jsa` and `classes_nocoops_coh.jsa`) will not be generated by default. If the user needs them, the user can specify the `--enable-cds-archive-coh=yes` build configure option. This change also modified the TestDefaultA

Re: RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives [v3]

2024-11-19 Thread Calvin Cheung
-enable-cds-archive-coh=no`: classes*coh.jsa CDS > archives are not generated > - passed tiers 1 and 3 tests > > Update: > > The classes*coh.jsa archives will be generated by default. In case the user > doesn't want to generate those archives, just specify the > --disab

Re: RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives [v2]

2024-11-19 Thread Calvin Cheung
On Tue, 19 Nov 2024 14:18:59 GMT, Erik Joelsson wrote: > I'm a bit unsure what was actually agreed in the bug discussion. Are wanting > to disable this by default for OpenJDK, requiring anyone who wants it enabled > to add a new configure option, or are we only intending to change the > config

Integrated: 8341553: Remove UseCompactObjectHeaders extra CDS archives

2024-11-19 Thread Calvin Cheung
On Tue, 12 Nov 2024 23:27:27 GMT, Calvin Cheung wrote: > With this change, the compact object headers related CDS archives > (`classes_coh.jsa` and `classes_nocoops_coh.jsa`) will not be generated by > default. If the user needs them, the user can specify the > `--enable-cds-arc

Re: RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives [v2]

2024-11-19 Thread Calvin Cheung
On Thu, 14 Nov 2024 05:18:05 GMT, Ioi Lam wrote: >> Calvin Cheung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @iklam comment > > Test changes look good. Thanks @iklam, @coleenp, @erikj79 for the revi

Re: RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives [v2]

2024-11-13 Thread Calvin Cheung
-enable-cds-archive-coh=no`: classes*coh.jsa CDS > archives are not generated > - passed tiers 1 and 3 tests Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision: @iklam comment - Changes: - all: https://git.openj

Re: RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives [v2]

2024-11-13 Thread Calvin Cheung
On Wed, 13 Nov 2024 19:43:54 GMT, Ioi Lam wrote: > I think it's best to avoid modifying the test JVM. It could be used in > parallel by another jtreg process, and it could also be in a read-only > directory. > > I would suggest checking for the existence of the COH files, and skip the > test

Re: RFR: 8348028: Unable to run gtests with CDS enabled [v4]

2025-02-27 Thread Calvin Cheung
ing: > > - run gtest with -Xshare:on on linux-x64 > - tier1 Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision: @magius and @iklam comments - Changes: - all: https://git.openjdk.org/jdk/pull/23758/files - new: htt

Re: RFR: 8348028: Unable to run gtests with CDS enabled [v3]

2025-02-27 Thread Calvin Cheung
On Thu, 27 Feb 2025 15:58:55 GMT, Ioi Lam wrote: >> This is completely wrong. >> >> The JVM_CFLAGS_FEATURES should be used to add feature-specific flags, not >> like this. If we really did want to add this to the CFLAGS for all Hotspot >> files, the correct thing to do would be to add it to JV

Integrated: 8348028: Unable to run gtests with CDS enabled

2025-02-28 Thread Calvin Cheung
On Tue, 25 Feb 2025 00:51:55 GMT, Calvin Cheung wrote: > A simple fix in `os::jvm_path()` so that gtest can be run with CDS > (`-Xshare:on`). The fix is just to change the directory name from `hotspot` > to `server`. > Note that the bug doesn't exist on macOS and thus no chang

Re: RFR: 8348028: Unable to run gtests with CDS enabled

2025-02-28 Thread Calvin Cheung
On Thu, 27 Feb 2025 12:42:35 GMT, David Holmes wrote: >>> Also, >>> >>> > That presumes you are dealing with a single variant JDK, not one that has >>> > both client and server. >>> >>> Is this even relevant anymore? Afaik, the last platform to have both client >>> and server where 32-bit Win

Re: RFR: 8349953: Avoid editing AOTConfiguration file in "make test JTREG=AOT_JDK=true" [v7]

2025-02-19 Thread Calvin Cheung
On Wed, 19 Feb 2025 19:20:13 GMT, Ioi Lam wrote: >> When running HotSpot jtreg tests in the "AOT mode", for example: >> >> >> make test JTREG=AOT_JDK=true TEST=open/test/hotspot/jtreg/runtime/stringtable >> >> >> Before this PR, in the test set up phase, we record several AOT >> configuratio

Integrated: 8356229: cmp-baseline build fail due to lib/modules difference

2025-05-09 Thread Calvin Cheung
On Fri, 9 May 2025 17:22:41 GMT, Calvin Cheung wrote: > The fix for [JDK-8327495](https://bugs.openjdk.org/browse/JDK-8327495) logs > more CDS error by default. The error gets printed into the > `support/link_opt/default_jli_trace.txt` file which interferes with the > cmp-baselin

Re: RFR: 8356229: cmp-baseline build fail due to lib/modules difference

2025-05-09 Thread Calvin Cheung
On Fri, 9 May 2025 17:37:04 GMT, Ioi Lam wrote: >> The fix for [JDK-8327495](https://bugs.openjdk.org/browse/JDK-8327495) logs >> more CDS error by default. The error gets printed into the >> `support/link_opt/default_jli_trace.txt` file which interferes with the >> cmp-baseline build. >> A fi

RFR: 8356229: cmp-baseline build fail due to lib/modules difference

2025-05-09 Thread Calvin Cheung
The fix for [JDK-8327495](https://bugs.openjdk.org/browse/JDK-8327495) logs more CDS error by default. The error gets printed into the `support/link_opt/default_jli_trace.txt` file which interferes with the cmp-baseline build. A fix is to specify the `-Xlog:cds=off` to suppress the error message