Re: RFR: 8355746: Start of release updates for JDK 26 [v4]

2025-05-28 Thread Nizar Benalla
On Thu, 8 May 2025 13:15:35 GMT, Nizar Benalla wrote: >> It is to accommodate the now longer list of --release values in the javac >> help output,the addition of ", 26". >> >> Splitting the list of releases over two lines would be a better solution, >> but I didn't take that one when initially

Re: RFR: 8357920: Add .rej and .orig to .gitignore

2025-05-28 Thread Magnus Ihse Bursie
On Wed, 28 May 2025 02:00:41 GMT, SendaoYan wrote: >> The file types .rej and .orig are often created by diff tools. Adding them >> to .gitignore will help people from mistakenly committing these files. >> >> See https://github.com/openjdk/jdk/pull/25306#discussion_r2102407122 for an >> exampl

Re: RFR: 8357920: Add .rej and .orig to .gitignore

2025-05-28 Thread Magnus Ihse Bursie
On Wed, 28 May 2025 09:19:27 GMT, Magnus Ihse Bursie wrote: >> .gitignore line 26: >> >>> 24: /.lldbinit >>> 25: **/core.[0-9]* >>> 26: *.rej >> >> How about use below config instead. It will ignore all the related diff >> files in root directory and in the any sub-directory. >> >> >> **/*.r

Re: RFR: 8357869: Remove PreviewNote taglet in its current form

2025-05-28 Thread Hannes Wallnöfer
On Tue, 27 May 2025 22:38:58 GMT, Magnus Ihse Bursie wrote: > Can you really keep the changes to TestPreview.java from JDK-8346109? Yes, the test does not rely on the JDK build taglet, it uses the javadoc `-tag` option to register a generic tag. More importantly, the internal JavaDoc changes i

Integrated: 8357869: Remove PreviewNote taglet in its current form

2025-05-28 Thread Hannes Wallnöfer
On Tue, 27 May 2025 14:38:53 GMT, Hannes Wallnöfer wrote: > Please review a change to remove the `PreviewNote` build taglet as it did not > pass CSR. This is a partial (build changes) undo of > [JDK-8346109](https://bugs.openjdk.org/browse/JDK-8346109). > > The taglet is planned to be reintr

Re: RFR: 8355746: Start of release updates for JDK 26 [v4]

2025-05-28 Thread Christian Stein
On Wed, 28 May 2025 11:14:22 GMT, Nizar Benalla wrote: >> I'll split the releases over two lines in the next update. The line is a >> little too long. > > Thinking about this again, could we represent the supported versions more > concisely? like `8-26` or `from 8 to 26`. Another variant:

Re: RFR: 8355725: SPEC_FILTER stopped working

2025-05-28 Thread Erik Joelsson
On Wed, 28 May 2025 14:40:19 GMT, Magnus Ihse Bursie wrote: > The problem with `?=` is that makes a macro (lazy evaluation), not an > assignment (early evaluation). I try to avoid it for that reason and instead > rely on assignment in conditionals. That's a good point, I will try to remember t

RFR: 8357979: [JVMCI] jdk.internal.vm.ci should have earlier class file version

2025-05-28 Thread Doug Simon
There are plans to have libgraal be built for JDK master using a version of Native Image running on a JDK one version behind JDK master. This Native Image execution needs to be able to load the JVMCI classes. As such, the JVMCI classes must have a class file major version of N-1 where N is the m

Re: RFR: 8355725: SPEC_FILTER stopped working

2025-05-28 Thread Magnus Ihse Bursie
On Wed, 28 May 2025 00:06:36 GMT, Magnus Ihse Bursie wrote: > From the bug description: > > The SPEC_FILTER make variable is meant to be used to create small > documentation bundles that just contain some selected files. Example usage: > > `make docs-specs-zip SPEC_FILTER="%-jls.md copyright.h

Integrated: 8355725: SPEC_FILTER stopped working

2025-05-28 Thread Magnus Ihse Bursie
On Wed, 28 May 2025 00:06:36 GMT, Magnus Ihse Bursie wrote: > From the bug description: > > The SPEC_FILTER make variable is meant to be used to create small > documentation bundles that just contain some selected files. Example usage: > > `make docs-specs-zip SPEC_FILTER="%-jls.md copyright.h

Integrated: 8357510: [REDO] RunTest variables should always be assigned

2025-05-28 Thread Magnus Ihse Bursie
On Tue, 27 May 2025 23:57:03 GMT, Magnus Ihse Bursie wrote: > This is a redo of [JDK-8357048](https://bugs.openjdk.org/browse/JDK-8357048), > which had to backed out since it caused testing errors in higher tiers. > > The problem was that `JTREG_PROBLEM_LIST_PREFIX` was not defined before it >

Re: Questions about the Hermetic Java project

2025-05-28 Thread David Holmes
Hi Jiangli, On 29/05/2025 3:27 am, Jiangli Zhou wrote: This is unfortunately quite complex, and I have started a discussion with Alan if it is possible to update the JNI spec so that both static and dynamic entry points can have the form "JNI_OnLoad_". Ideally, I'd like to see us push for th

Re: RFR: 8355798: Implement JEP 514: Ahead-of-Time Command Line Ergonomics [v13]

2025-05-28 Thread Ioi Lam
> This is the implementation of the draft [JEP: Ahead-of-time Command Line > Ergonomics](https://bugs.openjdk.org/browse/JDK-8350022) > > - Implemented new flag `AOTCacheOutput`, which can be used to create an AOT > cache using the "one-command workflow" > - Added processing of the `JDK_AOT_VM_O

Re: RFR: 8357920: Add .rej and .orig to .gitignore

2025-05-28 Thread SendaoYan
On Tue, 27 May 2025 21:59:05 GMT, Magnus Ihse Bursie wrote: > The file types .rej and .orig are often created by diff tools. Adding them to > .gitignore will help people from mistakenly committing these files. > > See https://github.com/openjdk/jdk/pull/25306#discussion_r2102407122 for an > ex

Re: RFR: 8355003: Implement JEP 515: Ahead-of-Time Method Profiling [v25]

2025-05-28 Thread Vladimir Kozlov
On Tue, 27 May 2025 21:57:11 GMT, Igor Veresov wrote: >> Improve warm-up time by making profile data from a previous run of an >> application instantly available, when the HotSpot Java Virtual Machine >> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) >> to store me

Integrated: 8355003: Implement JEP 515: Ahead-of-Time Method Profiling

2025-05-28 Thread Igor Veresov
On Fri, 25 Apr 2025 20:18:41 GMT, Igor Veresov wrote: > Improve warm-up time by making profile data from a previous run of an > application instantly available, when the HotSpot Java Virtual Machine > starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) > to store method

Re: RFR: 8355725: SPEC_FILTER stopped working

2025-05-28 Thread Erik Joelsson
On Wed, 28 May 2025 00:06:36 GMT, Magnus Ihse Bursie wrote: > From the bug description: > > The SPEC_FILTER make variable is meant to be used to create small > documentation bundles that just contain some selected files. Example usage: > > `make docs-specs-zip SPEC_FILTER="%-jls.md copyright.h

Re: RFR: 8357510: [REDO] RunTest variables should always be assigned

2025-05-28 Thread Erik Joelsson
On Tue, 27 May 2025 23:57:03 GMT, Magnus Ihse Bursie wrote: > This is a redo of [JDK-8357048](https://bugs.openjdk.org/browse/JDK-8357048), > which had to backed out since it caused testing errors in higher tiers. > > The problem was that `JTREG_PROBLEM_LIST_PREFIX` was not defined before it >

Re: RFR: 8357920: Add .rej and .orig to .gitignore

2025-05-28 Thread Erik Joelsson
On Tue, 27 May 2025 21:59:05 GMT, Magnus Ihse Bursie wrote: > The file types .rej and .orig are often created by diff tools. Adding them to > .gitignore will help people from mistakenly committing these files. > > See https://github.com/openjdk/jdk/pull/25306#discussion_r2102407122 for an > ex

Integrated: 8357920: Add .rej and .orig to .gitignore

2025-05-28 Thread Magnus Ihse Bursie
On Tue, 27 May 2025 21:59:05 GMT, Magnus Ihse Bursie wrote: > The file types .rej and .orig are often created by diff tools. Adding them to > .gitignore will help people from mistakenly committing these files. > > See https://github.com/openjdk/jdk/pull/25306#discussion_r2102407122 for an > ex

Re: Questions about the Hermetic Java project

2025-05-28 Thread Jiangli Zhou
On Mon, Apr 15, 2024 at 6:01 PM Jiangli Zhou wrote: > > Magnus, thanks for the response. Please see comments inlined below. > > On Fri, Apr 12, 2024 at 4:52 AM Magnus Ihse Bursie > wrote: > > > > On 2024-04-02 21:16, Jiangli Zhou wrote: > > > > Hi Magnus, > > > > In today's zoom meeting with Alan

Integrated: 8355798: Implement JEP 514: Ahead-of-Time Command Line Ergonomics

2025-05-28 Thread Ioi Lam
On Tue, 29 Apr 2025 04:50:42 GMT, Ioi Lam wrote: > This is the implementation of the draft [JEP: Ahead-of-time Command Line > Ergonomics](https://bugs.openjdk.org/browse/JDK-8350022) > > - Implemented new flag `AOTCacheOutput`, which can be used to create an AOT > cache using the "one-command