RE: clang Memory sanitizer (msan) and OpenJDK

2025-04-30 Thread Baesken, Matthias
I installed the llvm package to get the /usr/bin/llvm-symbolizer (this seems to be needed to get meaningful stacks) . Brought back the visibility=hidden settings, seems they do no harm to msan . However the removal of -Wl,--exclude-libs,ALL is needed. With the llvm-symbolizer add

RFR: 8355971: Build warnings after the changes for JDK-8354996

2025-04-30 Thread Chen Liang
There were a few warnings related to illegal native access in HelloClasslist after adding some of the downcall infrastructure. Did a clean build and there were no warning associated with the Compiling up to 2 files for CLASSLIST_JAR Creating support/classlist.jar steps. - Commit

Integrated: 8355971: Build warnings after the changes for JDK-8354996

2025-04-30 Thread Chen Liang
On Wed, 30 Apr 2025 17:32:34 GMT, Chen Liang wrote: > There were a few warnings related to illegal native access in HelloClasslist > after adding some of the downcall infrastructure. Did a clean build and there > were no warning associated with the > > Compiling up to 2 files for CLASSLIST_JA

Re: RFR: 8355971: Build warnings after the changes for JDK-8354996

2025-04-30 Thread Chen Liang
On Wed, 30 Apr 2025 17:32:34 GMT, Chen Liang wrote: > There were a few warnings related to illegal native access in HelloClasslist > after adding some of the downcall infrastructure. Did a clean build and there > were no warning associated with the > > Compiling up to 2 files for CLASSLIST_JA

Re: RFR: 8355971: Build warnings after the changes for JDK-8354996

2025-04-30 Thread Erik Joelsson
On Wed, 30 Apr 2025 17:32:34 GMT, Chen Liang wrote: > There were a few warnings related to illegal native access in HelloClasslist > after adding some of the downcall infrastructure. Did a clean build and there > were no warning associated with the > > Compiling up to 2 files for CLASSLIST_JA

Re: RFR: 8355971: Build warnings after the changes for JDK-8354996

2025-04-30 Thread Aleksey Shipilev
On Wed, 30 Apr 2025 17:32:34 GMT, Chen Liang wrote: > There were a few warnings related to illegal native access in HelloClasslist > after adding some of the downcall infrastructure. Did a clean build and there > were no warning associated with the > > Compiling up to 2 files for CLASSLIST_JA

Re: RFR: 8354257: xctracenorm profiler not working with JDK JMH benchmarks

2025-04-30 Thread Galder Zamarreño
On Wed, 30 Apr 2025 08:38:51 GMT, Galder Zamarreño wrote: > > I do think it's a bug that JMH is bundling its checkstyle and findbugs > > configurations in its distribution jar, so perhaps we can suggest to a JMH > > maintainer to stop doing that. :) > > I think that makes sense to me and I can

Re: RFR: 8354257: xctracenorm profiler not working with JDK JMH benchmarks

2025-04-30 Thread Galder Zamarreño
On Mon, 28 Apr 2025 23:10:27 GMT, Erik Joelsson wrote: > I do think it's a bug that JMH is bundling its checkstyle and findbugs > configurations in its distribution jar, so perhaps we can suggest to a JMH > maintainer to stop doing that. :) I think that makes sense to me and I can try to do th

Re: RFR: 8350209: Preserve adapters in AOT cache [v14]

2025-04-30 Thread Vladimir Kozlov
On Thu, 1 May 2025 02:51:53 GMT, Vladimir Ivanov wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> renaming and new assert > > Marked as reviewed by vlivanov (Reviewer). Thank you, @iwanowww. I need 2 re-reviews

Re: RFR: 8350209: Preserve adapters in AOT cache [v12]

2025-04-30 Thread Vladimir Kozlov
On Wed, 30 Apr 2025 22:22:18 GMT, Vladimir Ivanov wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> address Ioi's comments > > src/hotspot/share/code/relocInfo.hpp line 1292: > >> 1290: void pack_data_to(CodeSe

Re: RFR: 8355003: Implement Ahead-of-Time Method Profiling [v8]

2025-04-30 Thread Vladimir Kozlov
On Wed, 30 Apr 2025 22:58:09 GMT, Igor Veresov wrote: >> Improve warm-up time by making profile data from a previous run of an >> application instantly available, when the HotSpot Java Virtual Machine >> starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) >> to store me

Re: RFR: 8350209: Preserve adapters in AOT cache [v12]

2025-04-30 Thread Vladimir Kozlov
On Wed, 30 Apr 2025 22:09:24 GMT, Vladimir Ivanov wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> address Ioi's comments > > src/hotspot/share/runtime/sharedRuntime.cpp line 2780: > >> 2778: >> 2779: #ifndef P

Re: RFR: 8350209: Preserve adapters in AOT cache [v12]

2025-04-30 Thread Vladimir Kozlov
On Wed, 30 Apr 2025 22:54:38 GMT, Vladimir Ivanov wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> address Ioi's comments > > src/hotspot/share/code/aotCodeCache.cpp line 69: > >> 67: vm_abort(false); >> 68:

Re: RFR: 8350209: Preserve adapters in AOT cache [v12]

2025-04-30 Thread Vladimir Kozlov
On Wed, 30 Apr 2025 22:59:03 GMT, Vladimir Ivanov wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> address Ioi's comments > > src/hotspot/share/runtime/sharedRuntime.cpp line 2852: > >> 2850: entry_offset[2]

Re: RFR: 8350209: Preserve adapters in AOT cache [v12]

2025-04-30 Thread Vladimir Ivanov
On Thu, 1 May 2025 00:24:07 GMT, Vladimir Kozlov wrote: >> src/hotspot/share/runtime/sharedRuntime.cpp line 2852: >> >>> 2850: entry_offset[2] = handler->get_c2i_unverified_entry() - i2c_entry; >>> 2851: entry_offset[3] = handler->get_c2i_no_clinit_check_entry() - >>> i2c_entry; >>> 285

Re: RFR: 8350209: Preserve adapters in AOT cache [v13]

2025-04-30 Thread Vladimir Kozlov
> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class > information in AOT cache which helps Java startup performance. > > We should also preserve adapters (i2c, c2i) to further improve performance of > class linking where adapters are generated. > > Short running Java applic

Re: RFR: 8350209: Preserve adapters in AOT cache [v13]

2025-04-30 Thread Vladimir Ivanov
On Thu, 1 May 2025 01:08:40 GMT, Vladimir Kozlov wrote: >> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class >> information in AOT cache which helps Java startup performance. >> >> We should also preserve adapters (i2c, c2i) to further improve performance >> of class linki

Re: RFR: 8350209: Preserve adapters in AOT cache [v13]

2025-04-30 Thread Vladimir Kozlov
On Thu, 1 May 2025 01:53:20 GMT, Vladimir Ivanov wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address Vladimir's comments > > src/hotspot/share/code/aotCodeCache.cpp line 56: > >> 54: #include >> 55: >> 56

Re: RFR: 8350209: Preserve adapters in AOT cache [v14]

2025-04-30 Thread Vladimir Kozlov
> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class > information in AOT cache which helps Java startup performance. > > We should also preserve adapters (i2c, c2i) to further improve performance of > class linking where adapters are generated. > > Short running Java applic

Re: RFR: 8350209: Preserve adapters in AOT cache [v14]

2025-04-30 Thread Vladimir Ivanov
On Thu, 1 May 2025 02:47:39 GMT, Vladimir Kozlov wrote: >> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class >> information in AOT cache which helps Java startup performance. >> >> We should also preserve adapters (i2c, c2i) to further improve performance >> of class linki

Re: RFR: 8355003: Implement Ahead-of-Time Method Profiling [v6]

2025-04-30 Thread Igor Veresov
> Improve warm-up time by making profile data from a previous run of an > application instantly available, when the HotSpot Java Virtual Machine > starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) > to store method execution profiles from training runs, reducing profili

Re: RFR: 8350209: Preserve adapters in AOT cache [v12]

2025-04-30 Thread Vladimir Ivanov
On Wed, 30 Apr 2025 02:05:41 GMT, Vladimir Kozlov wrote: >> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class >> information in AOT cache which helps Java startup performance. >> >> We should also preserve adapters (i2c, c2i) to further improve performance >> of class link

Re: RFR: 8355003: Implement Ahead-of-Time Method Profiling [v6]

2025-04-30 Thread Igor Veresov
On Sat, 26 Apr 2025 22:36:11 GMT, Vladimir Kozlov wrote: >> Igor Veresov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove the proxy class counter > > src/hotspot/share/cds/archiveBuilder.cpp line 770: > >> 768: relocate_embedded

Re: RFR: 8355003: Implement Ahead-of-Time Method Profiling [v7]

2025-04-30 Thread Igor Veresov
> Improve warm-up time by making profile data from a previous run of an > application instantly available, when the HotSpot Java Virtual Machine > starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) > to store method execution profiles from training runs, reducing profili

Re: RFR: 8350209: Preserve adapters in AOT cache [v7]

2025-04-30 Thread Vladimir Ivanov
On Wed, 30 Apr 2025 22:55:38 GMT, Vladimir Ivanov wrote: >> I added `log_info()` to `exit_vm_on_*_failure()` methods to produce >> notification when AbortVMOnAOTCodeFailure flag is off (default value). > > The naming (`exit_vm_on_load_failure` and `exit_vm_on_store_failure`) still > look confu

Re: RFR: 8355003: Implement Ahead-of-Time Method Profiling [v8]

2025-04-30 Thread Igor Veresov
> Improve warm-up time by making profile data from a previous run of an > application instantly available, when the HotSpot Java Virtual Machine > starts. Specifically, enhance the [AOT cache](https://openjdk.org/jeps/483) > to store method execution profiles from training runs, reducing profili

Re: RFR: 8355003: Implement Ahead-of-Time Method Profiling [v4]

2025-04-30 Thread Igor Veresov
On Mon, 28 Apr 2025 17:35:13 GMT, Vladimir Kozlov wrote: >> Igor Veresov has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 32 commits: >> >> - Merge branch 'master' into pp2 >> - Fix class filtering >> - Remove the workaround of

Re: RFR: 8350209: Preserve adapters in AOT cache [v7]

2025-04-30 Thread Vladimir Ivanov
On Fri, 25 Apr 2025 00:52:04 GMT, Vladimir Kozlov wrote: >> AOT adapters code caching and loading is guarded by these methods not by >> flag. >> >> Setting AOTAdapterCaching to false on failure is simple indication that >> adapter caching is switched off for someone who will look on final stat

Re: RFR: 8350209: Preserve adapters in AOT cache [v12]

2025-04-30 Thread Vladimir Kozlov
On Wed, 30 Apr 2025 22:54:07 GMT, Vladimir Ivanov wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> address Ioi's comments > > src/hotspot/share/code/aotCodeCache.cpp line 60: > >> 58: vm_exit_during_initiali

Re: RFR: 8350209: Preserve adapters in AOT cache [v12]

2025-04-30 Thread Vladimir Kozlov
On Wed, 30 Apr 2025 02:05:41 GMT, Vladimir Kozlov wrote: >> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class >> information in AOT cache which helps Java startup performance. >> >> We should also preserve adapters (i2c, c2i) to further improve performance >> of class link

Re: RFR: 8350209: Preserve adapters in AOT cache [v7]

2025-04-30 Thread Vladimir Kozlov
On Thu, 24 Apr 2025 01:53:55 GMT, Vladimir Ivanov wrote: >> Vladimir Kozlov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix message > > Finished the first pass over the code. > > > Overall, looks good. Some feedback follows. Thank