On Wed, 30 Apr 2025 22:54:07 GMT, Vladimir Ivanov <vliva...@openjdk.org> wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address Ioi's comments
>
> src/hotspot/share/code/aotCodeCache.cpp line 60:
>
>> 58: vm_exit_during_initialization("Unable to use AOT Code Cache.",
>> nullptr);
>> 59: }
>> 60: log_info(aot, codecache, init)("Unable to use AOT Code Cache.");
>
> Should it be a warning instead?
changed
> src/hotspot/share/code/codeBlob.hpp line 208:
>
>> 206: CodeBlob* as_codeblob() const { return (CodeBlob*)
>> this; }
>> 207: AdapterBlob* as_adapter_blob() const {
>> assert(is_adapter_blob(), "must be adapter blob"); return (AdapterBlob*)
>> this; }
>> 208: ExceptionBlob* as_exception_blob() const {
>> assert(is_exception_stub(), "must be exception stub"); return
>> (ExceptionBlob*) this; }
>
> `ExceptionBlob` is C2-specific, but `as_exception_blob()` is unused.
removed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24740#discussion_r2069680668
PR Review Comment: https://git.openjdk.org/jdk/pull/24740#discussion_r2069680012
