Re: RFR: 8351842: Test issues on Windows with combination of --enable-linkable-runtime and --with-external-symbols-in-bundles=public [v2]

2025-03-17 Thread Christoph Langer
On Thu, 13 Mar 2025 07:39:20 GMT, Christoph Langer wrote: >> This PR addresses an issue that can be observed when building on Windows >> with configure options `--enable-linkable-runtime` and >> `--with-external-symbols-in-bundles=public`. >> >> The problem is that with this special build conf

Re: RFR: 8351842: Windows specific issues in combination of JEP 493 and --with-external-symbols-in-bundles=public

2025-03-17 Thread Christoph Langer
On Fri, 14 Mar 2025 14:10:30 GMT, Severin Gehwolf wrote: >> Alternative approach to #24012 >> >> This keeps the current handling of *.pdb vs *.stripped.pdb which allows >> debugging at the cost of a little hack in jlink. Maybe the code in jlink can >> be improved, e.g. make it more conditional

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher

2025-03-17 Thread Joachim Kern
On Mon, 17 Mar 2025 10:02:12 GMT, Joachim Kern wrote: >> make/StaticLibs.gmk line 116: >> >>> 114: #DEPS := $(STATIC_LIB_FILE), \ >>> 115: #OUTPUT_FILE := $(STATIC_LIB_EXPORT_FILES), \ >>> 116: #COMMAND := $(AR) $(ARFLAGS) -w $(patsubst %.exp, %, $@) | $(GREP) >>> -v '^\.' | $(AWK)

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher

2025-03-17 Thread Joachim Kern
On Mon, 17 Mar 2025 13:14:44 GMT, Erik Joelsson wrote: >> The problem seems to be that `$(generate_export_list)` is empty and I do not >> know why. > > Looks like this variable is misspelled (missing "S"). > > DEPS := $(STATIC_LIB_FILE), \ > > Also note that by default log level INFO is not pr

Integrated: JDK-8348598 : Update Libpng to 1.6.47

2025-03-17 Thread Harshitha Onkar
On Thu, 13 Mar 2025 00:27:46 GMT, Harshitha Onkar wrote: > Upgraded Libpng to v1.6.47 This pull request has now been integrated. Changeset: 6b82b42a Author:Harshitha Onkar URL: https://git.openjdk.org/jdk/commit/6b82b42a2116900b2125e03c1ffa0824d6062757 Stats: 4890 lines in 20 fi

Re: RFR: JDK-8348598 : Update Libpng to 1.6.47 [v3]

2025-03-17 Thread Harshitha Onkar
On Thu, 13 Mar 2025 19:52:12 GMT, Phil Race wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> header update > > I was surprised by how many changes there are. @prrace > I was surprised by how many changes there

Integrated: 8352084: Add more test code in TestSetupAOT.java

2025-03-17 Thread Ioi Lam
On Fri, 14 Mar 2025 20:13:57 GMT, Ioi Lam wrote: > I modified TestSetupAOT.java to exercise more functionalities in the JDK so > that we can have a more substantial AOT cache when running tests with > `AOT_JDK=true`. E.g: > > > make test JTREG=AOT_JDK=true \ > TEST=open/test/jdk/java/util

Re: RFR: 8352044: Add --with-import-jvms to configure

2025-03-17 Thread Alan Bateman
On Fri, 14 Mar 2025 15:49:44 GMT, Magnus Ihse Bursie wrote: > We should allow pre-built JVMs to be included in a build, so they are just > copied into place, and the jvm.cfg file properly updated. The discussion on jdk-dev was useful but I don't think adding --with-import-jvms is the right dir

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-17 Thread snake66
On Mon, 17 Mar 2025 06:41:31 GMT, David Holmes wrote: >> @magicus why can't we just use `-pthread` everywhere? My recollection is >> that `-pthread` both sets compiler directives needed for pthread programming >> and links to libpthread, so it seems to be what we should be using. ?? > >> Anothe

Withdrawn: 8351842: Test issues on Windows with combination of --enable-linkable-runtime and --with-external-symbols-in-bundles=public

2025-03-17 Thread Christoph Langer
On Wed, 12 Mar 2025 15:57:40 GMT, Christoph Langer wrote: > This PR addresses an issue that can be observed when building on Windows with > configure options `--enable-linkable-runtime` and > `--with-external-symbols-in-bundles=public`. > > The problem is that with this special build configura

Re: RFR: 8351842: Windows specific issues in combination of JEP 493 and --with-external-symbols-in-bundles=public

2025-03-17 Thread Christoph Langer
On Fri, 14 Mar 2025 12:29:22 GMT, Christoph Langer wrote: > Alternative approach to #24012 > > This keeps the current handling of *.pdb vs *.stripped.pdb which allows > debugging at the cost of a little hack in jlink. Maybe the code in jlink can > be improved, e.g. make it more conditional. >

Re: RFR: 8352044: Add --with-import-jvms to configure

2025-03-17 Thread Aleksey Shipilev
On Fri, 14 Mar 2025 15:49:44 GMT, Magnus Ihse Bursie wrote: > We should allow pre-built JVMs to be included in a build, so they are just > copied into place, and the jvm.cfg file properly updated. For completeness/reference, this is my JDK frankensteining script that is used for producing buil

Re: RFR: 8352084: Add more test code in TestSetupAOT.java [v3]

2025-03-17 Thread Erik Joelsson
On Sat, 15 Mar 2025 20:36:09 GMT, Ioi Lam wrote: >> I modified TestSetupAOT.java to exercise more functionalities in the JDK so >> that we can have a more substantial AOT cache when running tests with >> `AOT_JDK=true`. E.g: >> >> >> make test JTREG=AOT_JDK=true \ >> TEST=open/test/jdk/ja

Re: RFR: 8352015: LIBVERIFY_OPTIMIZATION remove special optimization settings

2025-03-17 Thread Erik Joelsson
On Fri, 14 Mar 2025 11:15:26 GMT, Matthias Baesken wrote: > On Linux there are some special settings for LIBVERIFY_OPTIMIZATION that are > most likely not needed any more and could be removed. > The removal (on Linux) brings the lib optimization level de facto from LOW to > HIGH. Marked as rev

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher

2025-03-17 Thread Joachim Kern
On Fri, 14 Mar 2025 17:35:02 GMT, Erik Joelsson wrote: >> After "JDK-8339480: Build static-jdk image with a statically linked >> launcher" AIX was not able to build the new target. Therefore with >> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was >> disabled again. >>

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher

2025-03-17 Thread Erik Joelsson
On Mon, 17 Mar 2025 13:11:14 GMT, Joachim Kern wrote: >> Thanks Eric, this might help with the command, but my problem is the >> dependency. The rules to generate the export files is not called, because in >> the build output I cannot find any line 'Generating export list for static >> libs'.

Re: RFR: 8351842: Windows specific issues in combination of JEP 493 and --with-external-symbols-in-bundles=public

2025-03-17 Thread Severin Gehwolf
On Mon, 17 Mar 2025 08:27:20 GMT, Christoph Langer wrote: > Can we maybe add a possibility to store two alternative SHA sums in the JMod > archives, per file? Then we could add SHA sums for both, the stripped and the > full pdb file and either one which is present in the current runtime would b

Re: RFR: 8352084: Add more test code in TestSetupAOT.java [v4]

2025-03-17 Thread Ioi Lam
> I modified TestSetupAOT.java to exercise more functionalities in the JDK so > that we can have a more substantial AOT cache when running tests with > `AOT_JDK=true`. E.g: > > > make test JTREG=AOT_JDK=true \ > TEST=open/test/jdk/java/util/TimeZone/ListTimeZones.java > > > Before: the ge

Re: RFR: 8352084: Add more test code in TestSetupAOT.java [v4]

2025-03-17 Thread Erik Joelsson
On Mon, 17 Mar 2025 16:35:12 GMT, Ioi Lam wrote: >> I modified TestSetupAOT.java to exercise more functionalities in the JDK so >> that we can have a more substantial AOT cache when running tests with >> `AOT_JDK=true`. E.g: >> >> >> make test JTREG=AOT_JDK=true \ >> TEST=open/test/jdk/ja

Re: RFR: 8352084: Add more test code in TestSetupAOT.java [v3]

2025-03-17 Thread Leonid Mesnik
On Sat, 15 Mar 2025 20:36:09 GMT, Ioi Lam wrote: >> I modified TestSetupAOT.java to exercise more functionalities in the JDK so >> that we can have a more substantial AOT cache when running tests with >> `AOT_JDK=true`. E.g: >> >> >> make test JTREG=AOT_JDK=true \ >> TEST=open/test/jdk/ja