Re: RFR: 8351309: test/hotspot/jtreg/runtime/posixSig/TestPosixSig.java fails on static-jdk

2025-03-05 Thread Man Cao
On Wed, 5 Mar 2025 22:59:06 GMT, Jiangli Zhou wrote: > Please review this PR that excludes `libjsig` from being statically linked > with `static-jdk` `java` launcher by default. Please see details in > https://bugs.openjdk.org/browse/JDK-8351309 description and comments. Thanks This LGTM. Perh

Re: RFR: 8350952: Remove some non present files from OPT_SPEED_SRC list

2025-03-05 Thread David Holmes
On Wed, 5 Mar 2025 08:41:06 GMT, Matthias Baesken wrote: > I wonder how useful this OPT_SPEED_SRC list is these days I suspect not useful at all. Too much has changed. This kind of list should be examined each time we update a toolchain. And in principle any new file should be evaluated to se

Re: RFR: 8345169: Implement JEP 503: Remove the 32-bit x86 Port

2025-03-05 Thread Vladimir Kozlov
On Tue, 4 Mar 2025 16:52:16 GMT, Aleksey Shipilev wrote: > This PR implements JEP 503: Remove the 32-bit x86 Port. > > The JEP is proposed to target 25, we would not integrate until JEP is ready. > Reviews are appreciated meanwhile. > > This is only the removal of obvious 32-bit x86 parts, mos

Withdrawn: 8351241: Require minimum gcc version 12

2025-03-05 Thread SendaoYan
On Wed, 5 Mar 2025 07:21:17 GMT, SendaoYan wrote: > Hi all, > > After [JDK-8345627](https://bugs.openjdk.org/browse/JDK-8345627), the minumum > gcc version should be 12. > [JDK-8345627](https://bugs.openjdk.org/browse/JDK-8345627) add gcc compile > option -ftrivial-auto-var-init=pattern for d

Re: RFR: 8351241: Require minimum gcc version 12

2025-03-05 Thread SendaoYan
On Wed, 5 Mar 2025 14:12:54 GMT, Erik Joelsson wrote: > It shouldn't be, unless you have actually tried building the JDK with a lower > version and it failed. I do obscene building jdk failure after [JDK-8345627](https://bugs.openjdk.org/browse/JDK-8345627) with gcc14(riscv cross compiler) an

Re: RFR: 8345169: Implement JEP 503: Remove the 32-bit x86 Port

2025-03-05 Thread David Holmes
On Tue, 4 Mar 2025 16:52:16 GMT, Aleksey Shipilev wrote: > This PR implements JEP 503: Remove the 32-bit x86 Port. > > The JEP is proposed to target 25, we would not integrate until JEP is ready. > Reviews are appreciated meanwhile. > > This is only the removal of obvious 32-bit x86 parts, mos

Integrated: 8351138: Running subset of gtests gets error printing result information

2025-03-05 Thread SendaoYan
On Tue, 4 Mar 2025 16:22:43 GMT, SendaoYan wrote: > Hi all, > > This PR fix the makefile bug when there is no gtest 'disable tests' then > report syntax error. > > Before this PR makefile used below command to get the 'disable tests' number, > when there is no 'YOU HAVE [0-9]+ DISABLED TEST'

Re: RFR: 8351138: Running subset of gtests gets error printing result information [v3]

2025-03-05 Thread SendaoYan
On Wed, 5 Mar 2025 14:10:07 GMT, Erik Joelsson wrote: >> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert regex change in if expr > > Marked as reviewed by erikj (Reviewer). Thanks @erikj79 for the reviews and suggestio

Re: RFR: 8350952: Remove some non present files from OPT_SPEED_SRC list

2025-03-05 Thread Matthias Baesken
On Tue, 4 Mar 2025 16:11:22 GMT, Matthias Baesken wrote: > JvmFeatures.gmk contains a file list OPT_SPEED_SRC , the list contains files > that have to be optimized for speed when the other files are optimized for > binary size. > However some non present files are mentioned and should be remove

Re: RFR: 8350952: Remove some non present files from OPT_SPEED_SRC list

2025-03-05 Thread Christoph Langer
On Tue, 4 Mar 2025 16:11:22 GMT, Matthias Baesken wrote: > JvmFeatures.gmk contains a file list OPT_SPEED_SRC , the list contains files > that have to be optimized for speed when the other files are optimized for > binary size. > However some non present files are mentioned and should be remove

RFR: 8345169: Implement JEP 503: Remove the 32-bit x86 Port

2025-03-05 Thread Aleksey Shipilev
This PR implements JEP 503: Remove the 32-bit x86 Port. The JEP is proposed to target 25, we would not integrate until JEP is ready. Reviews are appreciated meanwhile. This is only the removal of obvious 32-bit x86 parts, mostly files with `x86_32` in their name. Those are only built when buil

Re: RFR: JDK-8348597 : Update HarfBuzz to 10.4.0

2025-03-05 Thread Harshitha Onkar
On Tue, 4 Mar 2025 23:52:49 GMT, Harshitha Onkar wrote: > Harfbuzz upgraded to v10.4.0 > > File changes - > > **Newly added files** > > libharfbuzz/OT/Var/VARC/VARC.hh > libharfbuzz/OT/Var/VARC/coord-setter.hh > libharfbuzz/hb-decycler.hh > libharfbuzz/hb-geometry.hh > libharfbuzz/hb-ot-var-v

Re: RFR: 8345169: Implement JEP 503: Remove the 32-bit x86 Port

2025-03-05 Thread Vladimir Ivanov
On Tue, 4 Mar 2025 16:52:16 GMT, Aleksey Shipilev wrote: > This PR implements JEP 503: Remove the 32-bit x86 Port. > > The JEP is proposed to target 25, we would not integrate until JEP is ready. > Reviews are appreciated meanwhile. > > This is only the removal of obvious 32-bit x86 parts, mos

Re: RFR: JDK-8348597 : Update HarfBuzz to 10.4.0

2025-03-05 Thread Erik Joelsson
On Tue, 4 Mar 2025 23:52:49 GMT, Harshitha Onkar wrote: > Harfbuzz upgraded to v10.4.0 > > File changes - > > **Newly added files** > > libharfbuzz/OT/Var/VARC/VARC.hh > libharfbuzz/OT/Var/VARC/coord-setter.hh > libharfbuzz/hb-decycler.hh > libharfbuzz/hb-geometry.hh > libharfbuzz/hb-ot-var-v

Re: RFR: 8351241: Require minimum gcc version 12

2025-03-05 Thread Erik Joelsson
On Wed, 5 Mar 2025 07:54:51 GMT, SendaoYan wrote: > > > After [JDK-8345627](https://bugs.openjdk.org/browse/JDK-8345627), the > > > minumum gcc version should be 12 > > > > > > Or JDK-8345627 change should only be enabled when gcc version is >= 12. > > JDK-8345627 has already check the gcc co

Re: RFR: 8350952: Remove some non present files from OPT_SPEED_SRC list

2025-03-05 Thread David Holmes
On Tue, 4 Mar 2025 16:11:22 GMT, Matthias Baesken wrote: > JvmFeatures.gmk contains a file list OPT_SPEED_SRC , the list contains files > that have to be optimized for speed when the other files are optimized for > binary size. > However some non present files are mentioned and should be remove

Integrated: 8350952: Remove some non present files from OPT_SPEED_SRC list

2025-03-05 Thread Matthias Baesken
On Tue, 4 Mar 2025 16:11:22 GMT, Matthias Baesken wrote: > JvmFeatures.gmk contains a file list OPT_SPEED_SRC , the list contains files > that have to be optimized for speed when the other files are optimized for > binary size. > However some non present files are mentioned and should be remove

Re: RFR: 8350952: Remove some non present files from OPT_SPEED_SRC list

2025-03-05 Thread Matthias Baesken
On Tue, 4 Mar 2025 16:11:22 GMT, Matthias Baesken wrote: > JvmFeatures.gmk contains a file list OPT_SPEED_SRC , the list contains files > that have to be optimized for speed when the other files are optimized for > binary size. > However some non present files are mentioned and should be remove

Re: RFR: 8351138: Running subset of gtests gets error printing result information [v3]

2025-03-05 Thread Erik Joelsson
On Wed, 5 Mar 2025 02:10:34 GMT, SendaoYan wrote: >> Hi all, >> >> This PR fix the makefile bug when there is no gtest 'disable tests' then >> report syntax error. >> >> Before this PR makefile used below command to get the 'disable tests' >> number, when there is no 'YOU HAVE [0-9]+ DISABLED

Re: RFR: 8345169: Implement JEP 503: Remove the 32-bit x86 Port

2025-03-05 Thread Vladimir Kozlov
On Tue, 4 Mar 2025 16:52:16 GMT, Aleksey Shipilev wrote: > This PR implements JEP 503: Remove the 32-bit x86 Port. > > The JEP is proposed to target 25, we would not integrate until JEP is ready. > Reviews are appreciated meanwhile. > > This is only the removal of obvious 32-bit x86 parts, mos

Re: RFR: JDK-8348597 : Update HarfBuzz to 10.4.0

2025-03-05 Thread Phil Race
On Wed, 5 Mar 2025 19:00:49 GMT, Harshitha Onkar wrote: >> Harfbuzz upgraded to v10.4.0 >> >> File changes - >> >> **Newly added files** >> >> libharfbuzz/OT/Var/VARC/VARC.hh >> libharfbuzz/OT/Var/VARC/coord-setter.hh >> libharfbuzz/hb-decycler.hh >> libharfbuzz/hb-geometry.hh >> libharfbuzz/

Re: RFR: JDK-8348597 : Update HarfBuzz to 10.4.0

2025-03-05 Thread Phil Race
On Tue, 4 Mar 2025 23:52:49 GMT, Harshitha Onkar wrote: > Harfbuzz upgraded to v10.4.0 > > File changes - > > **Newly added files** > > libharfbuzz/OT/Var/VARC/VARC.hh > libharfbuzz/OT/Var/VARC/coord-setter.hh > libharfbuzz/hb-decycler.hh > libharfbuzz/hb-geometry.hh > libharfbuzz/hb-ot-var-v

RFR: 8311227: Add .editorconfig so IDEs would pick up the common settings automatically: indent, trim trailing whitespace

2025-03-05 Thread David Linus Briemann
Add an .editorconfig to define indentation, trim trailing whitespace and open curly brace position for C++ and Java. This allows various editors to easily infer basics of the coding style. - Commit messages: - add editorconfig for better indentation detection Changes: https://git.o

Re: RFR: 8345169: Implement JEP 503: Remove the 32-bit x86 Port

2025-03-05 Thread Vladimir Kozlov
On Tue, 4 Mar 2025 16:52:16 GMT, Aleksey Shipilev wrote: > This PR implements JEP 503: Remove the 32-bit x86 Port. > > The JEP is proposed to target 25, we would not integrate until JEP is ready. > Reviews are appreciated meanwhile. > > This is only the removal of obvious 32-bit x86 parts, mos

RFR: 8351309: test/hotspot/jtreg/runtime/posixSig/TestPosixSig.java fails on static-jdk

2025-03-05 Thread Jiangli Zhou
Please review this PR that excludes `libjsig` from being statically linked with `static-jdk` `java` launcher by default. Please see details in https://bugs.openjdk.org/browse/JDK-8351309 description and comments. Thanks - Commit messages: - Filter out libjsig by default for static

Re: RFR: JDK-8348597 : Update HarfBuzz to 10.4.0

2025-03-05 Thread Phil Race
On Tue, 4 Mar 2025 23:52:49 GMT, Harshitha Onkar wrote: > Harfbuzz upgraded to v10.4.0 > > File changes - > > **Newly added files** > > libharfbuzz/OT/Var/VARC/VARC.hh > libharfbuzz/OT/Var/VARC/coord-setter.hh > libharfbuzz/hb-decycler.hh > libharfbuzz/hb-geometry.hh > libharfbuzz/hb-ot-var-v

Re: RFR: 8345169: Implement JEP 503: Remove the 32-bit x86 Port

2025-03-05 Thread Vladimir Kozlov
On Tue, 4 Mar 2025 16:52:16 GMT, Aleksey Shipilev wrote: > This PR implements JEP 503: Remove the 32-bit x86 Port. > > The JEP is proposed to target 25, we would not integrate until JEP is ready. > Reviews are appreciated meanwhile. > > This is only the removal of obvious 32-bit x86 parts, mos

Re: RFR: 8345169: Implement JEP 503: Remove the 32-bit x86 Port

2025-03-05 Thread Vladimir Ivanov
On Tue, 4 Mar 2025 16:52:16 GMT, Aleksey Shipilev wrote: > This PR implements JEP 503: Remove the 32-bit x86 Port. > > The JEP is proposed to target 25, we would not integrate until JEP is ready. > Reviews are appreciated meanwhile. > > This is only the removal of obvious 32-bit x86 parts, mos

Re: RFR: 8345169: Implement JEP 503: Remove the 32-bit x86 Port

2025-03-05 Thread Vladimir Ivanov
On Wed, 5 Mar 2025 23:19:50 GMT, Vladimir Ivanov wrote: >> This PR implements JEP 503: Remove the 32-bit x86 Port. >> >> The JEP is proposed to target 25, we would not integrate until JEP is ready. >> Reviews are appreciated meanwhile. >> >> This is only the removal of obvious 32-bit x86 parts