On Wed, 5 Mar 2025 22:59:06 GMT, Jiangli Zhou <jian...@openjdk.org> wrote:
> Please review this PR that excludes `libjsig` from being statically linked > with `static-jdk` `java` launcher by default. Please see details in > https://bugs.openjdk.org/browse/JDK-8351309 description and comments. Thanks This LGTM. Perhaps wait for another approval from a reviewer? libjsig is not supposed to be enabled by default. Per [Java 23 doc](https://docs.oracle.com/en/java/javase/23/troubleshoot/handle-signals-and-exceptions.html#GUID-CB49A2A7-2A9F-4C18-948F-6D4A96FF688D), it is user's choice whether to use libjsig.so. If they use it, they should either link the application with linker flag `-ljsig`, or use LD_PRELOAD. ------------- Marked as reviewed by manc (Committer). PR Review: https://git.openjdk.org/jdk/pull/23924#pullrequestreview-2663405583
