Re: RFR: 8348975: Broken links in the JDK 24 JavaDoc API documentation, build 33

2025-02-18 Thread Ian Myers
On Wed, 29 Jan 2025 23:15:08 GMT, Magnus Ihse Bursie wrote: >> Two groups of broken links appeared in the latest JDK docs, broken links to >> man pages and broken ietf links. >> >> - The windows tools markdown files were not being converted to HTML because >> they were placed under `windows/ma

Re: RFR: 8349953: Avoid editing AOTConfiguration file in "make test JTREG=AOT_JDK=true" [v6]

2025-02-18 Thread Ioi Lam
> When running HotSpot jtreg tests in the "AOT mode", for example: > > > make test JTREG=AOT_JDK=true TEST=open/test/hotspot/jtreg/runtime/stringtable > > > Before this PR, in the test set up phase, we record several AOT configuration > files by running a few separate Java tools (javac, javap,

Re: RFR: 8350051: [JMH] Several tests fails NPE [v2]

2025-02-18 Thread SendaoYan
> Hi all, > > Several JMH tests fails 'Cannot invoke "java.io.InputStream.available()" > because "is" is null', because the file > 'build/linux-x86_64-server-release/images/test/micro/benchmarks.jar' missing > the required xml input file defined by > test/micro/org/openjdk/bench/javax/xml/Abst

Re: RFR: 8350051: [JMH] Several tests fails NPE [v2]

2025-02-18 Thread SendaoYan
On Tue, 18 Feb 2025 20:18:12 GMT, Erik Joelsson wrote: >> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use SetupCopyFiles macro to copy the dependency files > > make/test/BuildMicrobenchmark.gmk line 127: > >> 125:

Re: RFR: 8339238: Update to use jtreg 7.5.1 [v2]

2025-02-18 Thread Jaikiran Pai
On Fri, 14 Feb 2025 17:50:57 GMT, Christian Stein wrote: >> Please review the change to update to using jtreg 7.5.1. >> >> The primary change is to the `jib-profiles.js` file, which specifies the >> version of jtreg to use, for those systems that rely on this file. In >> addition, the `require

Re: RFR: 8350051: [JMH] Several tests fails NPE [v2]

2025-02-18 Thread Claes Redestad
On Wed, 19 Feb 2025 03:21:37 GMT, SendaoYan wrote: >> Hi all, >> >> Several JMH tests fails 'Cannot invoke "java.io.InputStream.available()" >> because "is" is null', because the file >> 'build/linux-x86_64-server-release/images/test/micro/benchmarks.jar' missing >> the required xml input fil

Re: RFR: 8350051: [JMH] Several tests fails NPE [v2]

2025-02-18 Thread SendaoYan
On Wed, 19 Feb 2025 05:05:17 GMT, Claes Redestad wrote: > If anyone changes these tests on the functional side we'd silently break. After this PR, if the dependency XML files been removed will make `make test-image` fails. So maybe we do not need a new unit test to guard it. > Perhaps needs a

Integrated: 8339238: Update to use jtreg 7.5.1

2025-02-18 Thread Christian Stein
On Thu, 29 Aug 2024 11:26:03 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.5.1. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVers

Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64

2025-02-18 Thread Jiangli Zhou
On Wed, 5 Feb 2025 19:41:51 GMT, Jiangli Zhou wrote: > Please review this change that adds a `linux-x86-static` job in GHA. The job > builds the `static-jdk-image` release binary on linux-x64. Please see > https://mail.openjdk.org/pipermail/build-dev/2025-February/048830.html for > some addit

Re: RFR: 8350051: [JMH] Several tests fails NPE

2025-02-18 Thread SendaoYan
On Tue, 18 Feb 2025 20:23:05 GMT, Erik Joelsson wrote: > I'm not sure if this is the right way to solve this. I would really like > someone more familiar with the microbenchmarks to weigh in on how this was > originally meant to work. Hi, @cl4es, Could you take took this PR. - PR

Re: RFR: 8349953: Avoid editing AOTConfiguration file in "make test JTREG=AOT_JDK=true" [v5]

2025-02-18 Thread Ioi Lam
On Tue, 18 Feb 2025 20:40:12 GMT, Erik Joelsson wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Move the contents of SetupAOT.gmk back to RunTests.gmk, as it is not >> necessary to have the definitions in a stand-alone

Integrated: 8350202: Tune for Power10 CPUs on Linux ppc64le

2025-02-18 Thread Matthias Baesken
On Mon, 17 Feb 2025 14:00:01 GMT, Matthias Baesken wrote: > Currently we tune for older Power8 CPUs in the libjvm build, this should be > adjusted to current Power10. > > We do not set (yet) mcpu / mtune in the other native compilation units in the > linux ppc64le build; this should we reconsi

Re: RFR: 8350202: Tune for Power10 CPUs on Linux ppc64le

2025-02-18 Thread Matthias Baesken
On Mon, 17 Feb 2025 14:00:01 GMT, Matthias Baesken wrote: > Currently we tune for older Power8 CPUs in the libjvm build, this should be > adjusted to current Power10. > > We do not set (yet) mcpu / mtune in the other native compilation units in the > linux ppc64le build; this should we reconsi

Integrated: 8346050: Update BuildTestLib.gmk to build whole testlibrary

2025-02-18 Thread Leonid Mesnik
On Fri, 7 Feb 2025 21:15:36 GMT, Leonid Mesnik wrote: > The fix add remaining classes to the testlibrary jar and fix some warnings in > security-related classes. This pull request has now been integrated. Changeset: 62d93f2a Author:Leonid Mesnik URL: https://git.openjdk.org/jdk/com

Re: RFR: 8350051: [JMH] Several tests fails NPE

2025-02-18 Thread Erik Joelsson
On Fri, 14 Feb 2025 07:21:27 GMT, SendaoYan wrote: > Hi all, > > Several JMH tests fails 'Cannot invoke "java.io.InputStream.available()" > because "is" is null', because the file > 'build/linux-x86_64-server-release/images/test/micro/benchmarks.jar' missing > the required xml input file defi

Re: RFR: 8350094: Linux gcc 13.2.0 build fails when ubsan is enabled

2025-02-18 Thread Erik Joelsson
On Fri, 14 Feb 2025 15:04:42 GMT, Matthias Baesken wrote: > When using a gcc 13.2.0 devkit, the Linux builds (x86_64 and ppc64le) fail > with warnings as errors in case that ubsan is enabled. > The 2 warnings as errors are about memset usages ; we see those issues with > gcc 13.2 but did not se

Re: RFR: 8339238: Update to use jtreg 7.5.1 [v2]

2025-02-18 Thread Erik Joelsson
On Fri, 14 Feb 2025 17:50:57 GMT, Christian Stein wrote: >> Please review the change to update to using jtreg 7.5.1. >> >> The primary change is to the `jib-profiles.js` file, which specifies the >> version of jtreg to use, for those systems that rely on this file. In >> addition, the `require

RFR: 8350280: The JDK-8346050 testlibrary changes break the build

2025-02-18 Thread Leonid Mesnik
Please review following trivial PR that fix library build by adding --add-exports. Testing: tier1 - Commit messages: - Added javac opts Changes: https://git.openjdk.org/jdk/pull/23680/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23680&range=00 Issue: https://bugs.ope

Re: RFR: 8350280: The JDK-8346050 testlibrary changes break the build

2025-02-18 Thread David Holmes
On Tue, 18 Feb 2025 20:49:27 GMT, Leonid Mesnik wrote: > Please review following trivial PR that fix library build by adding > --add-exports. > Testing: tier1 Seems reasonable - and trivial Thanks - Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jd

Re: RFR: 8349953: Avoid editing AOTConfiguration file in "make test JTREG_AOT_JDK=true" [v5]

2025-02-18 Thread Erik Joelsson
On Tue, 18 Feb 2025 19:27:58 GMT, Ioi Lam wrote: >> When running HotSpot jtreg tests in the "AOT mode", for example: >> >> >> make test JTREG_AOT_JDK=true open/test/hotspot/jtreg/runtime/stringtable >> >> >> Before this PR, in the test set up phase, we record several AOT >> configuration fil

Integrated: 8350280: The JDK-8346050 testlibrary changes break the build

2025-02-18 Thread Leonid Mesnik
On Tue, 18 Feb 2025 20:49:27 GMT, Leonid Mesnik wrote: > Please review following trivial PR that fix library build by adding > --add-exports. > Testing: tier1 This pull request has now been integrated. Changeset: 2d03bd00 Author:Leonid Mesnik URL: https://git.openjdk.org/jdk/commi

Re: RFR: 8350041: Make libstringPlatformChars support static JDK

2025-02-18 Thread Jiangli Zhou
On Tue, 18 Feb 2025 17:05:06 GMT, Alan Bateman wrote: > I don't object to changing this test but it might be simpler to just skip > this test, once we can use `@requires !jdk.static`. Thanks, @AlanBateman. I think skipping this test for static JDK sounds reasonable to me, since this test seems

Re: RFR: 8346050: Update BuildTestLib.gmk to build whole testlibrary [v4]

2025-02-18 Thread Weijun Wang
On Fri, 14 Feb 2025 18:22:26 GMT, Leonid Mesnik wrote: >> The fix add remaining classes to the testlibrary jar and fix some warnings >> in security-related classes. > > Leonid Mesnik has updated the pull request incrementally with two additional > commits since the last revision: > > - added

Re: RFR: 8349638: Build libjdwp with SIZE optimization

2025-02-18 Thread Matthias Baesken
On Mon, 17 Feb 2025 22:53:29 GMT, Chris Plummer wrote: > > btw for libjdwp with lto enabled (have to modify the make settings because > > this is not supported out of the box) I get > > 1.8M ./lib/libjdwp.debuginfo 280K ./lib/libjdwp.so > > This looks pretty good compared to HIGH or standard (LO

Re: RFR: 8349953: Avoid editing AOTConfiguration file in "make test JTREG_AOT_JDK=true" [v5]

2025-02-18 Thread Ioi Lam
> When running HotSpot jtreg tests in the "AOT mode", for example: > > > make test JTREG_AOT_JDK=true open/test/hotspot/jtreg/runtime/stringtable > > > Before this PR, in the test set up phase, we record several AOT configuration > files by running a few separate Java tools (javac, javap, jlin

Re: RFR: 8350041: Make libstringPlatformChars support static JDK

2025-02-18 Thread Alan Bateman
On Fri, 14 Feb 2025 18:31:52 GMT, Jiangli Zhou wrote: > Please review the fix to make > `java/lang/String/nativeEncoding/StringPlatformChars.java` jtreg test: > > - Lookup `JNU_GetStringPlatformChars`, `JNU_ClassString` and > `JNU_NewStringPlatform` dynamically > - Remove `#include "jni_util.

Re: RFR: 8339238: Update to use jtreg 7.5.1 [v2]

2025-02-18 Thread Roger Riggs
On Fri, 14 Feb 2025 17:50:57 GMT, Christian Stein wrote: >> Please review the change to update to using jtreg 7.5.1. >> >> The primary change is to the `jib-profiles.js` file, which specifies the >> version of jtreg to use, for those systems that rely on this file. In >> addition, the `require

Re: RFR: 8350202: Tune for Power10 CPUs on Linux ppc64le

2025-02-18 Thread Martin Doerr
On Mon, 17 Feb 2025 14:00:01 GMT, Matthias Baesken wrote: > Currently we tune for older Power8 CPUs in the libjvm build, this should be > adjusted to current Power10. > > We do not set (yet) mcpu / mtune in the other native compilation units in the > linux ppc64le build; this should we reconsi

Re: RFR: 8345265: Minor improvements for LTO across all compilers [v2]

2025-02-18 Thread Matthias Baesken
On Fri, 17 Jan 2025 13:50:11 GMT, Matthias Baesken wrote: >>> > Member >>> >>> Fixing the JVM under LTO is likely to be a heavy undertaking, much more so >>> than just unbreaking compilation and linking of the JVM (Ignoring that the >>> JVM later crashes when the newly compiled JDK is used to

Re: RFR: 8349953: Avoid editing AOTConfiguration file in "make test JTREG_AOT_JDK=true" [v4]

2025-02-18 Thread Andrey Turbanov
On Sat, 15 Feb 2025 04:46:56 GMT, Ioi Lam wrote: >> When running HotSpot jtreg tests in the "AOT mode", for example: >> >> >> make test JTREG_AOT_JDK=true open/test/hotspot/jtreg/runtime/stringtable >> >> >> Before this PR, in the test set up phase, we record several AOT >> configuration fil