On Sat, 15 Feb 2025 04:46:56 GMT, Ioi Lam <ik...@openjdk.org> wrote:
>> When running HotSpot jtreg tests in the "AOT mode", for example:
>>
>>
>> make test JTREG_AOT_JDK=true open/test/hotspot/jtreg/runtime/stringtable
>>
>>
>> Before this PR, in the test set up phase, we record several AOT
>> configuration files by running a few separate Java tools (javac, javap,
>> jlink, and jar), and then combine them together with sed, grep, sort and
>> uniq:
>>
>> https://github.com/openjdk/jdk/blob/adc3f53d2403cd414a91e71c079b4108b2346da0/make/RunTests.gmk#L723-L744
>>
>> After [JDK-8348426](https://bugs.openjdk.org/browse/JDK-8348426), the AOT
>> configuration file will change to a binary format and can no longer be
>> edited this way. In preparation for
>> [JDK-8348426](https://bugs.openjdk.org/browse/JDK-8348426), we should change
>> the "JTREG_AOT_JDK=true" set up to run a single Java program that
>> accomplishes the same effect as the current implementation.
>>
>> ** Changes in this PR **
>>
>> This PR combines the invocation of these Java tools into a single Java
>> program, so we just have a single AOT configuration file. It also uses the
>> `-XX:ExtraSharedClassListFile` option to include the default classlist from
>> the JDK home directory,
>
> Ioi Lam has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Moved the AOT setup function into SetupAOT.gmk so it can be included by
> other internal makefiles
test/jtreg_setup_aot/ExerciseJDKClasses.java line 54:
> 52: // E.g., use javac to compile a program.
> 53: for (String tool : tools) {
> 54: ToolProvider t = ToolProvider.findFirst(tool)
Suggestion:
ToolProvider t = ToolProvider.findFirst(tool)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23620#discussion_r1959398001
