RFR: 8344318: Enhance configure help for enabling/disabling single JVM features

2024-11-19 Thread Matthias Baesken
The current help of OpenJDK configure could be enhanced a bit regarding enabling/disabling JVM features. - Commit messages: - JDK-8344318 Changes: https://git.openjdk.org/jdk/pull/22231/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22231&range=00 Issue: https://bugs.op

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v57]

2024-11-19 Thread Andrew Haley
On Thu, 7 Nov 2024 17:25:40 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> previ

Re: RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives [v3]

2024-11-19 Thread Calvin Cheung
> With this change, the compact object headers related CDS archives > (`classes_coh.jsa` and `classes_nocoops_coh.jsa`) will not be generated by > default. If the user needs them, the user can specify the > `--enable-cds-archive-coh=yes` build configure option. > This change also modified the Te

Re: RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives [v2]

2024-11-19 Thread Calvin Cheung
On Tue, 19 Nov 2024 14:18:59 GMT, Erik Joelsson wrote: > I'm a bit unsure what was actually agreed in the bug discussion. Are wanting > to disable this by default for OpenJDK, requiring anyone who wants it enabled > to add a new configure option, or are we only intending to change the > config

Re: https://bugs.openjdk.org/browse/JDK-8336862

2024-11-19 Thread Joseph D. Darcy
From the OpenJDK Developers’ Guide, Please note that OpenJDK mailing lists typically are for discussions about the *development* of the JDK, not its usage. This is not a place to ask support questions. If you think you found an issue in or with the JDK, see JBS - JDK Bug System

RFR: 8344041: Re-enable external specs page

2024-11-19 Thread Hannes Wallnöfer
Please review a change to enable the External Specifications page in API docs. The page was disabled because of missing `@spec` tags in OpenJDK sources. This is a straightforward undo of of #13127 / [JDK-8304689], which means the hidden ad-hoc `--no-external-specs-page` option is also removed.

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v17]

2024-11-19 Thread Erik Joelsson
On Mon, 18 Nov 2024 15:12:12 GMT, Magnus Ihse Bursie wrote: >> As a prerequisite for Hermetic Java, we need a statically linked `java` >> launcher. It should behave like the normal, dynamically linked `java` >> launcher, except that all JDK native libraries should be statically, not >> dynamic

Re: RFR: 8344318: Enhance configure help for enabling/disabling single JVM features

2024-11-19 Thread Erik Joelsson
On Tue, 19 Nov 2024 19:09:59 GMT, Kim Barrett wrote: >> make/autoconf/help.m4 line 243: >> >>> 241: # Print available JVM features >>> 242: $PRINTF "The following JVM features are valid as arguments to >>> --with-jvm-features.\n" >>> 243: $PRINTF "The flag --enable-jvm-feature-=no c

Re: RFR: 8344451: Deprecate for removal java.awt.Window.getWarningString() [v2]

2024-11-19 Thread Phil Race
On Tue, 19 Nov 2024 17:25:09 GMT, Erik Joelsson wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8344451 > > make/modules/java.desktop/gensrc/GensrcIcons.gmk line 41: > >> 39: >> 40: >> 41: AWT_ICONPATH := $(MODULE_

Re: RFR: 8344350: Add '.gdbinit' and '.lldbinit' to file '.gitignore'

2024-11-19 Thread Erik Joelsson
On Sat, 16 Nov 2024 16:29:20 GMT, Guoxiong Li wrote: > Hi all, > > Some developers want to run some initial scripts locally when the debugger > (gdb or lldb) starts. So they often add a file named `.gdbinit` or > `.lldbinit` in the project root path. It is good to ignore them. > > Thanks for

Re: RFR: 8344318: Enhance configure help for enabling/disabling single JVM features

2024-11-19 Thread Erik Joelsson
On Tue, 19 Nov 2024 09:25:44 GMT, Matthias Baesken wrote: > The current help of OpenJDK configure could be enhanced a bit regarding > enabling/disabling JVM features. make/autoconf/help.m4 line 243: > 241: # Print available JVM features > 242: $PRINTF "The following JVM features are va

Re: RFR: 8344056: Use markdown format for man pages [v4]

2024-11-19 Thread Eirik Bjørsnøs
On Fri, 15 Nov 2024 14:50:21 GMT, Magnus Ihse Bursie wrote: >> Currently, the man pages are stored as troff (a text format) in the open >> repo, and a content-wise identical copy is stored as markdown (another text >> format) in the closed repo. >> >> Since markdown is preferred to troff in te

Re: RFR: 8342903: Deprecate for removal java.awt.Window.getWarningString() [v2]

2024-11-19 Thread Erik Joelsson
On Tue, 19 Nov 2024 19:29:28 GMT, Phil Race wrote: >> This fix deprecates for removal java.awt.Window.getWarningString() and also >> javax.swing.JInternalFrame.getWarningString() >> l java.awt.Window.getWarningString() is only relevant with a SecurityManager >> and javax.swing.JInternalFrame.ge

Re: RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives [v3]

2024-11-19 Thread Erik Joelsson
On Tue, 19 Nov 2024 22:50:37 GMT, Calvin Cheung wrote: >> With this change, the compact object headers related CDS archives >> (`classes_coh.jsa` and `classes_nocoops_coh.jsa`) will not be generated by >> default. If the user needs them, the user can specify the >> `--enable-cds-archive-coh=ye

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v4]

2024-11-19 Thread Patrick Zhang
On Fri, 22 Mar 2024 15:30:35 GMT, Hamlin Li wrote: > > > Ah, it'll only be the redirect library that's compiled with > > > -march=armv8-a+sve Forget that. > > > > > > But that raises an interesting question. What happens if you try to load a > > library compiled with `-march=armv8-a+sve` on a

Integrated: 8341553: Remove UseCompactObjectHeaders extra CDS archives

2024-11-19 Thread Calvin Cheung
On Tue, 12 Nov 2024 23:27:27 GMT, Calvin Cheung wrote: > With this change, the compact object headers related CDS archives > (`classes_coh.jsa` and `classes_nocoops_coh.jsa`) will not be generated by > default. If the user needs them, the user can specify the > `--enable-cds-archive-coh=yes` b

Re: RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives [v2]

2024-11-19 Thread Calvin Cheung
On Thu, 14 Nov 2024 05:18:05 GMT, Ioi Lam wrote: >> Calvin Cheung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @iklam comment > > Test changes look good. Thanks @iklam, @coleenp, @erikj79 for the review. - PR Comment: h

Integrated: 8344350: Add '.gdbinit' and '.lldbinit' to file '.gitignore'

2024-11-19 Thread Guoxiong Li
On Sat, 16 Nov 2024 16:29:20 GMT, Guoxiong Li wrote: > Hi all, > > Some developers want to run some initial scripts locally when the debugger > (gdb or lldb) starts. So they often add a file named `.gdbinit` or > `.lldbinit` in the project root path. It is good to ignore them. > > Thanks for

Re: RFR: 8344350: Add '.gdbinit' and '.lldbinit' to file '.gitignore'

2024-11-19 Thread Guoxiong Li
On Sat, 16 Nov 2024 16:29:20 GMT, Guoxiong Li wrote: > Hi all, > > Some developers want to run some initial scripts locally when the debugger > (gdb or lldb) starts. So they often add a file named `.gdbinit` or > `.lldbinit` in the project root path. It is good to ignore them. > > Thanks for

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v8]

2024-11-19 Thread Brian Burkhalter
On Fri, 13 Sep 2024 20:41:27 GMT, Brian Burkhalter wrote: >> This proposed change would move the native objects required for NIO file >> interaction from the libnio native library to the libjava native library on >> Linux, macOS, and Windows. > > Brian Burkhalter has updated the pull request in

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v9]

2024-11-19 Thread Brian Burkhalter
> This proposed change would move the native objects required for NIO file > interaction from the libnio native library to the libjava native library on > Linux, macOS, and Windows. Brian Burkhalter has updated the pull request with a new target base due to a merge or a rebase. The pull request

Re: RFR: 8344451: Deprecate for removal java.awt.Window.getWarningString() [v2]

2024-11-19 Thread Phil Race
> This fix deprecates for removal java.awt.Window.getWarningString() and also > javax.swing.JInternalFrame.getWarningString() > l java.awt.Window.getWarningString() is only relevant with a SecurityManager > and javax.swing.JInternalFrame.getWarningString() is just there for symmetry. > > A few o

https://bugs.openjdk.org/browse/JDK-8336862

2024-11-19 Thread Darren Mark
Team, We are using Amazon Corretto and are facing the same issue as described in the JDK-8336862. However, I believe the issue was introduced in JDK 17.0.10.7.1. It works fine in JDK 17.0.9.8.1 This is affecting our applications ability to export html to pdf as the width of the html document ca

Re: RFR: 8342903: Deprecate for removal java.awt.Window.getWarningString() [v2]

2024-11-19 Thread Alexander Zvegintsev
On Tue, 19 Nov 2024 19:29:28 GMT, Phil Race wrote: >> This fix deprecates for removal java.awt.Window.getWarningString() and also >> javax.swing.JInternalFrame.getWarningString() >> l java.awt.Window.getWarningString() is only relevant with a SecurityManager >> and javax.swing.JInternalFrame.ge

Re: RFR: 8344451: Deprecate for removal java.awt.Window.getWarningString()

2024-11-19 Thread Erik Joelsson
On Mon, 18 Nov 2024 22:11:52 GMT, Phil Race wrote: > This fix deprecates for removal java.awt.Window.getWarningString() and also > javax.swing.JInternalFrame.getWarningString() > l java.awt.Window.getWarningString() is only relevant with a SecurityManager > and javax.swing.JInternalFrame.getWar

Re: RFR: 8342869: Errors related to unused code on Windows after 8339120 in awt

2024-11-19 Thread Phil Race
On Wed, 23 Oct 2024 05:07:37 GMT, Julian Waters wrote: > After 8339120, gcc began catching many different instances of unused code in > the Windows specific codebase. Some of these seem to be bugs. I've taken the > effort to mark out all the relevant globals and locals that trigger the > unuse

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v9]

2024-11-19 Thread Jiangli Zhou
On Wed, 13 Nov 2024 01:40:23 GMT, Jiangli Zhou wrote: >> @jianglizhou Thank you for your assistance in figuring out the problem. I >> guess I throw out too much code from the hermetic-java-runtime branch when >> trying to minimize the changes to only build-related stuff. The jimage >> changes

RFR: 8342836: Automatically determine that a test in the docs test root is requested

2024-11-19 Thread Nizar Benalla
Please review this patch to automatically set `TEST_DEPS` to `docs-jdk` when testing the documentation. This comes as a followup to https://github.com/openjdk/jdk/commit/07f550b85a3910edd28d8761e2adfb8d6a1352f6 , as review comments suggested better aways of adding dependencies and to not requi

Re: github repo hash in the binaries and hserr file ?

2024-11-19 Thread Erik Joelsson
The git hash currently ends up in the release file in the root of the JDK image. I'm not aware of any other initiative to propagate that anywhere else. /Erik On 11/14/24 1:24 AM, Baesken, Matthias wrote: Hello, I wonder if there is / was already an attempt to compile the github repo hash in

Re: RFR: 8342836: Automatically determine that a test in the docs test root is requested

2024-11-19 Thread Erik Joelsson
On Tue, 19 Nov 2024 14:23:30 GMT, Nizar Benalla wrote: > Please review this patch to automatically set `TEST_DEPS` to `docs-jdk` when > testing the documentation. > > This comes as a followup to > https://github.com/openjdk/jdk/commit/07f550b85a3910edd28d8761e2adfb8d6a1352f6 > , as review com

Re: RFR: 8344041: Re-enable external specs page

2024-11-19 Thread Erik Joelsson
On Tue, 19 Nov 2024 15:45:18 GMT, Hannes Wallnöfer wrote: > Please review a change to enable the External Specifications page in API > docs. The page was disabled because of missing `@spec` tags in OpenJDK > sources. This is a straightforward undo of of #13127 / [JDK-8304689], which > means th

Re: RFR: 8344318: Enhance configure help for enabling/disabling single JVM features

2024-11-19 Thread Kim Barrett
On Tue, 19 Nov 2024 17:35:55 GMT, Erik Joelsson wrote: >> The current help of OpenJDK configure could be enhanced a bit regarding >> enabling/disabling JVM features. > > make/autoconf/help.m4 line 243: > >> 241: # Print available JVM features >> 242: $PRINTF "The following JVM features