On Tue, 29 Oct 2024 12:56:25 GMT, Sean Mullan wrote:
>> test/jdk/javax/xml/crypto/dsig/keyinfo/KeyInfo/Marshal.java line 30:
>>
>>> 28: * @modules java.xml.crypto/org.jcp.xml.dsig.internal.dom
>>> 29: * @compile -XDignore.symbol.file Marshal.java
>>> 30: * @run main/othervm/java.security.poli
On Fri, 1 Nov 2024 19:38:45 GMT, Jiangli Zhou wrote:
>> Please review this PR that fixes JDK build configure failure when using
>> clang after JDK-8338304:
>>
>>
>> Found candidate GCC installation:
>> Selected GCC installation:
>> ...
>> clang: error: unsupported option '-V -static-libgcc'
On Mon, 28 Oct 2024 14:35:57 GMT, Sean Mullan wrote:
>> That and possibly rename the test because now it does not have anything to
>> do with the SecurityException. Now we only check that providing an empty
>> file causes the InvalidMidiDataException so EmptySoundBankTest or something
>> to th
On Fri, 1 Nov 2024 15:52:50 GMT, Magnus Ihse Bursie wrote:
> > Bug in macroAssembler_x86.cpp - should be _WINDOWS
>
> So what does that mean? That the code is currently broken and is incorrectly
> included on Windows? If so, it should be fixed in a separate PR. Or is it
> just a stylistic issu
On Thu, 31 Oct 2024 22:25:04 GMT, Mandy Chung wrote:
> Many tests failed in compiling test library
> `test/jdk/tools/lib/tests/JImageValidator.java` as it depends on the
> ClassFile API and preview needs to be enabled.
It looks like my environment issue. They all pass for me now.
--
On Fri, 1 Nov 2024 16:04:55 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Fri, 1 Nov 2024 01:26:44 GMT, Mandy Chung wrote:
> I expect that the jmodless tests will first build an image (say `image1`)
> using jlink `--generate-linkable-runtime` option and then verify
> `image1/bin/jlink` that links from the run-time image. I don't see
> `--generate-linkable-runtime
On Fri, 1 Nov 2024 00:08:56 GMT, Jiangli Zhou wrote:
> Please review this PR that fixes JDK build configure failure when using clang
> after JDK-8338304:
>
>
> Found candidate GCC installation:
> Selected GCC installation:
> ...
> clang: error: unsupported option '-V -static-libgcc'
> config
On Fri, 1 Nov 2024 16:04:55 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Fri, 1 Nov 2024 00:08:56 GMT, Jiangli Zhou wrote:
> Please review this PR that fixes JDK build configure failure when using clang
> after JDK-8338304:
>
>
> Found candidate GCC installation:
> Selected GCC installation:
> ...
> clang: error: unsupported option '-V -static-libgcc'
> config
On Fri, 1 Nov 2024 15:30:14 GMT, Magnus Ihse Bursie wrote:
>> Please review this PR that fixes JDK build configure failure when using
>> clang after JDK-8338304:
>>
>>
>> Found candidate GCC installation:
>> Selected GCC installation:
>> ...
>> clang: error: unsupported option '-V -static-li
On Wed, 30 Oct 2024 19:53:27 GMT, Vladimir Kozlov wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Error in os_windows.cpp for unknown cpu
>
> `grep -i win32 -r src/hotspot/share/` shows several places missed
On Fri, 1 Nov 2024 16:25:59 GMT, Magnus Ihse Bursie wrote:
>> As a prerequisite for Hermetic Java, we need a statically linked `java`
>> launcher. It should behave like the normal, dynamically linked `java`
>> launcher, except that all JDK native libraries should be statically, not
>> dynamica
On Tue, 22 Oct 2024 09:28:36 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch? Previously it's
>> https://github.com/openjdk/jdk/pull/18605.
>> This pr is based on https://github.com/openjdk/jdk/pull/20781.
>>
>> Thanks!
>>
>> ## Test
>> ### tests:
>> * test/jdk/jdk/incubator/v
> As a prerequisite for Hermetic Java, we need a statically linked `java`
> launcher. It should behave like the normal, dynamically linked `java`
> launcher, except that all JDK native libraries should be statically, not
> dynamically, linked.
>
> This patch is the first step towards this goal.
On Wed, 23 Oct 2024 08:23:34 GMT, Johan Vos wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Don't hardcode server variant
>
> I tried to build/run this on Linux as well (since I'm using parts of this PR
> in
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
> Port_](https://openjdk.org/jeps/479).
>
> This is the summary of JEP 479:
>> Remove the source code and build support for the Windows 32-bit x86 port.
>> This port was [deprecated for removal in JDK
>> 21](https://openjd
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
> Port_](https://openjdk.org/jeps/479).
>
> This is the summary of JEP 479:
>> Remove the source code and build support for the Windows 32-bit x86 port.
>> This port was [deprecated for removal in JDK
>> 21](https://openjd
On Wed, 30 Oct 2024 19:53:27 GMT, Vladimir Kozlov wrote:
> `grep -i win32 -r src/hotspot/share/` shows several places missed in these
> changes
I'm actually not sure which places you refer to here. Can you be more specific?
(Note that, oddly enough, `_WIN32` is still defined on 64-bit Windows
On Wed, 30 Oct 2024 19:37:47 GMT, Vladimir Kozlov wrote:
> Bug in macroAssembler_x86.cpp - should be _WINDOWS
So what does that mean? That the code is currently broken and is incorrectly
included on Windows? If so, it should be fixed in a separate PR. Or is it just
a stylistic issue, that both
On Tue, 29 Oct 2024 20:43:16 GMT, Magnus Ihse Bursie wrote:
>> As a prerequisite for Hermetic Java, we need a statically linked `java`
>> launcher. It should behave like the normal, dynamically linked `java`
>> launcher, except that all JDK native libraries should be statically, not
>> dynamic
On Tue, 29 Oct 2024 20:43:16 GMT, Magnus Ihse Bursie wrote:
>> As a prerequisite for Hermetic Java, we need a statically linked `java`
>> launcher. It should behave like the normal, dynamically linked `java`
>> launcher, except that all JDK native libraries should be statically, not
>> dynamic
> Prepare for JDK 25.
Pavel Rappo has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains five additional commits since
the last revision:
- Update --release
On Fri, 1 Nov 2024 16:04:55 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
> Please review this PR that fixes JDK build configure failure when using clang
> after JDK-8338304:
>
>
> Found candidate GCC installation:
> Selected GCC installation:
> ...
> clang: error: unsupported option '-V -static-libgcc'
> configure:85215: $? = 1
> configure:85204: -qversion >&5
> c
On Fri, 1 Nov 2024 15:32:31 GMT, Magnus Ihse Bursie wrote:
>> make/autoconf/toolchain.m4 line 448:
>>
>>> 446: fi
>>> 447: fi
>>> 448: USE_USER_SUPPLIED_COMPILER=true
>>
>> This code is called for both CC and CXX. So if you run like `configure
>> CC=foo` (but not with `CXX=bar` a
On Fri, 1 Nov 2024 19:38:45 GMT, Jiangli Zhou wrote:
>> Please review this PR that fixes JDK build configure failure when using
>> clang after JDK-8338304:
>>
>>
>> Found candidate GCC installation:
>> Selected GCC installation:
>> ...
>> clang: error: unsupported option '-V -static-libgcc'
On Thu, 24 Oct 2024 20:57:50 GMT, Sean Mullan wrote:
>> @honkar-jdk I'm inclined to leave it as because it's not the only method
>> which doesn't have a blank line between `@param` and `@throw` in this file.
>>
>> If it's worth taking care of, we may submit another bug to address it later.
>
>
On Mon, 28 Oct 2024 14:08:46 GMT, Sean Mullan wrote:
>> src/java.desktop/share/classes/java/awt/Font.java line 1612:
>>
>>> 1610: * obtained. The {@code String} value of this property is then
>>> 1611: * interpreted as a {@code Font} object according to the
>>> 1612: * specificat
On Mon, 28 Oct 2024 18:07:26 GMT, Harshitha Onkar wrote:
>> I'd not looked at this test before but when I do the thing I noticed is that
>> createPrivateValue is no longer used.
>> But I don't see a problem with keeping the rest of the test.
>
> Test updated in sandbox -
> https://github.com/op
On Fri, 1 Nov 2024 16:09:20 GMT, Magnus Ihse Bursie wrote:
> I finally noticed that you are testing a precompiled HelloWorld class, and I
> have been running with a source file argument to have java compile it on the
> fly.
>
> When I try using a pre-compiled HelloWorld, the linux port works f
On Fri, 1 Nov 2024 16:04:55 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Wed, 30 Oct 2024 19:28:32 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Wed, 30 Oct 2024 19:28:32 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Fri, 1 Nov 2024 22:24:28 GMT, Jiangli Zhou wrote:
> > I finally noticed that you are testing a precompiled HelloWorld class, and
> > I have been running with a source file argument to have java compile it on
> > the fly.
> > When I try using a pre-compiled HelloWorld, the linux port works fo
On Fri, 1 Nov 2024 00:08:56 GMT, Jiangli Zhou wrote:
> Please review this PR that fixes JDK build configure failure when using clang
> after JDK-8338304:
>
>
> Found candidate GCC installation:
> Selected GCC installation:
> ...
> clang: error: unsupported option '-V -static-libgcc'
> config
On Fri, 1 Nov 2024 20:10:20 GMT, Erik Joelsson wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update to set CC_IS_USER_SUPPLIED and CXX_IS_USER_SUPPLIED. Only do
>> UTIL_REQUIRE_PROGS(LLD, lld)
>> if both CC_IS
On Tue, 22 Oct 2024 09:28:36 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch? Previously it's
>> https://github.com/openjdk/jdk/pull/18605.
>> This pr is based on https://github.com/openjdk/jdk/pull/20781.
>>
>> Thanks!
>>
>> ## Test
>> ### tests:
>> * test/jdk/jdk/incubator/v
On Wed, 30 Oct 2024 19:28:32 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 31 Oct 2024 12:09:25 GMT, Aleksey Shipilev wrote:
> [JDK-8343190](https://bugs.openjdk.org/browse/JDK-8343190) was in mainline
> for a few days. I have now caught the case where JTReg fails to build due to
> network failure (wget exit code 4):
>
>
> Run # Try building JTReg several ti
On Thu, 31 Oct 2024 12:09:25 GMT, Aleksey Shipilev wrote:
> [JDK-8343190](https://bugs.openjdk.org/browse/JDK-8343190) was in mainline
> for a few days. I have now caught the case where JTReg fails to build due to
> network failure (wget exit code 4):
>
>
> Run # Try building JTReg several ti
On Tue, 22 Oct 2024 09:28:36 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch? Previously it's
>> https://github.com/openjdk/jdk/pull/18605.
>> This pr is based on https://github.com/openjdk/jdk/pull/20781.
>>
>> Thanks!
>>
>> ## Test
>> ### tests:
>> * test/jdk/jdk/incubator/v
On Tue, 22 Oct 2024 09:28:36 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch? Previously it's
>> https://github.com/openjdk/jdk/pull/18605.
>> This pr is based on https://github.com/openjdk/jdk/pull/20781.
>>
>> Thanks!
>>
>> ## Test
>> ### tests:
>> * test/jdk/jdk/incubator/v
43 matches
Mail list logo