On Wed, 30 Oct 2024 19:53:27 GMT, Vladimir Kozlov <k...@openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Error in os_windows.cpp for unknown cpu
>
> `grep -i win32 -r src/hotspot/share/` shows several places missed in these 
> changes

@vnkozlov 

> There is useless code in src/hotspot/cpu//x86/interpreterRT_x86_32.cpp which 
> is guarded by #ifdef AMD64 which is false for 32-bit.

Yes; this has been discussed above. Aleksey opened 
https://bugs.openjdk.org/browse/JDK-8343167 to solve that separately, since it 
is not Windows 32-bit specific.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21744#issuecomment-2452093887

Reply via email to