On Tue, 22 Oct 2024 21:30:40 GMT, Erik Joelsson wrote:
> The target mac-jdk-bundle can fail randomly. MacBundles.gmk defines a large
> number of individual copy rules, which can execute in any order. The
> "install-file" (our copy) macro on macos includes a check for weird
> attributes using `
On Mon, 21 Oct 2024 04:11:03 GMT, Jasmine Karthikeyan
wrote:
> Hi all,
> This patch adds a new pass to consolidate lowering of complex
> backend-specific code patterns, such as `MacroLogicV` and the optimization
> proposed by #21244. Moving these optimizations to backend code can simplify
> s
On Tue, 15 Oct 2024 20:22:52 GMT, Magnus Ihse Bursie wrote:
>> As a prerequisite for Hermetic Java, we need a statically linked `java`
>> launcher. It should behave like the normal, dynamically linked `java`
>> launcher, except that all JDK native libraries should be statically, not
>> dynamic
On Tue, 22 Oct 2024 16:19:24 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Tue, 22 Oct 2024 21:20:59 GMT, Mandy Chung wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNote to de
On Mon, 21 Oct 2024 17:20:15 GMT, Sean Mullan wrote:
> > There are a couple of micro benchmarks in test/micro that fork with
> > `jvmArgsPrepend={"-Djava.security.manager=allow"})`, they will need to be
> > examined.
>
> Fixed, will be in next drop. There are a couple of other micro tests that
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Tue, 22 Oct 2024 21:30:40 GMT, Erik Joelsson wrote:
> The target mac-jdk-bundle can fail randomly. MacBundles.gmk defines a large
> number of individual copy rules, which can execute in any order. The
> "install-file" (our copy) macro on macos includes a check for weird
> attributes using `
On Mon, 21 Oct 2024 14:34:30 GMT, Julian Waters wrote:
> After 8339120, gcc began catching many different instances of unused code in
> the Windows specific codebase. Some of these seem to be bugs. I've taken the
> effort to mark out all the relevant globals and locals that trigger the
> unuse
On Tue, 22 Oct 2024 21:30:40 GMT, Erik Joelsson wrote:
> The target mac-jdk-bundle can fail randomly. MacBundles.gmk defines a large
> number of individual copy rules, which can execute in any order. The
> "install-file" (our copy) macro on macos includes a check for weird
> attributes using `
On Wed, 23 Oct 2024 07:23:44 GMT, Lutz Schmidt wrote:
>> The target mac-jdk-bundle can fail randomly. MacBundles.gmk defines a large
>> number of individual copy rules, which can execute in any order. The
>> "install-file" (our copy) macro on macos includes a check for weird
>> attributes usin
On Wed, 23 Oct 2024 08:10:38 GMT, Jatin Bhateja wrote:
>> Hi all,
>> This patch adds a new pass to consolidate lowering of complex
>> backend-specific code patterns, such as `MacroLogicV` and the optimization
>> proposed by #21244. Moving these optimizations to backend code can simplify
>> sha
On Tue, 22 Oct 2024 21:30:40 GMT, Erik Joelsson wrote:
> The target mac-jdk-bundle can fail randomly. MacBundles.gmk defines a large
> number of individual copy rules, which can execute in any order. The
> "install-file" (our copy) macro on macos includes a check for weird
> attributes using `
On Wed, 23 Oct 2024 17:28:25 GMT, Quan Anh Mai wrote:
>> src/hotspot/share/opto/compile.cpp line 2466:
>>
>>> 2464: print_method(PHASE_BEFORE_LOWERING, 3);
>>> 2465:
>>> 2466: PhaseLowering lower(&igvn);
>>
>> Any specific reason to have lowering after loop optimizations ?
>> Lowered n
On Tue, 22 Oct 2024 21:30:40 GMT, Erik Joelsson wrote:
> The target mac-jdk-bundle can fail randomly. MacBundles.gmk defines a large
> number of individual copy rules, which can execute in any order. The
> "install-file" (our copy) macro on macos includes a check for weird
> attributes using `
On Wed, 23 Oct 2024 12:32:44 GMT, Erik Joelsson wrote:
>> make/common/FileUtils.gmk line 141:
>>
>>> 139: $(CHMOD) -h u+w '$(call DecodeSpace, $@)'; \
>>> 140: $(XATTR) -cs '$(call DecodeSpace, $@)'; \
>>> 141:fi
>>
>> What about running chmod only against real files?
On Wed, 23 Oct 2024 11:54:39 GMT, Alan Bateman wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNote to d
On Wed, 23 Oct 2024 05:11:19 GMT, Prasanta Sadhukhan
wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNo
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Wed, 23 Oct 2024 12:44:53 GMT, Coleen Phillimore wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNote
On Wed, 23 Oct 2024 05:23:39 GMT, Julian Waters wrote:
>> src/jdk.jdwp.agent/share/native/libjdwp/log_messages.c line 53:
>>
>>> 51: #ifndef _WIN32
>>> 52: static MUTEX_T my_mutex = MUTEX_INIT;
>>> 53: #endif
>>
>> The reason for no reference on windows is because of the following on
>> window
On Wed, 23 Oct 2024 05:22:45 GMT, Julian Waters wrote:
>> src/jdk.jdi/windows/native/libdt_shmem/shmem_md.c line 47:
>>
>>> 45: {
>>> 46: void *mappedMemory;
>>> 47: // HANDLE memHandle;
>>
>> Why comment out this one but not the one at line 88? It seems they are both
>> equally problemat
On Wed, 23 Oct 2024 21:20:45 GMT, Magnus Ihse Bursie wrote:
> > I'm not sure that error was caused by this issue. That would imply that I
> > had strange file attributes on files in my build directory, and I don't
> > think I do.
>
> I can't see what else did. I think the strange attributes ar
On Wed, 23 Oct 2024 12:14:24 GMT, Alan Bateman wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNote to d
On Wed, 23 Oct 2024 17:26:35 GMT, Erik Joelsson wrote:
> I'm not sure that error was caused by this issue. That would imply that I had
> strange file attributes on files in my build directory, and I don't think I
> do.
I can't see what else did. I think the strange attributes are injected a b
On Tue, 22 Oct 2024 21:36:06 GMT, Mandy Chung wrote:
> Reviewed test/jdk/java/lang/** and test/jdk/sun/reflect/* tests.
Thanks for the comprehensive review. I have incorporated all of your comments
except for removing the enum from
`java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java`
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Tue, 22 Oct 2024 13:53:03 GMT, Thomas Stuefe wrote:
>> I will do some benchmarks
>
> I did SpecJBB runs with shift of 6, 8 and 10, respectively, which amounts to
> Klass alignment of 64, 256 and 1K. Benchmark scores did not show a
> significant pattern. I did not measure CPU stats though.
>
On Wed, 23 Oct 2024 19:38:10 GMT, Harshitha Onkar wrote:
>> test/jdk/javax/imageio/CachePremissionsTest/CachePermissionsTest.java line
>> 76:
>>
>>> 74: System.out.println("java.io.tmpdir is " +
>>> System.getProperty("java.io.tmpdir"));
>>> 75:
>>> 76: if (args.length > 1) {
On Wed, 23 Oct 2024 05:11:19 GMT, Prasanta Sadhukhan
wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNo
On Wed, 23 Oct 2024 12:53:12 GMT, Alan Bateman wrote:
>> src/hotspot/share/prims/jvm.cpp line 1272:
>>
>>> 1270:
>>> 1271:
>>> 1272: // Returns the inherited_access_control_context field of the running
>>> thread.
>>
>> There's some code in this file in
>> static void trace_class_resolution
On Mon, 21 Oct 2024 21:12:29 GMT, Phil Race wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNote to depr
On Tue, 22 Oct 2024 16:22:20 GMT, Roman Kennke wrote:
> @egahlin / @mgronlun could you please review the JFR parts of this PR? One
> change is for getting the right prototype header, the other is for avoiding
> an endless loop/assert in a corner case.
JFR changes look reasonable.
On Tue, 22 Oct 2024 16:19:24 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Mon, 21 Oct 2024 06:11:26 GMT, Quan Anh Mai wrote:
>> Jasmine Karthikeyan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address some changes from code review
>
> src/hotspot/share/opto/phaseX.cpp line 2277:
>
>> 2275:
>> 2276: /
On Wed, 23 Oct 2024 17:39:22 GMT, Quan Anh Mai wrote:
>> Because lowering is a transformation that increases the complexity of the
>> graph.
>>
>> - A `d = ExtractD(z, 4)` expanded into `x = VectorExtract(z, 2); d =
>> ExtractD(x, 0)` increases the number of nodes by 1.
>> - A logic cone tran
On Wed, 23 Oct 2024 07:57:05 GMT, Jatin Bhateja wrote:
>> Jasmine Karthikeyan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address some changes from code review
>
> src/hotspot/share/opto/phaseX.cpp line 2301:
>
>> 2299: while(_igv
On Fri, 30 Aug 2024 07:37:35 GMT, Thomas Stuefe wrote:
>> make/Images.gmk line 135:
>>
>>> 133: #
>>> 134: # Param1 - VM variant (e.g., server, client, zero, ...)
>>> 135: # Param2 - _nocoops, _coh, _nocoops_coh, or empty
>>
>> The -XX:+UseCompactObjectHeaders ssems to incompatible withe zero v
> Hi all,
> This patch adds a new pass to consolidate lowering of complex
> backend-specific code patterns, such as `MacroLogicV` and the optimization
> proposed by #21244. Moving these optimizations to backend code can simplify
> shared code, while also making it easier to develop more in-depth
On Thu, 24 Oct 2024 02:13:20 GMT, Jasmine Karthikeyan
wrote:
> I think we shouldn't run `Ideal` on the graph, because there is a chance that
> it could undo the lowering changes that we just did. This gives lowering more
> freedom to change the graph in different ways that would otherwise be u
On Mon, 21 Oct 2024 12:55:39 GMT, Magnus Ihse Bursie wrote:
>> Jasmine Karthikeyan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address some changes from code review
>
> Build changes look good (but would be slightly better without th
On Mon, 21 Oct 2024 14:34:30 GMT, Julian Waters wrote:
> After 8339120, gcc began catching many different instances of unused code in
> the Windows specific codebase. Some of these seem to be bugs. I've taken the
> effort to mark out all the relevant globals and locals that trigger the
> unuse
On Wed, 23 Oct 2024 16:51:23 GMT, Chris Plummer wrote:
>> I wasn't sure whether the global memHandle not being used was a bug, so I
>> commented out the local one. I missed the line 88 one because it wasn't
>> flagged. If it really isn't needed I'll remove that one instead
>
> I'm not sure what
On Thu, 24 Oct 2024 03:31:31 GMT, Julian Waters wrote:
>> I'm not sure what you mean by "that one". It's the static one that should be
>> removed. The local variables always hide the static, and there seems to be
>> no reason for the value of memHandle to survive outside of the local scope
>>
46 matches
Mail list logo
