On Mon, 21 Oct 2024 12:55:39 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Jasmine Karthikeyan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address some changes from code review > > Build changes look good (but would be slightly better without the extra blank > line). I have not reviewed the actual hotspot changes. Thanks for looking at the build changes, @magicus! I've pushed a commit that removes the extra newline in the makefiles and adds newlines to the ends of files that were missing them. Thanks for taking a look as well, @merykitty and @jatin-bhateja! I've pushed a commit that should address the code suggestions and left some comments as well. ------------- PR Comment: https://git.openjdk.org/jdk/pull/21599#issuecomment-2434090294
