Re: RFR: 8337283: configure.log is truncated when build dir is on different filesystem

2024-08-05 Thread Magnus Ihse Bursie
On Fri, 26 Jul 2024 16:21:33 GMT, Aleksey Shipilev wrote: > I noticed that `build/$confname/configure.log` was truncated on some of my > build nodes. Turns out, we are moving configure.log from tree root to that > place a bit prematurely. > > We move `configure.log` here: > https://github.com/

Re: RFR: 8336928: GHA: Bundle artifacts removal broken [v2]

2024-08-05 Thread Magnus Ihse Bursie
On Mon, 22 Jul 2024 20:41:52 GMT, Zdenek Zambersky wrote: >> GHA code, which tries to remove bundle artifacts no longer works. It >> probably broke after >> [JDK-8324723](https://bugs.openjdk.org/browse/JDK-8324723) (GHA: Upgrade >> some actions to avoid deprecated Node 16). >> >> **Details:*

Re: RFR: 8336849: Remove .llvm_addrsig section from JDK/VM static libraries (.a files)

2024-08-05 Thread Magnus Ihse Bursie
On Sat, 20 Jul 2024 00:20:19 GMT, Jiangli Zhou wrote: > Please review this PR that strips the `.llvm_addrsig` section from JDK and > hotspot `.a` static libraries when building with clang. Please see > https://bugs.openjdk.org/browse/JDK-8336849 description for details. I'm back from vacation

RFR: 8337819: Update GHA JDKs to 22.0.2

2024-08-05 Thread Christoph Langer
Currently, we use JDK 22 GA binaries in Github Actions. Since JDK 22.0.2 is available in the meanwhile, we can use it. I also correct the alphabetical ordering of the macOS platforms. - Commit messages: - JDK-8337819 Changes: https://git.openjdk.org/jdk/pull/20467/files Webrev:

RE: Add "Windows aarch64" to Supported Build Platforms

2024-08-05 Thread Baesken, Matthias
Hi Brian , if you give me the detailled info I can add it . Best regards, Matthias -- Hello, We would like to add Microsoft as the maintainer of Windows aarch64 to the Supported Build Platforms[1] page (JDK versions 11/17/21

Re: RFR: 8335880: More troubleshooting tips around windows space in path [v3]

2024-08-05 Thread Magnus Ihse Bursie
On Tue, 16 Jul 2024 23:20:03 GMT, Chen Liang wrote: >> Context: https://mail.openjdk.org/pipermail/build-dev/2024-July/045586.html >> >> People were confused on a few details around fixing windows space names, >> including: >> 1. setshortname can report confusing error message when the director

Re: RFR: 8335880: More troubleshooting tips around windows space in path [v3]

2024-08-05 Thread Magnus Ihse Bursie
On Tue, 16 Jul 2024 23:20:03 GMT, Chen Liang wrote: >> Context: https://mail.openjdk.org/pipermail/build-dev/2024-July/045586.html >> >> People were confused on a few details around fixing windows space names, >> including: >> 1. setshortname can report confusing error message when the director

Re: RFR: 8337819: Update GHA JDKs to 22.0.2

2024-08-05 Thread Matthias Baesken
On Mon, 5 Aug 2024 12:30:25 GMT, Christoph Langer wrote: > Currently, we use JDK 22 GA binaries in Github Actions. Since JDK 22.0.2 is > available in the meanwhile, we can use it. I also correct the alphabetical > ordering of the macOS platforms. Marked as reviewed by mbaesken (Reviewer). ---

Re: RFR: 8336928: GHA: Bundle artifacts removal broken [v2]

2024-08-05 Thread Zdenek Zambersky
On Mon, 5 Aug 2024 12:08:38 GMT, Magnus Ihse Bursie wrote: >> Zdenek Zambersky has updated the pull request incrementally with one >> additional commit since the last revision: >> >> reintroduce -s flag > > The code looks sane. Have you been able to test this? (Trying out GHA changes > is so

Re: RFR: 8337819: Update GHA JDKs to 22.0.2

2024-08-05 Thread Magnus Ihse Bursie
On Mon, 5 Aug 2024 12:30:25 GMT, Christoph Langer wrote: > Currently, we use JDK 22 GA binaries in Github Actions. Since JDK 22.0.2 is > available in the meanwhile, we can use it. I also correct the alphabetical > ordering of the macOS platforms. Marked as reviewed by ihse (Reviewer). ---

Re: RFR: 8336928: GHA: Bundle artifacts removal broken [v2]

2024-08-05 Thread Magnus Ihse Bursie
On Mon, 22 Jul 2024 20:41:52 GMT, Zdenek Zambersky wrote: >> GHA code, which tries to remove bundle artifacts no longer works. It >> probably broke after >> [JDK-8324723](https://bugs.openjdk.org/browse/JDK-8324723) (GHA: Upgrade >> some actions to avoid deprecated Node 16). >> >> **Details:*

Re: RFR: 8336928: GHA: Bundle artifacts removal broken [v2]

2024-08-05 Thread duke
On Mon, 22 Jul 2024 20:41:52 GMT, Zdenek Zambersky wrote: >> GHA code, which tries to remove bundle artifacts no longer works. It >> probably broke after >> [JDK-8324723](https://bugs.openjdk.org/browse/JDK-8324723) (GHA: Upgrade >> some actions to avoid deprecated Node 16). >> >> **Details:*

Re: RFR: 8336928: GHA: Bundle artifacts removal broken [v2]

2024-08-05 Thread Zdenek Zambersky
On Mon, 5 Aug 2024 13:44:28 GMT, Magnus Ihse Bursie wrote: >> Zdenek Zambersky has updated the pull request incrementally with one >> additional commit since the last revision: >> >> reintroduce -s flag > > Great, thanks! The build system does not need a secondary review so you are > free to

Re: RFR: 8337283: configure.log is truncated when build dir is on different filesystem

2024-08-05 Thread Aleksey Shipilev
On Fri, 26 Jul 2024 16:21:33 GMT, Aleksey Shipilev wrote: > I noticed that `build/$confname/configure.log` was truncated on some of my > build nodes. Turns out, we are moving configure.log from tree root to that > place a bit prematurely. > > We move `configure.log` here: > https://github.com/

Integrated: 8337283: configure.log is truncated when build dir is on different filesystem

2024-08-05 Thread Aleksey Shipilev
On Fri, 26 Jul 2024 16:21:33 GMT, Aleksey Shipilev wrote: > I noticed that `build/$confname/configure.log` was truncated on some of my > build nodes. Turns out, we are moving configure.log from tree root to that > place a bit prematurely. > > We move `configure.log` here: > https://github.com/

Re: RFR: 8337819: Update GHA JDKs to 22.0.2

2024-08-05 Thread Aleksey Shipilev
On Mon, 5 Aug 2024 12:30:25 GMT, Christoph Langer wrote: > Currently, we use JDK 22 GA binaries in Github Actions. Since JDK 22.0.2 is > available in the meanwhile, we can use it. I also correct the alphabetical > ordering of the macOS platforms. Marked as reviewed by shade (Reviewer). --

Integrated: 8336928: GHA: Bundle artifacts removal broken

2024-08-05 Thread Zdenek Zambersky
On Mon, 22 Jul 2024 20:26:50 GMT, Zdenek Zambersky wrote: > GHA code, which tries to remove bundle artifacts no longer works. It probably > broke after [JDK-8324723](https://bugs.openjdk.org/browse/JDK-8324723) (GHA: > Upgrade some actions to avoid deprecated Node 16). > > **Details:** > Seems

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v2]

2024-08-05 Thread Magnus Ihse Bursie
On Fri, 26 Jul 2024 19:40:24 GMT, Brian Burkhalter wrote: >> This proposed change would move the native objects required for NIO file >> interaction from the libnio native library to the libjava native library on >> Linux, macOS, and Windows. > > Brian Burkhalter has updated the pull request in

Re: RFR: 8336498: [macos] [build]: install-file macro may run into permission denied error

2024-08-05 Thread Magnus Ihse Bursie
On Tue, 16 Jul 2024 20:50:32 GMT, Lutz Schmidt wrote: > On MacOS, files may have extended attributes attached. These attributes are > copied together with the files. To prevent issues during further processing, > the extended attributes of the copies must be removed. This action was > implemen

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v2]

2024-08-05 Thread Brian Burkhalter
On Mon, 5 Aug 2024 15:19:33 GMT, Magnus Ihse Bursie wrote: > This will introduce a source code dependency from libjava to libnio. It might > be the correct thing to do, but I just want to highlight this. I'll look into improving it. > make/modules/java.base/lib/CoreLibraries.gmk line 71: > >>

Re: RFR: 8329471: Remove GTK2 [v5]

2024-08-05 Thread Magnus Ihse Bursie
On Wed, 31 Jul 2024 19:17:05 GMT, Alexander Zvegintsev wrote: >> GTK2 support for Swing/AWT was deprecated for removal in JDK 21. >> >> It's being removed because no platform that supports the JDK needs it. >> >> Manual and automated testing is green. > > Alexander Zvegintsev has updated the

Re: RFR: 8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags

2024-08-05 Thread Magnus Ihse Bursie
On Mon, 5 Aug 2024 15:48:44 GMT, Magnus Ihse Bursie wrote: >> There jtreg tests have several additional problemlists >> ProblemList-Xcomp.txt >> ProblemList-generational-zgc.txt >> ProblemList-zgc.txt >> Each of them is bound to corresponding execution mode (Xcomp/ZGC) and it >> makes sense to

Re: RFR: 8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags

2024-08-05 Thread Magnus Ihse Bursie
On Thu, 1 Aug 2024 18:26:55 GMT, Leonid Mesnik wrote: > There jtreg tests have several additional problemlists > ProblemList-Xcomp.txt > ProblemList-generational-zgc.txt > ProblemList-zgc.txt > Each of them is bound to corresponding execution mode (Xcomp/ZGC) and it > makes sense to treat them

Re: RFR: 8335880: More troubleshooting tips around windows space in path [v3]

2024-08-05 Thread Chen Liang
On Mon, 5 Aug 2024 12:47:52 GMT, Magnus Ihse Bursie wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update html > > doc/building.md line 1816: > >> 1814: The only directories required to have short paths are `Micros

Re: RFR: 8335880: More troubleshooting tips around windows space in path [v3]

2024-08-05 Thread Magnus Ihse Bursie
On Mon, 5 Aug 2024 15:55:12 GMT, Chen Liang wrote: >> doc/building.md line 1816: >> >>> 1814: The only directories required to have short paths are `Microsoft >>> Visual Studio` >>> 1815: and `Windows Kits`; the rest of the "contains space" warnings from >>> `configure` >>> 1816: can be ignore

Re: RFR: 8336849: Remove .llvm_addrsig section from JDK/VM static libraries (.a files)

2024-08-05 Thread Jiangli Zhou
On Sat, 20 Jul 2024 00:20:19 GMT, Jiangli Zhou wrote: > Please review this PR that strips the `.llvm_addrsig` section from JDK and > hotspot `.a` static libraries when building with clang. Please see > https://bugs.openjdk.org/browse/JDK-8336849 description for details. Thanks for looking into

RE: Add "Windows aarch64" to Supported Build Platforms

2024-08-05 Thread Brian Stafford
Hi Matthias, Thank you for your assistance. Here are the details: Platform: Windows aarch64 Status: Works correctly (Green star) OS Type/Vendor: Microsoft Windows Server Datacenter Azure Edition OS Version: 2025 Compiler/Toolchain Type/Vendor: Microsoft Visual Studio Compiler/Toolchain Version

Re: RFR: 8337819: Update GHA JDKs to 22.0.2

2024-08-05 Thread Christoph Langer
On Mon, 5 Aug 2024 12:30:25 GMT, Christoph Langer wrote: > Currently, we use JDK 22 GA binaries in Github Actions. Since JDK 22.0.2 is > available in the meanwhile, we can use it. I also correct the alphabetical > ordering of the macOS platforms. Thanks for the reviews. All GHA tests went gree

Integrated: 8337819: Update GHA JDKs to 22.0.2

2024-08-05 Thread Christoph Langer
On Mon, 5 Aug 2024 12:30:25 GMT, Christoph Langer wrote: > Currently, we use JDK 22 GA binaries in Github Actions. Since JDK 22.0.2 is > available in the meanwhile, we can use it. I also correct the alphabetical > ordering of the macOS platforms. This pull request has now been integrated. Cha

Re: RFR: 8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags [v2]

2024-08-05 Thread Leonid Mesnik
On Mon, 5 Aug 2024 15:49:07 GMT, Magnus Ihse Bursie wrote: >> make/RunTests.gmk line 845: >> >>> 843: ifneq ($$(findstring -Xcomp, $$(JTREG_ALL_OPTIONS)), ) >>> 844: JTREG_AUTO_PROBLEM_LISTS := $$(JTREG_AUTO_PROBLEM_LISTS) >>> ProblemList-Xcomp.txt >>> 845: JTREG_AUTO_TIMEOUT_FACTOR ?

Re: RFR: 8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags [v2]

2024-08-05 Thread Leonid Mesnik
> There jtreg tests have several additional problemlists > ProblemList-Xcomp.txt > ProblemList-generational-zgc.txt > ProblemList-zgc.txt > Each of them is bound to corresponding execution mode (Xcomp/ZGC) and it > makes sense to treat them like standard problemlist when tests are executed > wit

Re: RFR: 8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags [v2]

2024-08-05 Thread Leonid Mesnik
On Mon, 5 Aug 2024 15:51:04 GMT, Magnus Ihse Bursie wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> makefile updated. > > make/RunTests.gmk line 849: > >> 847: >> 848: ifneq ($$(findstring -XX:+UseZGC, $$(JTRE

Re: RFR: 8336498: [macos] [build]: install-file macro may run into permission denied error

2024-08-05 Thread Lutz Schmidt
On Mon, 5 Aug 2024 15:25:32 GMT, Magnus Ihse Bursie wrote: > Hi, I'm back from vacation now. Looks like we are taking turns. Now I'm on vacation. Thorough analysis of why the issue pops up occasionally will have to wait until I'm back (Aug 19th). I have no specific idea in which direction I sh

Re: RFR: 8329816: Add SLEEF version 3.6.1

2024-08-05 Thread Hamlin Li
On Thu, 27 Jun 2024 21:59:30 GMT, Mikael Vidstedt wrote: >> In case you need it and avoid to generate yourself, I've generated sleef >> inline header of 3.6.1 for riscv, it's at >> https://github.com/openjdk/jdk/pull/18605/commits/c279a3c290554892939267d9ebe88198988d31a4 > > @Hamlin-Li I have g