On Mon, 5 Aug 2024 15:49:07 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> make/RunTests.gmk line 845: >> >>> 843: ifneq ($$(findstring -Xcomp, $$(JTREG_ALL_OPTIONS)), ) >>> 844: JTREG_AUTO_PROBLEM_LISTS := $$(JTREG_AUTO_PROBLEM_LISTS) >>> ProblemList-Xcomp.txt >>> 845: JTREG_AUTO_TIMEOUT_FACTOR ?= 10 >> >> Since you assign this to be 4 a couple of lines up, this code will never do >> anything. > > Did you test that this patch works as intended? Thanks for catching. Yes, the problem is that our system always set timeout factor. So now I also run manual testing using make to verify that correct factor is used. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20430#discussion_r1704491943
