Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v9]

2024-07-10 Thread Ludovic Henry
On Mon, 8 Jul 2024 16:40:50 GMT, Andrew Haley wrote: >> Hamlin Li has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains 33 commits: >> >> - Merge branch 'master' into sleef-aarch64-integrate-source >> - merge master >> - sleef 3.6.1

Running Tests: do I need to build GTest separately?

2024-07-10 Thread Anil
This, in the docs is unclear to me: Building of Hotspot Gtest suite requires the source code of Google Test > framework. The top directory, which contains both googletest and > googlemock directories, should be specified via --with-gtest Building the JDK (openjdk.org)

Re: Running Tests: do I need to build GTest separately?

2024-07-10 Thread Julian Waters
Hi Anil, No, you do not need to compile gtest manually. Just point --with-gtest to the directory that contains the googlemock and googletest directories. I do not believe you can use a precompiled gtest for this. I'd also suggest having jtreg and googletest outside the JDK source directory best r

Re: Running Tests: do I need to build GTest separately?

2024-07-10 Thread Anil
Thank you for your reply. [Julian] "Just point --with-gtest" at what stage? "bash configure", or "make images" or "make test-tier1"? $ bash configure --with-jtreg=/cygdrive/c/users/anil/OpenJDK/jtreg-7.4+1/jtreg --with-gtest=/cygdrive/c/users/anil/OpenJDK/googletest On Wed, Jul 10, 2024 at 10

Re: Running Tests: do I need to build GTest separately?

2024-07-10 Thread Julian Waters
--with-gtest is only available during bash configure, so when you run bash configure best regards, Julian On Thu, Jul 11, 2024 at 12:00 AM Anil <1dropafl...@gmail.com> wrote: > > Thank you for your reply. > [Julian] "Just point --with-gtest" > at what stage? > "bash configure", or "make images" o

Re: Running Tests: do I need to build GTest separately?

2024-07-10 Thread Anil
I do not have a project role (signed the contributor agreement just now) but I would like to submit a minor documentation bug because it should clearly state that gtest should be at the bash configure stage. example: $ bash configure --with-jtreg=/cygdrive/c/users/anil/OpenJDK/jtreg-7.4+1/jtreg --

RFR: 8325369: @sealedGraph: Bad link to image for tag on nested classes

2024-07-10 Thread Chen Liang
Fixes the link to the generated sealed graph svg generated by the sealed graph taglet. Affected interfaces includes `ClassFile.Option`, `AnnotationValue.OfConstant`, a few nested interfaces in `Signature`, and `TypeAnnotaton.TargetInfo`. - Commit messages: - 8325369: @sealedGraph:

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v9]

2024-07-10 Thread Andrew Haley
On Mon, 8 Jul 2024 16:40:50 GMT, Andrew Haley wrote: >> Hamlin Li has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains 33 commits: >> >> - Merge branch 'master' into sleef-aarch64-integrate-source >> - merge master >> - sleef 3.6.1

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v9]

2024-07-10 Thread Hamlin Li
On Mon, 8 Jul 2024 16:20:40 GMT, Andrew Haley wrote: > I finally did some measurements. Thanks for testing it! > It would be nice if the JMH test were part of this patch. OK, I can do that later. > > It mostly looks good, but I can see an odd regression of DoubleMaxVector.TANH > (by 39%) o

Re: RFR: 8325369: @sealedGraph: Bad link to image for tag on nested classes

2024-07-10 Thread Jonathan Gibbons
On Wed, 10 Jul 2024 18:57:22 GMT, Chen Liang wrote: > Fixes the link to the generated sealed graph svg generated by the sealed > graph taglet. > > Affected interfaces includes > [`ClassFile.Option`](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8325369-nested-sealed-svg/api/java.base/java/lan

Issue cross-compiling idk 8 for powerpc

2024-07-10 Thread Kurt Stine
Hi Everyone, I’m running into an issue when trying to cross-compile the latest jdk8u for powerpc (32 bit). I am cross-compiling from x86_64 with Azul Zulu JDK 7 as my boot JDK. Whenever I try and run "bash configure --openjdk-target=powerpc-linux --with-jvm-variants=zero", configure results in