On Fri, 5 Apr 2024 12:17:17 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>>
>> Compared with previous
On Fri, 5 Apr 2024 09:56:48 GMT, Magnus Ihse Bursie wrote:
> This is the pinnacle of the recent stream of refactorings in the build
> system. This patch introduces a more abstract concept of "JDK_LIBS", where
> only the library name (e.g. "java" or "java.desktop:jawt") is specified, and
> the
> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
> clang by another name, and it uses the clang toolchain in the JDK build. Thus
> the old xlc toolchain was removed by
> [JDK-8327701](https:/
On Wed, 10 Apr 2024 11:32:43 GMT, Daniel Jeliński wrote:
> The "Connection attempt failed: Connection refused" error may happen if the
> client tries to connect to a server that is no longer listening, which in
> turn may happen if the server shuts down without removing the port file. I
> adde
> Hi,
> Can you help to review the patch?
> This pr is based on previous work and discussion in [pr
> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
> 18294](https://github.com/openjdk/jdk/pull/18294).
>
> Compared with previous prs, the major change in this pr is to integrate the
> sou
On Tue, 9 Apr 2024 20:10:36 GMT, Mikael Vidstedt wrote:
>> Hamlin Li has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - disable unused-function warnings; add log msg
>> - minor
>
> Thank you for the update and for working on this in gene
On Tue, 9 Apr 2024 19:43:27 GMT, Erik Joelsson wrote:
> Since we are now able to update the autoconf build-aux files, I think it's
> prudent to semi regularly do just that. I'm not aware of any particular
> platform that has been improved that would affect OpenJDK and I don't think
> we can fu
On Thu, 11 Apr 2024 10:36:03 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>>
>> Compared with previous
> This is part of a general "spring cleaning" of the build system, addressing
> old code that has bit-rotted, been subject to lava flow, or just had bad or
> smelly code that we've never gotten around to fix.
>
> This particular patch tries to make MakeBase truly minimal; only including
> the c
On Thu, 11 Apr 2024 10:36:03 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr
>> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
>> 18294](https://github.com/openjdk/jdk/pull/18294).
>>
>> Compared with previous
> This is part of a general "spring cleaning" of the build system, addressing
> old code that has bit-rotted, been subject to lava flow, or just had bad or
> smelly code that we've never gotten around to fix.
>
> This particular patch tries to make MakeBase truly minimal; only including
> the c
> This is part of a general "spring cleaning" of the build system, addressing
> old code that has bit-rotted, been subject to lava flow, or just had bad or
> smelly code that we've never gotten around to fix.
>
> This particular patch tries to make MakeBase truly minimal; only including
> the c
> This is part of a general "spring cleaning" of the build system, addressing
> old code that has bit-rotted, been subject to lava flow, or just had bad or
> smelly code that we've never gotten around to fix.
>
> This particular patch tries to make MakeBase truly minimal; only including
> the c
On Wed, 10 Apr 2024 11:32:43 GMT, Daniel Jeliński wrote:
> The "Connection attempt failed: Connection refused" error may happen if the
> client tries to connect to a server that is no longer listening, which in
> turn may happen if the server shuts down without removing the port file. I
> adde
On Wed, 10 Apr 2024 11:32:43 GMT, Daniel Jeliński wrote:
> The "Connection attempt failed: Connection refused" error may happen if the
> client tries to connect to a server that is no longer listening, which in
> turn may happen if the server shuts down without removing the port file. I
> adde
> This is part of a general "spring cleaning" of the build system, addressing
> old code that has bit-rotted, been subject to lava flow, or just had bad or
> smelly code that we've never gotten around to fix.
>
> This particular patch tries to make MakeBase truly minimal; only including
> the c
> This is part of a general "spring cleaning" of the build system, addressing
> old code that has bit-rotted, been subject to lava flow, or just had bad or
> smelly code that we've never gotten around to fix.
>
> This particular patch tries to make MakeBase truly minimal; only including
> the c
On Thu, 11 Apr 2024 12:48:01 GMT, Magnus Ihse Bursie wrote:
>> This is part of a general "spring cleaning" of the build system, addressing
>> old code that has bit-rotted, been subject to lava flow, or just had bad or
>> smelly code that we've never gotten around to fix.
>>
>> This particular
The file to build most of the java.desktop native libraries, t
Awt2dLibraries.gmk, is large and unstructured, making it hard to navigate.
I want to split it into two parts, one for the AWT libraries, and one for the
2D libraries. I also used this opportunity to change the order to be more
logic
On Thu, 11 Apr 2024 13:53:23 GMT, Magnus Ihse Bursie wrote:
> The file to build most of the java.desktop native libraries, t
> Awt2dLibraries.gmk, is large and unstructured, making it hard to navigate.
>
> I want to split it into two parts, one for the AWT libraries, and one for the
> 2D libra
On Thu, 11 Apr 2024 13:53:23 GMT, Magnus Ihse Bursie wrote:
> The file to build most of the java.desktop native libraries, t
> Awt2dLibraries.gmk, is large and unstructured, making it hard to navigate.
>
> I want to split it into two parts, one for the AWT libraries, and one for the
> 2D libra
On Wed, 28 Feb 2024 11:24:06 GMT, Magnus Ihse Bursie wrote:
> This is part of a general "spring cleaning" of the build system, addressing
> old code that has bit-rotted, been subject to lava flow, or just had bad or
> smelly code that we've never gotten around to fix.
>
> This particular patch
On Tue, 9 Apr 2024 19:43:27 GMT, Erik Joelsson wrote:
> Since we are now able to update the autoconf build-aux files, I think it's
> prudent to semi regularly do just that. I'm not aware of any particular
> platform that has been improved that would affect OpenJDK and I don't think
> we can fu
On Wed, 10 Apr 2024 18:02:38 GMT, Volodymyr Paprotski wrote:
> > In `ECOperations.java`, if I understand this correctly, it is to replace
> > the existing `PointMultiplier` with montgomery-based PointMuliplier. But
> > when I look at the code, I see both are still options. If I read this
> > c
On Tue, 9 Apr 2024 08:53:10 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> add support for JDK-8329296: Update Elements for '///' documentation
>> comments
>
> src/jdk.compiler/share/classes/
> Please review a patch to add support for Markdown syntax in documentation
> comments, as described in the associated JEP.
>
> Notable features:
>
> * support for `///` documentation comments in `JavaTokenizer`
> * new module `jdk.internal.md` -- a private copy of the `commonmark-java`
> libra
> Please review the updates to support a proposed new
> `-Xlint:dangling-doc-comments` option.
>
> The work can be thought of as in 3 parts:
>
> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
> is possible to specify the appropriately configured `Lint` object when i
27 matches
Mail list logo
