On Wed, 3 Apr 2024 02:38:21 GMT, Julian Waters wrote:
> I will keep this open until the other Pull Request has been integrated, in
> case this might still be needed
I don't think it is necessary. You can always re-open a PR if it should be
needed, and you can look at source code and comments (
On Wed, 3 Apr 2024 03:10:26 GMT, Guoxiong Li wrote:
> Hi all,
>
> This patch merges the class `GenMarkSweep` into `MarkSweep`. Just simply
> move. It may be better to merge the class `DeadSpacer` and `Compacter` into
> `MarkSweep` and then rename `MarkSweep`. The `MarkSweep` will be renamed at
On Tue, 2 Apr 2024 19:19:59 GMT, Volodymyr Paprotski wrote:
>> Performance. Before:
>>
>> Benchmark(algorithm) (dataSize) (keyLength)
>> (provider) Mode Cnt ScoreError Units
>> SignatureBench.ECDSA.signSHA256withECDSA1024 256
>
On Mon, 1 Apr 2024 16:16:50 GMT, Mikael Vidstedt wrote:
> With the JDK 22 GA out it's time to bump the minimum boot JDK version for
> mainline/JDK 23.
>
> Testing: tier1-5, GHA
Marked as reviewed by ihse (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18563#pullrequestr
On Tue, 2 Apr 2024 16:14:12 GMT, Joachim Kern wrote:
>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
>> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
>> clang by another name, and it uses the clang toolchain in the JDK build.
>> Thus th
On Wed, 3 Apr 2024 03:10:26 GMT, Guoxiong Li wrote:
> Hi all,
>
> This patch merges the class `GenMarkSweep` into `MarkSweep`. Just simply
> move. It may be better to merge the class `DeadSpacer` and `Compacter` into
> `MarkSweep` and then rename `MarkSweep`. The `MarkSweep` will be renamed at
On Wed, 27 Mar 2024 22:04:30 GMT, Jonathan Gibbons wrote:
> Please review the updates to support a proposed new
> `-Xlint:dangling-doc-comments` option.
>
> The work can be thought of as in 3 parts:
>
> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
> is possible
On Wed, 3 Apr 2024 03:10:26 GMT, Guoxiong Li wrote:
> Hi all,
>
> This patch merges the class `GenMarkSweep` into `MarkSweep`. Just simply
> move. It may be better to merge the class `DeadSpacer` and `Compacter` into
> `MarkSweep` and then rename `MarkSweep`. The `MarkSweep` will be renamed at
Hi,
Can you help to review the patch?
This pr is based on previous work and discussion in [pr
16234](https://github.com/openjdk/jdk/pull/16234), [pr
18294](https://github.com/openjdk/jdk/pull/18294).
Compared with previous prs, the major change in this pr is to integrate the
source of sleef (fo
On Thu, 28 Mar 2024 18:41:03 GMT, Paul Sandoz wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix jni includes
>
> Hamlin, thank you for working on this. I think integrating a sub-set of SLEEF
> is valuable (not all
On Fri, 15 Mar 2024 13:58:05 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks
>>
>> This is a continuation of work based on [1] by @XiaohongGong, most work was
>> done in that pr. In this new pr, just rebased the code in [1], then added
>> some minor changes (renami
On Thu, 14 Mar 2024 08:48:11 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this patch?
> Thanks
>
> This is a continuation of work based on [1] by @XiaohongGong, most work was
> done in that pr. In this new pr, just rebased the code in [1], then added
> some minor changes (renaming of c
On Mon, 1 Apr 2024 16:16:50 GMT, Mikael Vidstedt wrote:
> With the JDK 22 GA out it's time to bump the minimum boot JDK version for
> mainline/JDK 23.
>
> Testing: tier1-5, GHA
This pull request has now been integrated.
Changeset: 023f7f17
Author:Mikael Vidstedt
URL:
https://git.o
On Mon, 1 Apr 2024 16:16:50 GMT, Mikael Vidstedt wrote:
> With the JDK 22 GA out it's time to bump the minimum boot JDK version for
> mainline/JDK 23.
>
> Testing: tier1-5, GHA
Thank you for the reviews!
-
PR Comment: https://git.openjdk.org/jdk/pull/18563#issuecomment-2035049134
On Wed, 3 Apr 2024 14:40:42 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review the patch?
> This pr is based on previous work and discussion in [pr
> 16234](https://github.com/openjdk/jdk/pull/16234), [pr
> 18294](https://github.com/openjdk/jdk/pull/18294).
>
> Compared with previous prs, th
On Tue, 19 Mar 2024 16:55:14 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Wed, 3 Apr 2024 09:56:42 GMT, Albert Mingkun Yang wrote:
>> Hi all,
>>
>> This patch merges the class `GenMarkSweep` into `MarkSweep`. Just simply
>> move. It may be better to merge the class `DeadSpacer` and `Compacter` into
>> `MarkSweep` and then rename `MarkSweep`. The `MarkSweep` will
On Wed, 3 Apr 2024 03:10:26 GMT, Guoxiong Li wrote:
> Hi all,
>
> This patch merges the class `GenMarkSweep` into `MarkSweep`. Just simply
> move. It may be better to merge the class `DeadSpacer` and `Compacter` into
> `MarkSweep` and then rename `MarkSweep`. The `MarkSweep` will be renamed at
18 matches
Mail list logo
