On Fri, 14 Mar 2025 15:49:44 GMT, Magnus Ihse Bursie wrote:
> We should allow pre-built JVMs to be included in a build, so they are just
> copied into place, and the jvm.cfg file properly updated.
`KEEPALIVE`
-
PR Comment: https://git.openjdk.org/jdk/pull/24063#issuecomment-281301
On Tue, 18 Mar 2025 13:12:16 GMT, Magnus Ihse Bursie wrote:
>> make/modules/java.base/Copy.gmk line 128:
>>
>>> 126: $(foreach import_jvm, $(IMPORT_JVM_NAMES), \
>>> 127: $(eval $(import_jvm)_path := $(patsubst $(import_jvm):%,%,$(filter
>>> $(import_jvm):%, $(IMPORT_JVMS \
>>> 128:
On Mon, 17 Mar 2025 09:10:50 GMT, Alan Bateman wrote:
> The discussion on jdk-dev was useful but I don't think adding
> --with-import-jvms is the right direction. It's too fragile and loose to
> import from a build created somewhere else.
Why's that? It's more loose than just "importing" a jtr
On Wed, 19 Mar 2025 12:45:23 GMT, Erik Joelsson wrote:
> Just to make sure I'm understanding you correctly. Are you proposing that
> instead of building a single JDK distribution with multiple JVMs, they would
> build a separate JDK for each alternative JVM configuration and publish
> java.bas
On Wed, 19 Mar 2025 09:11:05 GMT, Alan Bateman wrote:
> For the folks targeting embedded/small environments then I think the right
> thing is to publish the packaged modules (JMOD files) for the target platform
> and then use `jlink` to create the run-image with the right VM + small set of
> m
On Tue, 18 Mar 2025 12:31:27 GMT, Magnus Ihse Bursie wrote:
> And to be absolutely clear: this PR is just about adding new functionality
> that was not present before.
Sure but I think it's also an attractive nuisance. The VM is very tightly
coupled to java.base and a few other core modules. I
On Tue, 18 Mar 2025 13:09:10 GMT, Erik Joelsson wrote:
> If we want to support CDS archives for the imported JVMs, then we would need
> to modify the loop in Images.gmk so that it covers them as well. I think that
> makes sense to do.
Yes, I agree. That, and importing the whole directory, is t
On Fri, 14 Mar 2025 15:49:44 GMT, Magnus Ihse Bursie wrote:
> We should allow pre-built JVMs to be included in a build, so they are just
> copied into place, and the jvm.cfg file properly updated.
If we want to support CDS archives for the imported JVMs, then we would need to
modify the loop i
On Fri, 14 Mar 2025 15:49:44 GMT, Magnus Ihse Bursie wrote:
> We should allow pre-built JVMs to be included in a build, so they are just
> copied into place, and the jvm.cfg file properly updated.
make/modules/java.base/Copy.gmk line 128:
> 126: $(foreach import_jvm, $(IMPORT_JVM_NAMES), \
>
On Fri, 14 Mar 2025 15:49:44 GMT, Magnus Ihse Bursie wrote:
> We should allow pre-built JVMs to be included in a build, so they are just
> copied into place, and the jvm.cfg file properly updated.
And to be absolutely clear: this PR is just about adding new functionality that
was not present b
On Fri, 14 Mar 2025 15:49:44 GMT, Magnus Ihse Bursie wrote:
> We should allow pre-built JVMs to be included in a build, so they are just
> copied into place, and the jvm.cfg file properly updated.
For completeness/reference, this is my JDK frankensteining script that is used
for producing buil
On Fri, 14 Mar 2025 15:49:44 GMT, Magnus Ihse Bursie wrote:
> We should allow pre-built JVMs to be included in a build, so they are just
> copied into place, and the jvm.cfg file properly updated.
The discussion on jdk-dev was useful but I don't think adding
--with-import-jvms is the right dir
On Fri, 14 Mar 2025 17:57:31 GMT, Magnus Ihse Bursie wrote:
> No, it doesn't -- only libjvm.so. .jsa files complicate the situation. Hm.
Aha. Importing CDS archives without regenerating them is futile, IIRC: they
would never load properly, CDS would get disabled, and we would just carry dead
w
On Fri, 14 Mar 2025 16:32:39 GMT, Aleksey Shipilev wrote:
> This change copies `libjvm.so` _and_ sibling `.jsa` files, right?
No, it doesn't -- only libjvm.so. .jsa files complicate the situation. Hm.
Maybe we should point to an import JVM directory, and copy it with all its
files, and not jus
On Fri, 14 Mar 2025 17:58:50 GMT, Magnus Ihse Bursie wrote:
>> This change copies `libjvm.so` _and_ sibling `.jsa` files, right?
>>
>> If so, then one thing is missing: regenerating CDS archives that have
>> opinions on `modules` filesizes/dates for fingerprinting their CDS archives.
>> My fra
On Fri, 14 Mar 2025 15:49:44 GMT, Magnus Ihse Bursie wrote:
> We should allow pre-built JVMs to be included in a build, so they are just
> copied into place, and the jvm.cfg file properly updated.
This change copies `libjvm.so` _and_ sibling `.jsa` files, right?
If so, then one thing is missin
16 matches
Mail list logo
