On Thu, 20 Mar 2025 22:04:19 GMT, Alexander Zvegintsev
wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove AIX special handling from endian.h
>
> src/java.desktop/unix/native/libawt_xawt/awt/screencast_pipe
On Thu, 20 Mar 2025 22:19:47 GMT, Magnus Ihse Bursie wrote:
>> src/java.desktop/unix/native/libawt_xawt/awt/screencast_pipewire.c line 1104:
>>
>>> 1102: Java_sun_awt_screencast_ScreencastHelper_closeSession(JNIEnv *env,
>>> jclass cls) {
>>> 1103: }
>>> 1104:
>>
>> Suggestion:
>>
>>
>>
>>
On Fri, 21 Mar 2025 08:58:36 GMT, Matthias Baesken wrote:
>> Seems Wayland is not supported on AIX, so we most likely do not need to
>> build pipewire on AIX and can remove it from the build.
>> Reason is that pipewire updates can break the AIX build, so better avoid it
>> if possible.
>>
>> T
On Fri, 21 Mar 2025 08:58:36 GMT, Matthias Baesken wrote:
>> Seems Wayland is not supported on AIX, so we most likely do not need to
>> build pipewire on AIX and can remove it from the build.
>> Reason is that pipewire updates can break the AIX build, so better avoid it
>> if possible.
>>
>> T
On Fri, 21 Mar 2025 08:58:36 GMT, Matthias Baesken wrote:
>> Seems Wayland is not supported on AIX, so we most likely do not need to
>> build pipewire on AIX and can remove it from the build.
>> Reason is that pipewire updates can break the AIX build, so better avoid it
>> if possible.
>>
>> T
On Fri, 21 Mar 2025 08:58:36 GMT, Matthias Baesken wrote:
>> Seems Wayland is not supported on AIX, so we most likely do not need to
>> build pipewire on AIX and can remove it from the build.
>> Reason is that pipewire updates can break the AIX build, so better avoid it
>> if possible.
>>
>> T
On Fri, 21 Mar 2025 08:58:36 GMT, Matthias Baesken wrote:
>> Seems Wayland is not supported on AIX, so we most likely do not need to
>> build pipewire on AIX and can remove it from the build.
>> Reason is that pipewire updates can break the AIX build, so better avoid it
>> if possible.
>>
>> T
> Seems Wayland is not supported on AIX, so we most likely do not need to build
> pipewire on AIX and can remove it from the build.
> Reason is that pipewire updates can break the AIX build, so better avoid it
> if possible.
>
> To check if it works, I move the 'pipewire/include' folder away, an
On Thu, 20 Mar 2025 22:45:47 GMT, Magnus Ihse Bursie wrote:
>> I do not see a problem here, but in this case the
>> `Java_sun_awt_screencast_ScreencastHelper_getRGBPixelsImpl` is missing, as
>> the ScreencastHelper has 3 native methods.
>
> Ah, I see. I agree, that it makes more sense to either
On Thu, 20 Mar 2025 22:25:49 GMT, Alexander Zvegintsev
wrote:
>> To me it sounds like defensive programming to include an implementation of
>> all native methods, so the JVM will not crash if it mistakenly is called. Do
>> you see a problem with that?
>
> I do not see a problem here, but in th
On Thu, 13 Mar 2025 13:06:38 GMT, Matthias Baesken wrote:
>> Seems Wayland is not supported on AIX, so we most likely do not need to
>> build pipewire on AIX and can remove it from the build.
>> Reason is that pipewire updates can break the AIX build, so better avoid it
>> if possible.
>>
>> T
On Thu, 13 Mar 2025 20:00:33 GMT, Phil Race wrote:
> Looks right to me, but I will do a test build.
Was the test build successful ?
-
PR Comment: https://git.openjdk.org/jdk/pull/24009#issuecomment-2740436693
On Thu, 13 Mar 2025 13:06:38 GMT, Matthias Baesken wrote:
>> Seems Wayland is not supported on AIX, so we most likely do not need to
>> build pipewire on AIX and can remove it from the build.
>> Reason is that pipewire updates can break the AIX build, so better avoid it
>> if possible.
>>
>> T
On Thu, 13 Mar 2025 13:03:16 GMT, Matthias Baesken wrote:
>> Seems Wayland is not supported on AIX, so we most likely do not need to
>> build pipewire on AIX and can remove it from the build.
>> Reason is that pipewire updates can break the AIX build, so better avoid it
>> if possible.
>>
>> T
On Thu, 13 Mar 2025 09:29:38 GMT, Magnus Ihse Bursie wrote:
> Can you include a revert of JDK-8349751, which is not needed anymore after
> this change?
Okay I removed the AIX code from endian.h .
-
PR Comment: https://git.openjdk.org/jdk/pull/24009#issuecomment-2721177888
> Seems Wayland is not supported on AIX, so we most likely do not need to build
> pipewire on AIX and can remove it from the build.
> Reason is that pipewire updates can break the AIX build, so better avoid it
> if possible.
>
> To check if it works, I move the 'pipewire/include' folder away, an
On Wed, 12 Mar 2025 14:52:10 GMT, Matthias Baesken wrote:
> Seems Wayland is not supported on AIX, so we most likely do not need to build
> pipewire on AIX and can remove it from the build.
> Reason is that pipewire updates can break the AIX build, so better avoid it
> if possible.
>
> To chec
17 matches
Mail list logo
