On Thu, 1 May 2025 19:24:46 GMT, Vladimir Ivanov wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert log_warning change. Replace _adapter_caching check with flag check.
>
> Looks good.
Thank you again, @iwan
On Thu, 1 May 2025 17:10:17 GMT, Vladimir Ivanov wrote:
>> Thank you, @ashu-mehra. You have good points. I will work on them.
>
> FTR I suggested `!AOTCodeCache::is_dumping_adapters()` because that's the
> guarding check for `AOTCodeCache::store_code_blob()` call.
I will add assert message but
On Thu, 1 May 2025 18:53:38 GMT, Vladimir Kozlov wrote:
>> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
>> information in AOT cache which helps Java startup performance.
>>
>> We should also preserve adapters (i2c, c2i) to further improve performance
>> of class linki
> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
> information in AOT cache which helps Java startup performance.
>
> We should also preserve adapters (i2c, c2i) to further improve performance of
> class linking where adapters are generated.
>
> Short running Java applic
On Thu, 1 May 2025 18:53:38 GMT, Vladimir Kozlov wrote:
>> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
>> information in AOT cache which helps Java startup performance.
>>
>> We should also preserve adapters (i2c, c2i) to further improve performance
>> of class linki
On Thu, 1 May 2025 15:53:36 GMT, Vladimir Kozlov wrote:
>> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
>> information in AOT cache which helps Java startup performance.
>>
>> We should also preserve adapters (i2c, c2i) to further improve performance
>> of class linki
On Thu, 1 May 2025 15:44:11 GMT, Vladimir Kozlov wrote:
>>> assert(success || !AOTCodeCache::is_dumping_adapters(), "");
>>
>> This condtion `!AOTCodeCache::is_dumping_adapters()` in the assert is not
>> very intuitive. I think what we need to assert is future stores in the aot
>> code cache a
> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
> information in AOT cache which helps Java startup performance.
>
> We should also preserve adapters (i2c, c2i) to further improve performance of
> class linking where adapters are generated.
>
> Short running Java applic
On Thu, 1 May 2025 15:10:09 GMT, Ashutosh Mehra wrote:
>> Maybe add an assert here?
>>
>>
>> bool success = AOTCodeCache::store_code_blob(...);
>> assert(success || !AOTCodeCache::is_dumping_adapters(), "");
>
>> assert(success || !AOTCodeCache::is_dumping_adapters(), "");
>
> This condtion `!
On Thu, 1 May 2025 01:51:07 GMT, Vladimir Ivanov wrote:
> assert(success || !AOTCodeCache::is_dumping_adapters(), "");
This condtion `!AOTCodeCache::is_dumping_adapters()` in the assert is not very
intuitive. I think what we need to assert is future stores in the aot code
cache are disabled. S
On Thu, 1 May 2025 02:51:53 GMT, Vladimir Ivanov wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> renaming and new assert
>
> Marked as reviewed by vlivanov (Reviewer).
Thank you, @iwanowww. I need 2 re-reviews
On Thu, 1 May 2025 02:47:39 GMT, Vladimir Kozlov wrote:
>> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
>> information in AOT cache which helps Java startup performance.
>>
>> We should also preserve adapters (i2c, c2i) to further improve performance
>> of class linki
> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
> information in AOT cache which helps Java startup performance.
>
> We should also preserve adapters (i2c, c2i) to further improve performance of
> class linking where adapters are generated.
>
> Short running Java applic
On Thu, 1 May 2025 01:53:20 GMT, Vladimir Ivanov wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address Vladimir's comments
>
> src/hotspot/share/code/aotCodeCache.cpp line 56:
>
>> 54: #include
>> 55:
>> 56
On Thu, 1 May 2025 01:08:40 GMT, Vladimir Kozlov wrote:
>> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
>> information in AOT cache which helps Java startup performance.
>>
>> We should also preserve adapters (i2c, c2i) to further improve performance
>> of class linki
On Thu, 1 May 2025 00:24:07 GMT, Vladimir Kozlov wrote:
>> src/hotspot/share/runtime/sharedRuntime.cpp line 2852:
>>
>>> 2850: entry_offset[2] = handler->get_c2i_unverified_entry() - i2c_entry;
>>> 2851: entry_offset[3] = handler->get_c2i_no_clinit_check_entry() -
>>> i2c_entry;
>>> 285
> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
> information in AOT cache which helps Java startup performance.
>
> We should also preserve adapters (i2c, c2i) to further improve performance of
> class linking where adapters are generated.
>
> Short running Java applic
On Thu, 24 Apr 2025 01:53:55 GMT, Vladimir Ivanov wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix message
>
> Finished the first pass over the code.
>
>
> Overall, looks good. Some feedback follows.
Thank
On Wed, 30 Apr 2025 02:05:41 GMT, Vladimir Kozlov wrote:
>> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
>> information in AOT cache which helps Java startup performance.
>>
>> We should also preserve adapters (i2c, c2i) to further improve performance
>> of class link
On Wed, 30 Apr 2025 22:54:07 GMT, Vladimir Ivanov wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address Ioi's comments
>
> src/hotspot/share/code/aotCodeCache.cpp line 60:
>
>> 58: vm_exit_during_initiali
On Wed, 30 Apr 2025 22:59:03 GMT, Vladimir Ivanov wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address Ioi's comments
>
> src/hotspot/share/runtime/sharedRuntime.cpp line 2852:
>
>> 2850: entry_offset[2]
On Wed, 30 Apr 2025 22:54:38 GMT, Vladimir Ivanov wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address Ioi's comments
>
> src/hotspot/share/code/aotCodeCache.cpp line 69:
>
>> 67: vm_abort(false);
>> 68:
On Wed, 30 Apr 2025 22:09:24 GMT, Vladimir Ivanov wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address Ioi's comments
>
> src/hotspot/share/runtime/sharedRuntime.cpp line 2780:
>
>> 2778:
>> 2779: #ifndef P
On Wed, 30 Apr 2025 22:22:18 GMT, Vladimir Ivanov wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address Ioi's comments
>
> src/hotspot/share/code/relocInfo.hpp line 1292:
>
>> 1290: void pack_data_to(CodeSe
On Wed, 30 Apr 2025 02:05:41 GMT, Vladimir Kozlov wrote:
>> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
>> information in AOT cache which helps Java startup performance.
>>
>> We should also preserve adapters (i2c, c2i) to further improve performance
>> of class link
On Fri, 25 Apr 2025 00:52:04 GMT, Vladimir Kozlov wrote:
>> AOT adapters code caching and loading is guarded by these methods not by
>> flag.
>>
>> Setting AOTAdapterCaching to false on failure is simple indication that
>> adapter caching is switched off for someone who will look on final stat
On Wed, 30 Apr 2025 22:55:38 GMT, Vladimir Ivanov wrote:
>> I added `log_info()` to `exit_vm_on_*_failure()` methods to produce
>> notification when AbortVMOnAOTCodeFailure flag is off (default value).
>
> The naming (`exit_vm_on_load_failure` and `exit_vm_on_store_failure`) still
> look confu
On Wed, 30 Apr 2025 02:05:41 GMT, Vladimir Kozlov wrote:
>> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
>> information in AOT cache which helps Java startup performance.
>>
>> We should also preserve adapters (i2c, c2i) to further improve performance
>> of class link
On Wed, 30 Apr 2025 01:15:21 GMT, Ioi Lam wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unused method
>
> LGTM. Some small nits.
Thank you, @iklam, for review. I pushed your suggestions.
-
> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
> information in AOT cache which helps Java startup performance.
>
> We should also preserve adapters (i2c, c2i) to further improve performance of
> class linking where adapters are generated.
>
> Short running Java applic
On Tue, 29 Apr 2025 15:29:08 GMT, Vladimir Kozlov wrote:
>> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
>> information in AOT cache which helps Java startup performance.
>>
>> We should also preserve adapters (i2c, c2i) to further improve performance
>> of class link
On Tue, 29 Apr 2025 14:47:42 GMT, Ashutosh Mehra wrote:
>> Vladimir Kozlov has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 11 commits:
>>
>> - Fix C strings caching
>> - Merge branch 'master' into JDK-8350209
>> - Merge branch
On Tue, 29 Apr 2025 15:29:08 GMT, Vladimir Kozlov wrote:
>> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
>> information in AOT cache which helps Java startup performance.
>>
>> We should also preserve adapters (i2c, c2i) to further improve performance
>> of class link
On Tue, 29 Apr 2025 14:42:42 GMT, Ashutosh Mehra wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Downgraded UL as asked. Added synchronization to C strings caching.
>
> src/hotspot/share/code/aotCodeCache.hpp li
> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
> information in AOT cache which helps Java startup performance.
>
> We should also preserve adapters (i2c, c2i) to further improve performance of
> class linking where adapters are generated.
>
> Short running Java applic
On Tue, 29 Apr 2025 06:27:41 GMT, Vladimir Kozlov wrote:
>> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
>> information in AOT cache which helps Java startup performance.
>>
>> We should also preserve adapters (i2c, c2i) to further improve performance
>> of class link
On Sun, 27 Apr 2025 21:52:43 GMT, Vladimir Kozlov wrote:
>> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
>> information in AOT cache which helps Java startup performance.
>>
>> We should also preserve adapters (i2c, c2i) to further improve performance
>> of class link
> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
> information in AOT cache which helps Java startup performance.
>
> We should also preserve adapters (i2c, c2i) to further improve performance of
> class linking where adapters are generated.
>
> Short running Java applic
On Sun, 27 Apr 2025 22:22:02 GMT, Vladimir Kozlov wrote:
>> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
>> information in AOT cache which helps Java startup performance.
>>
>> We should also preserve adapters (i2c, c2i) to further improve performance
>> of class link
On Mon, 28 Apr 2025 20:10:19 GMT, Magnus Ihse Bursie wrote:
>> Vladimir Kozlov has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains nine commits:
>>
>> - Merge branch 'master' into JDK-8350209
>> - Downgraded UL as asked. Added synch
On Sun, 27 Apr 2025 22:22:02 GMT, Vladimir Kozlov wrote:
>> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
>> information in AOT cache which helps Java startup performance.
>>
>> We should also preserve adapters (i2c, c2i) to further improve performance
>> of class link
> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
> information in AOT cache which helps Java startup performance.
>
> We should also preserve adapters (i2c, c2i) to further improve performance of
> class linking where adapters are generated.
>
> Short running Java applic
On Tue, 22 Apr 2025 23:05:13 GMT, Vladimir Kozlov wrote:
>> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
>> information in AOT cache which helps Java startup performance.
>>
>> We should also preserve adapters (i2c, c2i) to further improve performance
>> of class link
On Sun, 27 Apr 2025 21:52:43 GMT, Vladimir Kozlov wrote:
>> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
>> information in AOT cache which helps Java startup performance.
>>
>> We should also preserve adapters (i2c, c2i) to further improve performance
>> of class link
> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
> information in AOT cache which helps Java startup performance.
>
> We should also preserve adapters (i2c, c2i) to further improve performance of
> class linking where adapters are generated.
>
> Short running Java applic
On Tue, 22 Apr 2025 23:05:13 GMT, Vladimir Kozlov wrote:
>> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
>> information in AOT cache which helps Java startup performance.
>>
>> We should also preserve adapters (i2c, c2i) to further improve performance
>> of class link
On Fri, 25 Apr 2025 00:48:43 GMT, Vladimir Kozlov wrote:
>> We check failure state of AOT code cache when query about using adapters
>> caching:
>>
>> bool for_use() const { return _for_use && !_failed; }
>> bool for_dump() const { return _for_dump && !_failed; }
>> static bool is_on()
On Fri, 25 Apr 2025 00:44:46 GMT, Vladimir Kozlov wrote:
>> src/hotspot/share/code/aotCodeCache.cpp line 62:
>>
>>> 60: }
>>> 61:
>>> 62: static void exit_vm_on_store_failure() {
>>
>> It's a bit confusing to see `exit_vm_on_load_failure()` and
>> `exit_vm_on_store_failure()` to silently proc
On Thu, 24 Apr 2025 01:51:40 GMT, Vladimir Ivanov wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix message
>
> src/hotspot/share/code/aotCodeCache.cpp line 62:
>
>> 60: }
>> 61:
>> 62: static void exit_vm_o
On Thu, 24 Apr 2025 01:37:12 GMT, Vladimir Ivanov wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix message
>
> src/hotspot/share/code/aotCodeCache.cpp line 645:
>
>> 643: return false;
>> 644: }
>> 645
On Thu, 24 Apr 2025 00:49:23 GMT, Vladimir Ivanov wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix message
>
> src/hotspot/share/cds/aotCacheAccess.hpp line 40:
>
>> 38: class AOTCacheAccess : AllStatic {
>>
On Thu, 24 Apr 2025 01:39:33 GMT, Vladimir Ivanov wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix message
>
> src/hotspot/share/runtime/sharedRuntime.cpp line 2966:
>
>> 2964: adapter_blob =
>> Adapter
On Thu, 24 Apr 2025 02:18:27 GMT, Ioi Lam wrote:
>> src/hotspot/share/cds/aotCacheAccess.hpp line 38:
>>
>>> 36: // AOT Cache API for AOT compiler
>>> 37:
>>> 38: class AOTCacheAccess : AllStatic {
>>
>> It looks related to `AOTCodeCache`? Maybe `AOTCodeCacheAccess` then?
>
> This file is call
On Thu, 24 Apr 2025 00:51:31 GMT, Vladimir Ivanov wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix message
>
> src/hotspot/share/cds/aotCacheAccess.hpp line 38:
>
>> 36: // AOT Cache API for AOT compiler
>>
On Tue, 22 Apr 2025 23:05:13 GMT, Vladimir Kozlov wrote:
>> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
>> information in AOT cache which helps Java startup performance.
>>
>> We should also preserve adapters (i2c, c2i) to further improve performance
>> of class link
On Wed, 23 Apr 2025 14:24:20 GMT, Erik Joelsson wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix message
>
> Build change looks trivially good.
Thank you, @erikj79
-
PR Comment: https://git.ope
On Tue, 22 Apr 2025 23:05:13 GMT, Vladimir Kozlov wrote:
>> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
>> information in AOT cache which helps Java startup performance.
>>
>> We should also preserve adapters (i2c, c2i) to further improve performance
>> of class link
> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
> information in AOT cache which helps Java startup performance.
>
> We should also preserve adapters (i2c, c2i) to further improve performance of
> class linking where adapters are generated.
>
> Short running Java applic
On Tue, 22 Apr 2025 22:42:08 GMT, Vladimir Kozlov wrote:
>> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
>> information in AOT cache which helps Java startup performance.
>>
>> We should also preserve adapters (i2c, c2i) to further improve performance
>> of class link
> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
> information in AOT cache which helps Java startup performance.
>
> We should also preserve adapters (i2c, c2i) to further improve performance of
> class linking where adapters are generated.
>
> Short running Java applic
> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
> information in AOT cache which helps Java startup performance.
>
> We should also preserve adapters (i2c, c2i) to further improve performance of
> class linking where adapters are generated.
>
> Short running Java applic
On Tue, 22 Apr 2025 17:01:20 GMT, Ioi Lam wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add sanity test for AOTAdapterCaching flag
>
> src/hotspot/share/cds/cdsConfig.cpp line 869:
>
>> 867:
>> 868: bool CDS
On Fri, 18 Apr 2025 18:45:24 GMT, Vladimir Kozlov wrote:
>> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
>> information in AOT cache which helps Java startup performance.
>>
>> We should also preserve adapters (i2c, c2i) to further improve performance
>> of class link
> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
> information in AOT cache which helps Java startup performance.
>
> We should also preserve adapters (i2c, c2i) to further improve performance of
> class linking where adapters are generated.
>
> Short running Java applic
> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
> information in AOT cache which helps Java startup performance.
>
> We should also preserve adapters (i2c, c2i) to further improve performance of
> class linking where adapters are generated.
>
> Short running Java applic
On Fri, 18 Apr 2025 06:01:43 GMT, Ashutosh Mehra wrote:
> @vnkozlov I forgot to remove `AOTCodeSection` from `code/aotCodeCache.hpp`
> when I refactored the APIs. This struct is no longer used. Can you please
> remove it.
Done.
-
PR Comment: https://git.openjdk.org/jdk/pull/24740
> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
> information in AOT cache which helps Java startup performance.
>
> We should also preserve adapters (i2c, c2i) to further improve performance of
> class linking where adapters are generated.
>
> Short running Java applic
On Thu, 17 Apr 2025 19:11:47 GMT, Vladimir Kozlov wrote:
> [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737) preserves class
> information in AOT cache which helps Java startup performance.
>
> We should also preserve adapters (i2c, c2i) to further improve performance of
> class linking w
68 matches
Mail list logo
