Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64

2025-02-26 Thread Jiangli Zhou
On Wed, 26 Feb 2025 15:02:08 GMT, Aleksey Shipilev wrote: >> Please review this change that adds a `linux-x86-static` job in GHA. The job >> builds the `static-jdk-image` release binary on linux-x64. Please see >> https://mail.openjdk.org/pipermail/build-dev/2025-February/048830.html for >> s

Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64 [v4]

2025-02-26 Thread Magnus Ihse Bursie
On Wed, 26 Feb 2025 20:25:41 GMT, Jiangli Zhou wrote: >> Please review this change that adds a `linux-x86-static` job in GHA. The job >> builds the `static-jdk-image` release binary on linux-x64. Please see >> https://mail.openjdk.org/pipermail/build-dev/2025-February/048830.html for >> some

Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64 [v4]

2025-02-26 Thread Aleksey Shipilev
On Wed, 26 Feb 2025 20:25:41 GMT, Jiangli Zhou wrote: >> Please review this change that adds a `linux-x86-static` job in GHA. The job >> builds the `static-jdk-image` release binary on linux-x64. Please see >> https://mail.openjdk.org/pipermail/build-dev/2025-February/048830.html for >> some

Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64 [v4]

2025-02-26 Thread Jiangli Zhou
> Please review this change that adds a `linux-x86-static` job in GHA. The job > builds the `static-jdk-image` release binary on linux-x64. Please see > https://mail.openjdk.org/pipermail/build-dev/2025-February/048830.html for > some additional context. > > A `debug` build job (building `stat

Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64 [v3]

2025-02-26 Thread Jiangli Zhou
On Wed, 26 Feb 2025 19:44:50 GMT, Aleksey Shipilev wrote: > Ah, one more trouble: this job produces bundles. But that bundle name is just > `linux-x64`, which overrides the standard bundle. See how > `build-linux-x64-static-libs` overrides `bundle-suffix:`, do the same here. > E.g. `bundle-suf

Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64 [v3]

2025-02-26 Thread Aleksey Shipilev
On Wed, 26 Feb 2025 18:24:13 GMT, Jiangli Zhou wrote: >> Please review this change that adds a `linux-x86-static` job in GHA. The job >> builds the `static-jdk-image` release binary on linux-x64. Please see >> https://mail.openjdk.org/pipermail/build-dev/2025-February/048830.html for >> some

Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64 [v3]

2025-02-26 Thread Jiangli Zhou
> Please review this change that adds a `linux-x86-static` job in GHA. The job > builds the `static-jdk-image` release binary on linux-x64. Please see > https://mail.openjdk.org/pipermail/build-dev/2025-February/048830.html for > some additional context. > > A `debug` build job (building `stat

Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64 [v2]

2025-02-26 Thread Jiangli Zhou
On Wed, 26 Feb 2025 17:59:46 GMT, Aleksey Shipilev wrote: >> .github/workflows/main.yml line 171: >> >>> 169: if: needs.prepare.outputs.linux-x64 == 'true' >>> 170: >>> 171: build-linux-x64-static-jdk: >> >> Move this closer to `build-linux-x64-static-libs`? These are somewhat >> relate

Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64 [v2]

2025-02-26 Thread Jiangli Zhou
On Wed, 26 Feb 2025 17:59:46 GMT, Aleksey Shipilev wrote: >> .github/workflows/main.yml line 171: >> >>> 169: if: needs.prepare.outputs.linux-x64 == 'true' >>> 170: >>> 171: build-linux-x64-static-jdk: >> >> Move this closer to `build-linux-x64-static-libs`? These are somewhat >> relate

Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64 [v2]

2025-02-26 Thread Aleksey Shipilev
On Wed, 26 Feb 2025 17:52:57 GMT, Jiangli Zhou wrote: >> Please review this change that adds a `linux-x86-static` job in GHA. The job >> builds the `static-jdk-image` release binary on linux-x64. Please see >> https://mail.openjdk.org/pipermail/build-dev/2025-February/048830.html for >> some

Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64 [v2]

2025-02-26 Thread Aleksey Shipilev
On Wed, 26 Feb 2025 17:58:08 GMT, Aleksey Shipilev wrote: >> Jiangli Zhou has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains nine additional >> com

Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64 [v2]

2025-02-26 Thread Jiangli Zhou
> Please review this change that adds a `linux-x86-static` job in GHA. The job > builds the `static-jdk-image` release binary on linux-x64. Please see > https://mail.openjdk.org/pipermail/build-dev/2025-February/048830.html for > some additional context. > > A `debug` build job (building `stat

Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64

2025-02-26 Thread Aleksey Shipilev
On Wed, 5 Feb 2025 19:41:51 GMT, Jiangli Zhou wrote: > Please review this change that adds a `linux-x86-static` job in GHA. The job > builds the `static-jdk-image` release binary on linux-x64. Please see > https://mail.openjdk.org/pipermail/build-dev/2025-February/048830.html for > some addit

Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64

2025-02-21 Thread Aleksey Shipilev
On Thu, 20 Feb 2025 15:58:03 GMT, Aleksey Shipilev wrote: >> What's the difference between `build-linux-static.yml` and >> `build-linux.yml`? Can we just call `build-linux.yml` to do the static build? > >> @shipilev Can you help review/approve the change, if no other questions? > > Sorry for no

Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64

2025-02-20 Thread Jiangli Zhou
On Thu, 20 Feb 2025 15:58:03 GMT, Aleksey Shipilev wrote: > > @shipilev Can you help review/approve the change, if no other questions? > > Sorry for not looking at this sooner. > > It looks to me that you are trying to work-around a little mess introduced by > `static-libs-bundles` addition >

Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64

2025-02-20 Thread Aleksey Shipilev
On Thu, 6 Feb 2025 17:01:04 GMT, Aleksey Shipilev wrote: >> Please review this change that adds a `linux-x86-static` job in GHA. The job >> builds the `static-jdk-image` release binary on linux-x64. Please see >> https://mail.openjdk.org/pipermail/build-dev/2025-February/048830.html for >> so

Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64

2025-02-18 Thread Jiangli Zhou
On Wed, 5 Feb 2025 19:41:51 GMT, Jiangli Zhou wrote: > Please review this change that adds a `linux-x86-static` job in GHA. The job > builds the `static-jdk-image` release binary on linux-x64. Please see > https://mail.openjdk.org/pipermail/build-dev/2025-February/048830.html for > some addit

Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64

2025-02-11 Thread Jiangli Zhou
On Thu, 6 Feb 2025 17:01:04 GMT, Aleksey Shipilev wrote: >> Please review this change that adds a `linux-x86-static` job in GHA. The job >> builds the `static-jdk-image` release binary on linux-x64. Please see >> https://mail.openjdk.org/pipermail/build-dev/2025-February/048830.html for >> so

Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64

2025-02-06 Thread Jiangli Zhou
On Thu, 6 Feb 2025 17:01:04 GMT, Aleksey Shipilev wrote: >> Please review this change that adds a `linux-x86-static` job in GHA. The job >> builds the `static-jdk-image` release binary on linux-x64. Please see >> https://mail.openjdk.org/pipermail/build-dev/2025-February/048830.html for >> so

Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64

2025-02-06 Thread Aleksey Shipilev
On Wed, 5 Feb 2025 19:41:51 GMT, Jiangli Zhou wrote: > Please review this change that adds a `linux-x86-static` job in GHA. The job > builds the `static-jdk-image` release binary on linux-x64. Please see > https://mail.openjdk.org/pipermail/build-dev/2025-February/048830.html for > some addit

Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64

2025-02-06 Thread Jiangli Zhou
On Wed, 5 Feb 2025 19:41:51 GMT, Jiangli Zhou wrote: > Please review this change that adds a `linux-x86-static` job in GHA. The job > builds the `static-jdk-image` release binary on linux-x64. Please see > https://mail.openjdk.org/pipermail/build-dev/2025-February/048830.html for > some addit

RFR: 8349399: GHA: Add static-jdk build on linux-x64

2025-02-05 Thread Jiangli Zhou
Please review this change that adds a `linux-x86-static` job in GHA. The job builds the `static-jdk-image` release binary on linux-x64. Please see https://mail.openjdk.org/pipermail/build-dev/2025-February/048830.html for some additional context. A `debug` build job (building `static-jdk-image