On Thu, 20 Feb 2025 15:58:03 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> What's the difference between `build-linux-static.yml` and >> `build-linux.yml`? Can we just call `build-linux.yml` to do the static build? > >> @shipilev Can you help review/approve the change, if no other questions? > > Sorry for not looking at this sooner. > > It looks to me that you are trying to work-around a little mess introduced by > `static-libs-bundles` addition > ([JDK-8337265](https://bugs.openjdk.org/browse/JDK-8337265)). Not your mess, > but trying to avoid it introduces more headaches. I am somewhat surprised we > even have `static-libs-bundles` as additional target in what I would consider > a generic `build-linux` job! It looks cleaner to yank `static-libs-bundles` > into a separate build job, which would then allow your PR to proceed by just > calling `build-linux` normally, without introducing a wholly new job script. > Let me try to fix `static-libs-bundles` first. > Thank you, @shipilev! Fixing the build-linux first sounds good to me. I see > you have PR already, thanks again! Hey @jianglizhou, a quick question for you. There are two options for this PR: 1. Build both `static-jdk-image` and `static-libs-bundle` in the same `linux-x64-static` job from #23715 2. Build `static-jdk-image` and `static-libs-bundle` in different jobs Which one would you prefer? I would prefer to test all static stuff in a single job (1), unless you disagree? If we decide now, it would allow me to name the job in #23715 properly from the start. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23471#issuecomment-2673918096
