Re: RFR: 8316893: Compile without -fno-delete-null-pointer-checks [v2]

2023-10-02 Thread Daniel Jeliński
On Mon, 2 Oct 2023 14:01:10 GMT, Julian Waters wrote: >> I reverted the quotes. >> Didn't get your question; are you suggesting to rename the variable? I'd >> rather not do that, because 1) it increases the patch size, 2) all variables >> are global, so renaming might have unintended consequenc

Re: RFR: 8316893: Compile without -fno-delete-null-pointer-checks [v3]

2023-10-02 Thread Kim Barrett
On Mon, 2 Oct 2023 11:04:13 GMT, Daniel Jeliński wrote: >> Please review this patch that reenables `delete-null-pointer-checks` >> optimization in GCC and Clang. >> >> It also disables `nonnull-compare` warning that is now triggered in debug >> builds. The problematic code will be addressed by

Re: RFR: 8316893: Compile without -fno-delete-null-pointer-checks [v2]

2023-10-02 Thread Julian Waters
On Mon, 2 Oct 2023 11:09:43 GMT, Daniel Jeliński wrote: >> make/autoconf/flags-cflags.m4 line 928: >> >>> 926: FLAGS_COMPILER_CHECK_ARGUMENTS(ARGUMENT: [$NO_LIFETIME_DSE_CFLAG], >>> 927: PREFIX: $2, IF_FALSE: [NO_LIFETIME_DSE_CFLAG=""]) >>> 928: $1_GCC6_CFLAGS=${NO_LIFETIME_DSE_CFLAG}

Re: RFR: 8316893: Compile without -fno-delete-null-pointer-checks [v3]

2023-10-02 Thread Erik Joelsson
On Mon, 2 Oct 2023 11:04:13 GMT, Daniel Jeliński wrote: >> Please review this patch that reenables `delete-null-pointer-checks` >> optimization in GCC and Clang. >> >> It also disables `nonnull-compare` warning that is now triggered in debug >> builds. The problematic code will be addressed by

Re: RFR: 8316893: Compile without -fno-delete-null-pointer-checks [v2]

2023-10-02 Thread Daniel Jeliński
On Mon, 2 Oct 2023 08:38:45 GMT, Julian Waters wrote: >> Daniel Jeliński has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix typo > > make/autoconf/flags-cflags.m4 line 928: > >> 926: FLAGS_COMPILER_CHECK_ARGUMENTS(ARGUMENT: [$NO_LIFE

Re: RFR: 8316893: Compile without -fno-delete-null-pointer-checks [v3]

2023-10-02 Thread Daniel Jeliński
> Please review this patch that reenables `delete-null-pointer-checks` > optimization in GCC and Clang. > > It also disables `nonnull-compare` warning that is now triggered in debug > builds. The problematic code will be addressed by #15927. > > Mach5 Tier1-5 testing clean. Daniel Jeliński has

Re: RFR: 8316893: Compile without -fno-delete-null-pointer-checks [v3]

2023-10-02 Thread Daniel Jeliński
On Mon, 2 Oct 2023 07:24:06 GMT, Daniel Jeliński wrote: >> make/hotspot/lib/CompileJvm.gmk line 165: >> >>> 163: DISABLED_WARNINGS_gcc := $(DISABLED_WARNINGS_gcc), \ >>> 164: DISABLED_WARNINGS_gcc_ad_$(HOTSPOT_TARGET_CPU_ARCH).cpp := >>> nonnull, \ >>> 165: DISABLED_WARNINGS_gcc_ad_

Re: RFR: 8316893: Compile without -fno-delete-null-pointer-checks [v2]

2023-10-02 Thread Julian Waters
On Mon, 2 Oct 2023 08:26:34 GMT, Daniel Jeliński wrote: >> Please review this patch that reenables `delete-null-pointer-checks` >> optimization in GCC and Clang. >> >> It also disables `nonnull-compare` warning that is now triggered in debug >> builds. The problematic code will be addressed by

Re: RFR: 8316893: Compile without -fno-delete-null-pointer-checks [v2]

2023-10-02 Thread Daniel Jeliński
On Sun, 1 Oct 2023 05:13:25 GMT, Kim Barrett wrote: >> Daniel Jeliński has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix typo > > make/autoconf/flags-cflags.m4 line 923: > >> 921: AC_DEFUN([FLAGS_SETUP_GCC6_COMPILER_FLAGS], >> 922: [

Re: RFR: 8316893: Compile without -fno-delete-null-pointer-checks [v2]

2023-10-02 Thread Daniel Jeliński
> Please review this patch that reenables `delete-null-pointer-checks` > optimization in GCC and Clang. > > It also disables `nonnull-compare` warning that is now triggered in debug > builds. The problematic code will be addressed by #15927. > > Mach5 Tier1-5 testing clean. Daniel Jeliński has

Re: RFR: 8316893: Compile without -fno-delete-null-pointer-checks

2023-09-30 Thread Kim Barrett
On Fri, 29 Sep 2023 10:01:42 GMT, Daniel Jeliński wrote: > Please review this patch that reenables `delete-null-pointer-checks` > optimization in GCC and Clang. > > It also disables `nonnull-compare` warning that is now triggered in debug > builds. The problematic code will be addressed by #15

Re: RFR: 8316893: Compile without -fno-delete-null-pointer-checks

2023-09-30 Thread Julian Waters
On Fri, 29 Sep 2023 10:01:42 GMT, Daniel Jeliński wrote: > Please review this patch that reenables `delete-null-pointer-checks` > optimization in GCC and Clang. > > It also disables `nonnull-compare` warning that is now triggered in debug > builds. The problematic code will be addressed by #15

RFR: 8316893: Compile without -fno-delete-null-pointer-checks

2023-09-30 Thread Daniel Jeliński
Please review this patch that reenables `delete-null-pointer-checks` optimization in GCC and Clang. It also disables `nonnull-compare` warning that is now triggered in debug builds. The problematic code will be addressed by #15927. Mach5 Tier1-5 testing clean. - Commit messages: