On Mon, 2 Oct 2023 11:09:43 GMT, Daniel Jeliński <[email protected]> wrote:
>> make/autoconf/flags-cflags.m4 line 928:
>>
>>> 926: FLAGS_COMPILER_CHECK_ARGUMENTS(ARGUMENT: [$NO_LIFETIME_DSE_CFLAG],
>>> 927: PREFIX: $2, IF_FALSE: [NO_LIFETIME_DSE_CFLAG=""])
>>> 928: $1_GCC6_CFLAGS=${NO_LIFETIME_DSE_CFLAG}
>>
>> Might be safer to leave the quote around the DSE flag. Also, why not flag(s)
>> instead?
>
> I reverted the quotes.
> Didn't get your question; are you suggesting to rename the variable? I'd
> rather not do that, because 1) it increases the patch size, 2) all variables
> are global, so renaming might have unintended consequences, and 3) the old
> name is good enough.
Ah no, I meant the comment, from This flag -> These flag(s), since it's implied
that this site is where multiple gcc specific flags should be placed in the
future. Just a small nit, nothing serious
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15982#discussion_r1342734293
