[Bug-tar] tar-1.31/lib/stdopen.c:63]: (style) Suspicious condition

= O_RDONLY || ((new_fd = open ("/dev/full", mode)) != fd)) Regards David Binderman

Re: [Bug-tar] tar-1.31/lib/stdopen.c:63]: (style) Suspicious condition

original intention. Regards David Binderman

tar-1.33 bug report

"/dev/full", mode)) != fd)) Regards David Binderman

tar-1.33/src/buffer.c:1733:redundantAssignment

volno); st.file_name = st.orig_file_name; st.archive_file_size = st.stat.st_size = map->sizeleft; I suggest the code could do with a minor tidy up. When initialising fields, I usually like to do it in alfabetic order, or in the order in the definition. Regards David Binderman

Re: tar-1.33/src/buffer.c:1733:redundantAssignment

n with a const char * parameter ? Something like char * xheader_format_name (const char * orig_file_name, const char *fmt, size_t n) { Regards David Binderman