Re: parted-1.9.0 -- comments and patches

2009-08-03 Thread Curtis Gedak
Joel Granados wrote: On Fri, Jul 31, 2009 at 02:20:44PM -0600, Curtis Gedak wrote: I too am experiencing a similar problem with failed tests when I run "make check" on parted-1.9.0. I just checked in my environment and this seems to work for me. The test passes even though I do a ./co

Re: parted-1.9.0 -- comments and patches

2009-08-03 Thread Peter Breitenlohner
On Mon, 3 Aug 2009, Joel Granados wrote: You are _not_ on next, you are on master branch. pls do a `git checkout next` and repeat the tests. FYI, master == 1.9.0. Remember to do the whole process from the beginning. 1. bootstrap, 2. configure. 3. make 4. sudo make check Hi Joel, OK done.

Re: parted-1.9.0 -- comments and patches

2009-08-03 Thread Joel Granados
On Mon, Aug 03, 2009 at 03:01:34PM +0200, Peter Breitenlohner wrote: > On Mon, 3 Aug 2009, Joel Granados wrote: > >> On Mon, Aug 03, 2009 at 11:53:11AM +0200, Peter Breitenlohner wrote: >>> The above was with parted-1.9.0; >> >> Untill now, there is no interest in maintaining a bug fix branch for >

Re: parted-1.9.0 -- comments and patches

2009-08-03 Thread Peter Breitenlohner
On Mon, 3 Aug 2009, Joel Granados wrote: On Mon, Aug 03, 2009 at 11:53:11AM +0200, Peter Breitenlohner wrote: The above was with parted-1.9.0; Untill now, there is no interest in maintaining a bug fix branch for 1.9.0. Hi Joel, I did this by mistake. Once done wanted to report the result.

Re: parted-1.9.0 -- comments and patches

2009-08-03 Thread Joel Granados
On Mon, Aug 03, 2009 at 02:08:20PM +0200, Joel Granados wrote: > On Mon, Aug 03, 2009 at 11:53:11AM +0200, Peter Breitenlohner wrote: > > On Mon, 3 Aug 2009, Joel Granados wrote: > > > >> This should be primary not pirmary. ... > > /home/pcl321/peb/archive/gnu/parted/parted-git/parted/.libs/lt-part

Re: parted-1.9.0 -- comments and patches

2009-08-03 Thread Joel Granados
On Mon, Aug 03, 2009 at 11:53:11AM +0200, Peter Breitenlohner wrote: > On Mon, 3 Aug 2009, Joel Granados wrote: > >> This should be primary not pirmary. >> Can you pls try again. > Peter: Thx for your feedback. It is much appreciated. My comments bellow. > Hi Joel, > > did it again as root, in

Re: parted-1.9.0 -- comments and patches

2009-08-03 Thread Peter Breitenlohner
On Mon, 3 Aug 2009, Joel Granados wrote: This should be primary not pirmary. Can you pls try again. Hi Joel, did it again as root, in the parted build directory, and got: echo n | ./parted ---pretend-input-tty testfile \ "mklabel gpt mkpart primary ext3 1 -1" Warning: The exis

Re: parted-1.9.0 -- comments and patches

2009-08-03 Thread Joel Granados
On Sat, Aug 01, 2009 at 02:17:33PM -0600, Curtis Gedak wrote: > Jim Meyering wrote: >> Joel Granados wrote: >> ... > > For reference, the output from "make check" for parted-1.9.0 is as follows: again, pls make sure you are on the "next" branch. > > $ make check > make check-recursive > <..

Re: parted-1.9.0 -- comments and patches

2009-08-03 Thread Joel Granados
On Fri, Jul 31, 2009 at 02:20:44PM -0600, Curtis Gedak wrote: > Peter Breitenlohner wrote: >>> Did you test >>> your patch. Does it really fix the fact that that the test does not >>> PASS. ... >> >> Yes, of course. The result was the same when running the test via my >> build+check+install

Re: parted-1.9.0 -- comments and patches

2009-08-03 Thread Joel Granados
Did you see Jim's answer? On Fri, Jul 31, 2009 at 04:59:06PM +0200, Peter Breitenlohner wrote: > On Fri, 31 Jul 2009, Joel Granados wrote: > >> You must be root and you should have done: >> >> git clone git://git.debian.org/git/parted/parted.git >> cd parted >> git branch next --track origin/next

Re: parted-1.9.0 -- comments and patches

2009-08-01 Thread Curtis Gedak
Jim Meyering wrote: Joel Granados wrote: On Fri, Jul 31, 2009 at 12:31:27PM +0200, Peter Breitenlohner wrote: On Fri, 31 Jul 2009, Joel Granados wrote: So does t7000 fail for you always? How are you executing the tests? Hi Joel, from a shell script, executing

Re: parted-1.9.0 -- comments and patches

2009-08-01 Thread Jim Meyering
Joel Granados wrote: > On Fri, Jul 31, 2009 at 12:31:27PM +0200, Peter Breitenlohner wrote: >> On Fri, 31 Jul 2009, Joel Granados wrote: >> >>> So does t7000 fail for you always? How are you executing the tests? >> >> Hi Joel, >> >> from a shell script, executing >> { make check 2>&1; echo "r

Re: parted-1.9.0 -- comments and patches

2009-07-31 Thread Curtis Gedak
Peter Breitenlohner wrote: Did you test your patch. Does it really fix the fact that that the test does not PASS. ... Yes, of course. The result was the same when running the test via my build+check+install script or when running 'make check' interactively in the tests/ directory (of t

Re: parted-1.9.0 -- comments and patches

2009-07-31 Thread Peter Breitenlohner
On Fri, 31 Jul 2009, Joel Granados wrote: Aha, this might be due to the fact that you dont use dm. ... Hi Joel, possibly, although I doubt it (see below). Did you test your patch. Does it really fix the fact that that the test does not PASS. ... Yes, of course. The result was the

Re: parted-1.9.0 -- comments and patches

2009-07-31 Thread Joel Granados
On Fri, Jul 31, 2009 at 04:59:06PM +0200, Peter Breitenlohner wrote: > On Fri, 31 Jul 2009, Joel Granados wrote: > >> You must be root and you should have done: >> >> git clone git://git.debian.org/git/parted/parted.git >> cd parted >> git branch next --track origin/next >> ./bootstrap > > Hi Joel

Re: parted-1.9.0 -- comments and patches

2009-07-31 Thread Peter Breitenlohner
On Fri, 31 Jul 2009, Joel Granados wrote: You must be root and you should have done: git clone git://git.debian.org/git/parted/parted.git cd parted git branch next --track origin/next ./bootstrap Hi Joel, I have done this as me (i.e., peb not root), followed by ./configure --prefix/t

Re: parted-1.9.0 -- comments and patches

2009-07-31 Thread Peter Breitenlohner
On Fri, 31 Jul 2009, Joel Granados wrote: So does t7000 fail for you always? How are you executing the tests? Hi Joel, from a shell script, executing { make check 2>&1; echo "rc=$?" } | tee -a make.log I would not trust the spec.in file in parted. We are "maintaining" it but it us

Re: parted-1.9.0 -- comments and patches

2009-07-31 Thread Joel Granados
On Fri, Jul 31, 2009 at 02:59:21PM +0200, Joel Granados wrote: > On Fri, Jul 31, 2009 at 12:31:27PM +0200, Peter Breitenlohner wrote: > > On Fri, 31 Jul 2009, Joel Granados wrote: > > > >> So does t7000 fail for you always? How are you executing the tests? > > > > Hi Joel, > > > > from a shell scr

Re: parted-1.9.0 -- comments and patches

2009-07-31 Thread Joel Granados
On Fri, Jul 31, 2009 at 12:31:27PM +0200, Peter Breitenlohner wrote: > On Fri, 31 Jul 2009, Joel Granados wrote: > >> So does t7000 fail for you always? How are you executing the tests? > > Hi Joel, > > from a shell script, executing > { make check 2>&1; echo "rc=$?" } | tee -a make.log Can

Re: parted-1.9.0 -- comments and patches

2009-07-31 Thread Joel Granados
On Thu, Jul 30, 2009 at 02:15:24PM +0200, Peter Breitenlohner wrote: > Hi, > > I'd like to suggest the attached two patches: > > (1) patch-01-test-scripting: So does t7000 fail for you always? How are you executing the tests? > > without this the test failed. > > (2) patch-02-check-programs: > >

Re: parted-1.9.0 -- comments and patches

2009-07-30 Thread Petr Uzel
Hi, On Thu, Jul 30, 2009 at 02:15:24PM +0200, Peter Breitenlohner wrote: > Hi, > > I'd like to suggest the attached two patches: > > (1) patch-01-test-scripting: > > without this the test failed. I have the same problem when building on openSUSE, see this thread: http://lists.alioth.debian.org

parted-1.9.0 -- comments and patches

2009-07-30 Thread Peter Breitenlohner
Hi, I'd like to suggest the attached two patches: (1) patch-01-test-scripting: without this the test failed. (2) patch-02-check-programs: I am fairly sure you don't want to install the two test programs 'disk' and 'label' (they are not mentioned under %files in parted.spec). Thus they ought t