Usefulness of make -t

2023-04-02 Thread Alejandro Colomar
Hi Paul, Yesterday I found another use of make's -t flag: It helps make sure that the logic in the Makefile is correct. You could run the target without -t, but then you risk seeing warnings and errors from the commands run by the target before make's own ones, which would hide Makefile problems.

`make check -j` fails when building GNU Make from source

2023-04-02 Thread Alejandro Colomar
Hi, If I build make from source and run the checks in parallel, some fail. Is this expected, or is it a bug in the Makefile? Cheers, Alex -- GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5 makeerror-4.4.1-x86_64-pc-linux-gnu-t3wj.tar.gz Descript

Re: Usefulness of make -t

2023-04-02 Thread Alejandro Colomar
On 4/2/23 14:20, Alejandro Colomar wrote: > Hi Paul, > > Yesterday I found another use of make's -t flag: It helps make sure > that the logic in the Makefile is correct. You could run the target > without -t, but then you risk seeing warnings and errors from the > commands run by the target befor

Re: `make check -j` fails when building GNU Make from source

2023-04-02 Thread Paul Smith
On Sun, 2023-04-02 at 14:52 +0200, Alejandro Colomar wrote: > If I build make from source and run the checks in parallel, some > fail. Is this expected, or is it a bug in the Makefile? The test suite is invoked as a single target, so there's no way that enabling parallelism could impact it. Also

[bug #63867] Port to older versions of gnu tar.

2023-04-02 Thread Paul D. Smith
Update of bug #63867 (project make): Status:None => Fixed Assigned to:None => psmith Open/Closed:Open => Closed Fixed Release:

Re: `make check -j` fails when building GNU Make from source

2023-04-02 Thread Alejandro Colomar
Hi Paul, On 4/2/23 16:04, Paul Smith wrote: > On Sun, 2023-04-02 at 14:52 +0200, Alejandro Colomar wrote: >> If I build make from source and run the checks in parallel, some >> fail. Is this expected, or is it a bug in the Makefile? > > The test suite is invoked as a single target, so there's no

Re: `make check -j` fails when building GNU Make from source

2023-04-02 Thread Paul Smith
On Sun, 2023-04-02 at 16:13 +0200, Alejandro Colomar wrote: > I can reproduce it by running `make check`, interrupting it > at this specific point, and then running again `make check` > (no -j needed): This is a known limitation with the test suite.

[bug #63981] suppress "-jN forced in submake" warning with -j1

2023-04-02 Thread Paul D. Smith
Follow-up Comment #1, bug #63981 (project make): I made this change because of the manual although I'm not exactly sure it's the best idea. Note that there are better ways to force a makefile to be not parallel; for example you can use: all: $(MAKE) --eval '.NOTPARALLEL:' -f one.mk wh

Re: `make check -j` fails when building GNU Make from source

2023-04-02 Thread Alejandro Colomar
On 4/2/23 16:15, Paul Smith wrote: > On Sun, 2023-04-02 at 16:13 +0200, Alejandro Colomar wrote: >> I can reproduce it by running `make check`, interrupting it >> at this specific point, and then running again `make check` >> (no -j needed): > > This is a known limitation with the test suite. I w

[bug #63981] suppress "-jN forced in submake" warning with -j1

2023-04-02 Thread Paul D. Smith
Update of bug #63981 (project make): Status:None => Fixed Assigned to:None => psmith Open/Closed:Open => Closed Component Version:

[bug #63856] .WAIT does not work as special target on command line.

2023-04-02 Thread Paul D. Smith
Update of bug #63856 (project make): Status:None => Fixed Open/Closed:Open => Closed Operating System:None => Any Fixed Release:

[bug #63990] Fix a buffer overflow in warning.c.

2023-04-02 Thread Dmitry Goncharov
URL: Summary: Fix a buffer overflow in warning.c. Group: make Submitter: dgoncharov Submitted: Sun 02 Apr 2023 06:38:21 PM UTC Severity: 3 - Normal Item Group: B

[bug #63990] Fix a buffer overflow in warning.c.

2023-04-02 Thread Dmitry Goncharov
Additional Item Attachment, bug #63990 (project make): File name: sv63990.fixSize:1 KB ___ Reply to this item at:

[bug #63990] Fix a buffer overflow in warning.c.

2023-04-02 Thread Dmitry Goncharov
Follow-up Comment #1, bug #63990 (project make): Settings like .WARNINGS = bogus causes decode_warn_name to return wt_max. decode_warn_actions then stores wt_max in type and the action at data->actions[type] and touches beyond the size of data->actions. __

[bug #63990] Fix a buffer overflow in warning.c.

2023-04-02 Thread Dmitry Goncharov
Follow-up Comment #2, bug #63990 (project make): There is already a test which tests this use case. ___ Reply to this item at: ___ Message sent via Sava