Hi Paul, On 4/2/23 16:04, Paul Smith wrote: > On Sun, 2023-04-02 at 14:52 +0200, Alejandro Colomar wrote: >> If I build make from source and run the checks in parallel, some >> fail. Is this expected, or is it a bug in the Makefile? > > The test suite is invoked as a single target, so there's no way that > enabling parallelism could impact it. Also the test suite tries to be > careful about shielding the internal invocations of make from > environmental factors like user settings of MAKEFLAGS and GNUMAKEFLAGS > etc. > > Indeed I tried "make check -j" and got no failures. > > Based on the diffs it appears make was able to find files like "foo" > and "bar" when it didn't expect them to exist.
Ahhh, then it was probably because I started with `make check`, and when I saw it was lasting more than a couple of seconds, I killed (^C) it and rerun with -j. > I'm not really sure how > that would happen but if you can figure it out I would be interested to > know. I can reproduce it by running `make check`, interrupting it at this specific point, and then running again `make check` (no -j needed): [...] features/mult_targets ................................... ok (2 passed) features/order_only ..................................... ok (10 passed) features/output-sync .................................... ^Cmake[2]: *** [Makefile:1550: check-regression] Interrupt make[1]: *** [Makefile:1283: check-am] Interrupt make: *** [Makefile:985: check-recursive] Interrupt Maybe other interruption points also reproduce it; some others don't. > If you run: > > cd tests > ./run_make_tests -make ../make features/escape > > does it fail? Nope. And not with some other tests I tried. Cheers, Alex -- <http://www.alejandro-colomar.es/> GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
OpenPGP_signature
Description: OpenPGP digital signature
