[PATCH 3/5] Refactor: Use a doubly-linked list of rules instead of a singly-linked list

--- implicit.c |2 +- rule.c | 86 +--- rule.h |7 +++-- 3 files changed, 41 insertions(+), 54 deletions(-) diff --git a/implicit.c b/implicit.c index d239952..82f2c79 100644 --- a/implicit.c +++ b/implicit.c @@ -301,7 +301

[PATCH 1/5] Refactor: Move rule comparisons into separate functions

--- rule.c | 95 +--- 1 files changed, 55 insertions(+), 40 deletions(-) diff --git a/rule.c b/rule.c index ee96ec1..d08383b 100644 --- a/rule.c +++ b/rule.c @@ -273,6 +273,34 @@ convert_to_pattern (void) } +static int +rule_targe

[PATCH 0/5] Improve performance of rule handling

Here is a series of patches to improve make's performance in handling large numbers of pattern rules. The motivation is to make glibc's build process faster. The change speeds up adding new pattern rules, but it does not speed up finding pattern rules that match a given filename. I have not chan

[PATCH 2/5] Clean up count_implicit_rule_limits()

* Removed unused variable, simplify loop. * Corrected comment. --- rule.c | 13 +++-- 1 files changed, 3 insertions(+), 10 deletions(-) diff --git a/rule.c b/rule.c index d08383b..a12f9d1 100644 --- a/rule.c +++ b/rule.c @@ -61,28 +61,24 @@ unsigned int maxsuffix;  /* Compute the

[PATCH 4/5] Record rule targets in a hash table

This is not used to replace any lookups yet. --- main.c |1 + rule.c | 75 rule.h |1 + 3 files changed, 77 insertions(+), 0 deletions(-) diff --git a/main.c b/main.c index ba7f87d..351e92c 100644 --- a/main.c +++ b/main

[PATCH 5/5] Hook up hash table: use for searching for rules to replace

--- rule.c | 52 1 files changed, 28 insertions(+), 24 deletions(-) diff --git a/rule.c b/rule.c index af1cefa..3ffc6bd 100644 --- a/rule.c +++ b/rule.c @@ -340,35 +340,39 @@ rule_dependency_lists_equal (struct rule *rule1, struct rule *rule

Re: multi-line commands with quoted SHELL

On Thu, 2007-02-22 at 19:00 +0100, Petr Machata wrote: > There is a bug tracked in Red Hat bugzilla > http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219409 > > The problem is best demonstrated by this Makefile snippet: > > all:;@echo e\ > cho > > With this make invocation, it w

Re: glibc build process slowness

On Wed, 2007-02-21 at 20:15 +, Mark Seaborn wrote: > I profiled make. It's spending around 60% of the time in > new_pattern_rule(), which does a linear search through the list of > pattern rules to check for duplicate rules. glibc generates ~2500 > rules (in sysd-rules). Holy moly! How in

Re: glibc build process slowness

On Wed, 2007-02-21 at 12:21 -0800, Roland McGrath wrote: > > the old rule has 1 target (or multiple identical targets) > > and > > there exists a target in the new rule the same as the old rule's target > > > > See attached makefile which demonstrates this. Is that the correct > > behaviour