Re: convert-ly rule for tocItem

2020-08-30 Thread Jonas Hahnfeld via bug-lilypond
Am Sonntag, den 30.08.2020, 18:47 +0200 schrieb Noeck: > Hi Jonas, > > thank you for your help and thank you for driving the switch to gitlab. > I tried several times in the last 10 years to contribute to LilyPond but > it was always complicated and I never succeeded. I'll see how this works > out

Re: convert-ly rule for tocItem

2020-08-30 Thread Noeck
Hi Jonas, thank you for your help and thank you for driving the switch to gitlab. I tried several times in the last 10 years to contribute to LilyPond but it was always complicated and I never succeeded. I'll see how this works out now, but it is really straight forward so far. Thank you! The mer

Re: convert-ly rule for tocItem

2020-08-30 Thread Jonas Hahnfeld via bug-lilypond
Am Sonntag, den 30.08.2020, 16:48 +0200 schrieb Noeck: > Am 24.08.20 um 19:54 schrieb Jonas Hahnfeld: > > feel free to submit the fix as a merge request 😉 > > Hi Jonas, > > I would like to do so and I have the local changes. I am joram-b on gitlab. Great! :-) > Could you give me a start? The

Re: convert-ly rule for tocItem

2020-08-30 Thread Noeck
Am 24.08.20 um 19:54 schrieb Jonas Hahnfeld: > feel free to submit the fix as a merge request 😉 Hi Jonas, I would like to do so and I have the local changes. I am joram-b on gitlab. Could you give me a start? Should I fork lilypond or can I push a branch to lilypond for review? Is there a nam

Re: convert-ly rule for tocItem

2020-08-24 Thread Jean Abou Samra
I can confirm the issue. And I think it is a bug in python/convertrules.py:4267. I found this: s = re.sub(r'\\tocItem\s+\"', r'\\tocItem \\markup \"', s) In the replacement string the " does not need to be escaped. And with the raw string r'' the backslash is interpreted literally. JAS-> Correc

Re: convert-ly rule for tocItem

2020-08-24 Thread Jonas Hahnfeld via bug-lilypond
Am Sonntag, den 23.08.2020, 07:51 +0200 schrieb Noeck: > I can confirm the issue. Yep... > And I think it is a bug in python/convertrules.py:4267. I found this: > > s = re.sub(r'\\tocItem\s+\"', r'\\tocItem \\markup \"', s) > > In the replacement string the " does not need to be escaped. An

Re: convert-ly rule for tocItem

2020-08-22 Thread Noeck
Btw, pylint reveals (among many other things) 27 warnings about: W1401: Anomalous backslash in string: '\m'. String constant might be missing an r prefix. (anomalous-backslash-in-string) which shows that backslashes are not placed properly. In the case of `\m` this is interpreted as `\\m` but in

Re: convert-ly rule for tocItem

2020-08-22 Thread Noeck
I can confirm the issue. And I think it is a bug in python/convertrules.py:4267. I found this: s = re.sub(r'\\tocItem\s+\"', r'\\tocItem \\markup \"', s) In the replacement string the " does not need to be escaped. And with the raw string r'' the backslash is interpreted literally. Am 22.