Updates:
Status: Verified
Comment #29 on issue 1472 by colinpkc...@gmail.com: Collision between MMR
and key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
(No comment was entered for this change.)
___
bug-lilypond mailin
Updates:
Status: Fixed
Labels: -Patch-needs_work
Comment #28 on issue 1472 by percival.music.ca: Collision between MMR and
key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
Fixed, thanks Keith! The key-signatures patch has been pushed; the other
patch is
Updates:
Labels: fixed_2_13_48
Comment #27 on issue 1472 by percival.music.ca: Collision between MMR and
key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
Fixed, thanks Keith!
___
bug-lilypond mailing list
bug-lilypond@
Comment #26 on issue 1472 by k-ohara5...@oco.net: Collision between MMR and
key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
I updated the patch at http://codereview.appspot.com/4095041/, but that
really addresses problems with the issue 1120 fix, not this issue. I'll
Comment #25 on issue 1472 by k-ohara5...@oco.net: Collision between MMR and
key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
Comment 21 notes the one restoration of 2.12.3 behavior that I did not like.
LeftEdge takes space from the notes, but only when one is created for
Comment #24 on issue 1472 by k-ohara5...@oco.net: Collision between MMR and
key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
Comment 21 notes the one restoration of 2.12.3 behavior that I did not like.
LeftEdge gets in the way of the notes, and surprising times, and only
Comment #23 on issue 1472 by mts...@gmail.com: Collision between MMR and
key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
I agree that the clef causes horizontal spacing that is too tight.
Are there other grobs people can think of (time signatures, key singatures,
etc.)
Updates:
Labels: -Patch-review Patch-needs_work
Comment #22 on issue 1472 by percival.music.ca: Collision between MMR and
key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
Some kind of additional work is required -- maybe adding some special case
to avoid changin
Comment #21 on issue 1472 by n.putt...@gmail.com: Collision between MMR and
key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
I don't like what this patch does to this snippet:
\new PianoStaff <<
\new Staff \relative c' {
\repeat unfold 16 c16
\break
c1
}
Updates:
Labels: -Patch Patch-review
Comment #20 on issue 1472 by percival.music.ca: Collision between MMR and
key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
Nothing obviously wrong in the code, the regtest comparison looks ok, and
it builds the docs.
_
Comment #19 on issue 1472 by k-ohara5...@oco.net: Collision between MMR and
key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
Patch http://codereview.appspot.com/4095041/ and the appropriate reg-test
are expanded to make that patch complete. This fixes old issue 1120 in
Comment #18 on issue 1472 by k-ohara5...@oco.net: Collision between MMR and
key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
Re: (16) the patch at http://codereview.appspot.com/4095041/ (mostly a
revert of an earlier patch) is the right thing to do. Then note spacing,
Comment #17 on issue 1472 by mts...@gmail.com: Collision between MMR and
key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
Sorry - you're right Keith, my bad.
Forgot to compile using make before my make check.
Compiles w/ a clean make check.
I do not know this part of the
Comment #16 on issue 1472 by percival.music.ca: Collision between MMR and
key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
I just tried another regtest comparison and looked at it in more detail,
but I couldn't see anything like comment 14.
However, I gather from a re
Comment #15 on issue 1472 by k-ohara5...@oco.net: Collision between MMR and
key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
Carl (re: 13 &11) I do like defaults to both handle the common case, and to
be unsurprising. Zero is usually the most unsurprising. Here, thoug
Comment #14 on issue 1472 by mts...@gmail.com: Collision between MMR and
key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
Keith,
I ran the regtest and there are several regressions (assuming that I
applied the patch correctly). Could you please see if you get the same
Comment #13 on issue 1472 by carl.d.s...@gmail.com: Collision between MMR
and key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
The reason I asked the question in comment # 11 is that Joe's original
patch for 1120 set the default extra-spacing-height to zero for all Item
Comment #12 on issue 1472 by k-ohara5...@oco.net: Collision between MMR and
key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
I had not considered the question quite the way Carl did, but it seems that
all properties like extra-spacing-height have a default value (maybe
Comment #11 on issue 1472 by carl.d.s...@gmail.com: Collision
between MMR
and key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
To me the root question for Joe's original 1120 fix is probably
something like
"Do we want to have the same default extra-spacing-height for a
Comment #11 on issue 1472 by carl.d.s...@gmail.com: Collision between MMR
and key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
To me the root question for Joe's original 1120 fix is probably something
like
"Do we want to have the same default extra-spacing-height for
Comment #10 on issue 1472 by mts...@gmail.com: Collision between MMR and
key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
In a later communication, Keith writes:
Well, reverting ee0488 removes the cause of our /noticing/ issue 1472
(multi-measure rests colliding with key
Comment #9 on issue 1472 by mts...@gmail.com: Collision between MMR and key
signature
http://code.google.com/p/lilypond/issues/detail?id=1472
From Keith O'Hara:
The patches look like they do the job, and give clean regression tests,
but the developers are hesitant. I am not a programmer, an
Comment #8 on issue 1472 by mts...@gmail.com: Collision between MMR and key
signature
http://code.google.com/p/lilypond/issues/detail?id=1472
Here is the state of things:
1/6
Bug is first reported on the bug list.
1/7
Neil reports adding a default 'extra-spacing-height to key signature.
1/
Comment #7 on issue 1472 by percival.music.ca: Collision between MMR and
key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
Mike is "shepherding" (and maybe programming) this issue.
___
bug-lilypond mailing list
bug-lilypond@gnu
Updates:
Status: Accepted
Labels: -fixed_2_13_47
Comment #6 on issue 1472 by percival.music.ca: Collision between MMR and
key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
ok, reverted.
___
bug-lilypond mailing
Comment #5 on issue 1472 by n.putt...@gmail.com: Collision between MMR and
key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
Keith's patch looks fine in a regtest comparison, and it looks trivial,
so I've pushed it.
Can we slow down a bit please? I haven't had chance
Updates:
Status: Fixed
Labels: fixed_2_13_47
Comment #4 on issue 1472 by percival.music.ca: Collision between MMR and
key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
Keith's patch looks fine in a regtest comparison, and it looks trivial, so
I've pushed
Comment #3 on issue 1472 by reinhold.kainhofer: Collision between MMR and
key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
To be correct: This is not a collision of the key signature with the MMR,
but it rather seems that a MMR after the key signature takes no horizonta
Updates:
Labels: Patch
Comment #2 on issue 1472 by percival.music.ca: Collision between MMR and
key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
There is a patch for this bug:
http://thread.gmane.org/gmane.comp.gnu.lilypond.bugs/22404/focus=22466
___
Comment #1 on issue 1472 by percival.music.ca: Collision between MMR and
key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
For clarity, this is a regression since 2.12.3, which produces this good
output.
Attachments:
foo.png 18.5 KB
_
Status: Accepted
Owner:
Labels: Type-Collision Priority-Critical Regression
New issue 1472 by PhilEHolmes: Collision between MMR and key signature
http://code.google.com/p/lilypond/issues/detail?id=1472
2.13.46 - the following code:
\version "2.13.46"
{
\compressFullBarRests
\key c \maj
31 matches
Mail list logo
