Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Svante Signell
On Tue, 2013-02-12 at 00:40 +0100, Svante Signell wrote: > On Thu, 2013-01-24 at 13:58 +0100, Svante Signell wrote: > > Ok, here is the not yet complete patch for hurdselect.c. An explanation > will follow tomorrow, too late to get everything written down correctly > now. The patch is longer than

Re: Disabling -pie when linking?

2013-02-12 Thread Thomas Schwinge
Hi! On Mon, 11 Feb 2013 05:08:54 +0100, Samuel Thibault wrote: > Samuel Thibault, le Mon 11 Feb 2013 03:06:59 +0100, a écrit : > > Svante Signell, le Sun 20 Jan 2013 18:18:16 +0100, a écrit : > > > A recent problem popping up is that executables using the -pie flag when > > > linking segfaults w

Re: Disabling -pie when linking?

2013-02-12 Thread Samuel Thibault
Thomas Schwinge, le Tue 12 Feb 2013 12:00:05 +0100, a écrit : > What the Linux kernel is doing, at least the 3.2 kernel on x86 that I've > been testing on, is putting the "beginning of the program break" in the > 512 MiB area, 0x2xxx. I have not yet figured out why exactly this > region. As I

Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Samuel Thibault
Svante Signell, le Tue 12 Feb 2013 09:09:25 +0100, a écrit : > Attached is a patch wrt the latest patch (step2) on January 24 2013. The > indentation is different, therefore the diff blocks are a little large > (but easier to read). Hopefully this is better. Including also the > resulting file hurd

Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Svante Signell
On Tue, 2013-02-12 at 22:55 +0100, Samuel Thibault wrote: > Svante Signell, le Tue 12 Feb 2013 09:09:25 +0100, a écrit : > > Attached is a patch wrt the latest patch (step2) on January 24 2013. The > > indentation is different, therefore the diff blocks are a little large > > (but easier to read).

Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Samuel Thibault
Svante Signell, le Tue 12 Feb 2013 23:46:00 +0100, a écrit : > - some minor tweaks will still be made to be mor POSIX consistent. It'd be way better to keep these as separate patches. That's how we'll have to submit them to libc-alpha anyway... Samuel

Re: [PATCH, HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Pino Toscano
Alle martedì 12 febbraio 2013, Svante Signell ha scritto: > * change the FD_SETSIZE upper value check to larger than or equal > from larger than. > (from POSIX definition of select: > http://pubs.opengroup.org/onlinepubs/009604499/functions/select.html > ) It's http://pubs.opengroup.org/onlinepu

Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Svante Signell
On Tue, 2013-02-12 at 23:50 +0100, Samuel Thibault wrote: > Svante Signell, le Tue 12 Feb 2013 23:46:00 +0100, a écrit : > > - some minor tweaks will still be made to be mor POSIX consistent. > > It'd be way better to keep these as separate patches. That's how we'll > have to submit them to libc-

Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Samuel Thibault
Svante Signell, le Tue 12 Feb 2013 23:55:04 +0100, a écrit : > On Tue, 2013-02-12 at 23:50 +0100, Samuel Thibault wrote: > > Svante Signell, le Tue 12 Feb 2013 23:46:00 +0100, a écrit : > > > - some minor tweaks will still be made to be mor POSIX consistent. > > > > It'd be way better to keep thes

Re: [PATCH, HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Svante Signell
On Tue, 2013-02-12 at 23:52 +0100, Pino Toscano wrote: > Alle martedì 12 febbraio 2013, Svante Signell ha scritto: > > * change the FD_SETSIZE upper value check to larger than or equal > > from larger than. > > (from POSIX definition of select: > > http://pubs.opengroup.org/onlinepubs/009604499/fu

Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Svante Signell
On Wed, 2013-02-13 at 00:03 +0100, Samuel Thibault wrote: > Svante Signell, le Tue 12 Feb 2013 23:55:04 +0100, a écrit : > > On Tue, 2013-02-12 at 23:50 +0100, Samuel Thibault wrote: > > > Svante Signell, le Tue 12 Feb 2013 23:46:00 +0100, a écrit : > > > > - some minor tweaks will still be made to

Re: [PATCH, HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Samuel Thibault
Svante Signell, le Wed 13 Feb 2013 00:04:33 +0100, a écrit : > Then you have to convince the Linux man page and the python3.2 > developers too. From python3.2: > ./Include/fileobject.h: #define _PyIsSelectable_fd(FD) (((FD) >= 0) && > ((FD) < FD_SETSIZE)) That's easy: point them to the latest vers

Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Samuel Thibault
Svante Signell, le Wed 13 Feb 2013 00:06:10 +0100, a écrit : > On Wed, 2013-02-13 at 00:03 +0100, Samuel Thibault wrote: > > Svante Signell, le Tue 12 Feb 2013 23:55:04 +0100, a écrit : > > > On Tue, 2013-02-12 at 23:50 +0100, Samuel Thibault wrote: > > > > Svante Signell, le Tue 12 Feb 2013 23:46:

Re: [PATCH, HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Pino Toscano
Alle mercoledì 13 febbraio 2013, Svante Signell ha scritto: > On Tue, 2013-02-12 at 23:52 +0100, Pino Toscano wrote: > > Alle martedì 12 febbraio 2013, Svante Signell ha scritto: > > > * change the FD_SETSIZE upper value check to larger than or > > > equal > > > > > > from larger than. > > > (fr

Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Svante Signell
On Wed, 2013-02-13 at 00:07 +0100, Samuel Thibault wrote: > Svante Signell, le Wed 13 Feb 2013 00:06:10 +0100, a écrit : > > On Wed, 2013-02-13 at 00:03 +0100, Samuel Thibault wrote: > > > Svante Signell, le Tue 12 Feb 2013 23:55:04 +0100, a écrit : > > > > On Tue, 2013-02-12 at 23:50 +0100, Samuel

Re: [PATCH, HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Samuel Thibault
Pino Toscano, le Wed 13 Feb 2013 00:08:21 +0100, a écrit : > Alle mercoledì 13 febbraio 2013, Svante Signell ha scritto: > > On Tue, 2013-02-12 at 23:52 +0100, Pino Toscano wrote: > > > Alle martedì 12 febbraio 2013, Svante Signell ha scritto: > > > > * change the FD_SETSIZE upper value check to l

Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Samuel Thibault
Svante Signell, le Wed 13 Feb 2013 00:12:57 +0100, a écrit : > On Wed, 2013-02-13 at 00:07 +0100, Samuel Thibault wrote: > > Svante Signell, le Wed 13 Feb 2013 00:06:10 +0100, a écrit : > > > On Wed, 2013-02-13 at 00:03 +0100, Samuel Thibault wrote: > > > > Svante Signell, le Tue 12 Feb 2013 23:55:

Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Richard Braun
On Tue, Feb 12, 2013 at 11:50:21PM +0100, Samuel Thibault wrote: > Svante Signell, le Tue 12 Feb 2013 23:46:00 +0100, a écrit : > > - some minor tweaks will still be made to be mor POSIX consistent. > > It'd be way better to keep these as separate patches. That's how we'll > have to submit them t

Re: [PATCH, HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Svante Signell
On Wed, 2013-02-13 at 00:08 +0100, Pino Toscano wrote: > Alle mercoledì 13 febbraio 2013, Svante Signell ha scritto: > > On Tue, 2013-02-12 at 23:52 +0100, Pino Toscano wrote: > > > Alle martedì 12 febbraio 2013, Svante Signell ha scritto: > > > > * change the FD_SETSIZE upper value check to large

Re: [PATCH, HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Pino Toscano
Alle mercoledì 13 febbraio 2013, Samuel Thibault ha scritto: > Pino Toscano, le Wed 13 Feb 2013 00:08:21 +0100, a écrit : > > Alle mercoledì 13 febbraio 2013, Svante Signell ha scritto: > > > On Tue, 2013-02-12 at 23:52 +0100, Pino Toscano wrote: > > > > Alle martedì 12 febbraio 2013, Svante Signel

Re: [PATCH, HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Samuel Thibault
Svante Signell, le Wed 13 Feb 2013 00:17:21 +0100, a écrit : > The behavior of these macros is undefined if the fd argument is less > than 0 or greater than or equal to FD_SETSIZE, or if fd is not a valid > file descriptor, or if any of the arguments are expressions with > side-effects. Ok, so FD_

Re: [PATCH, HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Pino Toscano
Alle mercoledì 13 febbraio 2013, Svante Signell ha scritto: > On Wed, 2013-02-13 at 00:08 +0100, Pino Toscano wrote: > > Alle mercoledì 13 febbraio 2013, Svante Signell ha scritto: > > > On Tue, 2013-02-12 at 23:52 +0100, Pino Toscano wrote: > > > > Alle martedì 12 febbraio 2013, Svante Signell ha

Re: [PATCH, HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Roland McGrath
> Then you have to convince the Linux man page and the python3.2 > developers too. From python3.2: > ./Include/fileobject.h: #define _PyIsSelectable_fd(FD) (((FD) >= 0) && > ((FD) < FD_SETSIZE)) The fd value itself has to be < FD_SETSIZE, since indexing is zero-origin; so that code is right. The

Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Richard Braun
On Wed, Feb 13, 2013 at 12:12:57AM +0100, Svante Signell wrote: > What a pity, I spent a very long time doing this rewrite, and to make > the code more readable (at least in my opinion). Back to spaghetti^Wold > style code then. We warned you several times about making your changes as little intru

Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Samuel Thibault
Svante Signell, le Tue 12 Feb 2013 23:46:00 +0100, a écrit : > On Tue, 2013-02-12 at 22:55 +0100, Samuel Thibault wrote: > > Svante Signell, le Tue 12 Feb 2013 09:09:25 +0100, a écrit : > > > Attached is a patch wrt the latest patch (step2) on January 24 2013. The > > > indentation is different, th

Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Samuel Thibault
Samuel Thibault, le Wed 13 Feb 2013 01:42:53 +0100, a écrit : > I have rewritten your changes as seen below, and pushed to our glibc repository. This is all above Richard's io_select_timeout changes. Samuel

Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Svante Signell
On Wed, 2013-02-13 at 01:53 +0100, Samuel Thibault wrote: > Samuel Thibault, le Wed 13 Feb 2013 01:42:53 +0100, a écrit : > > I have rewritten your changes as seen below, > > and pushed to our glibc repository. This is all above Richard's > io_select_timeout changes. Where? I cannot find it. Its

Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Svante Signell
On Wed, 2013-02-13 at 00:30 +0100, Richard Braun wrote: > On Wed, Feb 13, 2013 at 12:12:57AM +0100, Svante Signell wrote: > > What a pity, I spent a very long time doing this rewrite, and to make > > the code more readable (at least in my opinion). Back to spaghetti^Wold > > style code then. > > W

Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

2013-02-12 Thread Richard Braun
On Wed, Feb 13, 2013 at 07:24:46AM +0100, Svante Signell wrote: > > We warned you several times about making your changes as little > > intrusive as possible for easier review. Since you seem to be unable to > > understand what that implies, it's only natural Samuel no longer wastes > > time on thi