Re: swapon/swapoff

2005-02-07 Thread Roland McGrath
You should send logically independent changes in separate patches. There are two here. > 2005-02-05 Alfred M. Szmidt <[EMAIL PROTECTED]> > > * swapon.c (main): Just print a warning if we couldn't find > any swap partitions in _PATH_MNTTAB instead of exiting with a > non-zero e

Re: swapon/swapoff

2005-02-07 Thread Roland McGrath
>Please clean up your patch to remove all the nonsense hunks. > > Sure, but how do I get those "nonsense" hunks applied if I don't send > a patch with them? Send an honest patch with an honest log entry for whatever nonsense you want applied. ___

Re: swapon/swapoff

2005-02-06 Thread Bas Wijnen
Alfred M. Szmidt wrote: #ifdef SWAPOFF const char *argp_program_version = STANDARD_HURD_VERSION (swapoff); + +static int require_signature = 0; +static int ignore_signature = 1; #else const char *argp_program_version = STANDARD_HURD_VERSION (swapon); + +static int require_signature = 1; +static

Re: swapon/swapoff

2005-02-05 Thread Alfred M. Szmidt
Please clean up your patch to remove all the nonsense hunks. Sure, but how do I get those "nonsense" hunks applied if I don't send a patch with them? (fixed my ChangeLog entry just a bit too) 2005-02-05 Alfred M. Szmidt <[EMAIL PROTECTED]> * swapon.c (main): Just print a warning if

Re: swapon/swapoff

2005-02-05 Thread Roland McGrath
Please clean up your patch to remove all the nonsense hunks. ___ Bug-hurd mailing list Bug-hurd@gnu.org http://lists.gnu.org/mailman/listinfo/bug-hurd

swapon/swapoff

2005-02-05 Thread Alfred M. Szmidt
I find it stupid that swapon defaults to --no-signature, one could by accident type another device other then the one intended. This changes the default behaviour to only setup swap ifthere is a Linux-swap signature. Another thing I found stupid is to have swapon exit with a non-zero exit status