[task #6537] Implement ddb/db_elf.c

Follow-up Comment #6, task #6537 (project hurd): Mmm, it is better indeed, it shows some numbers which are not the beginning of the functions, but they are still wrong. For instance, when interrupting execution of dd < /dev/zero > /dev/null, I got ... ipc_mqueue_receive(104bbf38,0,2000,0,0)+1f1

[task #6537] Implement ddb/db_elf.c

Follow-up Comment #5, task #6537 (project hurd): Fixed the db_error issue and the line number bug. Same changelog. (file #16184) ___ Additional Item Attachment: File name: elf-patch Size:111 KB _

[task #6537] Implement ddb/db_elf.c

Follow-up Comment #4, task #6537 (project hurd): 2008-07-18 Andrei Barbu <[EMAIL PROTECTED]> * ddb/db_elf.c: New file * ddb/db_sym.c: ELF prototypes and switch entries * ddb/db_sym.h: ELF symbol table type as the default * ddb/dwarf2.h: New file * ddb/el

[task #6537] Implement ddb/db_elf.c

Follow-up Comment #3, task #6537 (project hurd): This is a rewrite of the elf backend to use dwarf instead of the elf symbols. It adds many features, the two most obvious ones are that it's a lot slower and that line numbers and files work in ddb. This is also a requirement for probe support. (f

Re: [task #6537] Implement ddb/db_elf.c

Andrei Barbu, le Tue 27 May 2008 19:02:18 +, a écrit : > Additional Item Attachment, task #6537 (project hurd): > > File name: changelog-elf-1.patch Size:1 KB Ok, you make the same mistake as I did some time ago when I started working on GNU projects :) GNU style changelog are not a

Re: [task #6537] Implement ddb/db_elf.c

Hello, Looks good (quite straight forward actually), except the coding style of db_elf.c. It'd be good to keep the same as db_aout.c for instance, for at least local style coherency :) Samuel

[task #6537] Implement ddb/db_elf.c

Additional Item Attachment, task #6537 (project hurd): File name: changelog-elf-1.patch Size:1 KB ___ Reply to this item at: ___ Message sent

[task #6537] Implement ddb/db_elf.c

Follow-up Comment #2, task #6537 (project hurd): Updated the reflect the discussion on bug-hurd. (file #15746) ___ Additional Item Attachment: File name: elf-1.patchSize:71 KB

Re: [task #6537] Implement ddb/db_elf.c

> Ok, then put them into sys/types.h, since that's where POSIX says they > are :) >> > - I would have put __CONCAT in the ELF header, as it's the only place >> > where it is used. Other helper macros aren't used. >> Same as above. > > Then another place too, it really doesn't belong to vm_types.h

Re: [task #6537] Implement ddb/db_elf.c

Hello, Andrei Barbu, le Sun 25 May 2008 02:07:36 -0400, a écrit : > > - I'm not sure we want to instroduce the POSIX types. Can't we just use > > the Mach types in the ELF headers? It looks like there aren't so many > > occurences anyway. > I'd prefer to keep the headers unchaged. Ok, then pu

Re: [task #6537] Implement ddb/db_elf.c

Hey, Thanks for the comments. > - take care of indentation. Try to respect the same existing indentation > (yes it's not homogeneous, follow it per-file). For instance, in > new-gnumach-3/i386/i386at/model_dep.c Ah, sorry. My emacs automatically reindents every file to my settings, I'll disable

Re: [task #6537] Implement ddb/db_elf.c

Hello, I haven't reviewed db_elf.c itself, thus not replying on the tracker. It generally looks good (I've commited the symbol_values already), just a few points: - take care of indentation. Try to respect the same existing indentation (yes it's not homogeneous, follow it per-file). For instan

Re: [task #6537] Implement ddb/db_elf.c

Andrei Barbu, le Fri 09 May 2008 15:38:25 +, a écrit : > Two patches that add this. Cool, definitely a helpful thing :) I will most probably not have the time to review them until at least one week, however. Samuel

[task #6537] Implement ddb/db_elf.c

Follow-up Comment #1, task #6537 (project hurd): Two patches that add this. The first extends symbol_values to take the symbol table as an argument, this is required for ELF. The second adds db_elf.c as well as a whole bunch of support files, enables ELF and adds it to model_dep. It also sets ELF

[task #6537] Implement ddb/db_elf.c

URL: Summary: Implement ddb/db_elf.c Project: The GNU Hurd Submitted by: sthibaul Submitted on: mardi 20.02.2007 à 01:52 Category: GNU Mach Should Start On: mardi 20.02.2007 à