Hello, I haven't reviewed db_elf.c itself, thus not replying on the tracker.
It generally looks good (I've commited the symbol_values already), just a few points: - take care of indentation. Try to respect the same existing indentation (yes it's not homogeneous, follow it per-file). For instance, in new-gnumach-3/i386/i386at/model_dep.c - use -p option of diff. - I'm not sure we want to instroduce the POSIX types. Can't we just use the Mach types in the ELF headers? It looks like there aren't so many occurences anyway. - I would have put __CONCAT in the ELF header, as it's the only place where it is used. Other helper macros aren't used. - in model_dep.c you can factorize the test for kern_sym_start. - please provide a GNU-style ChangeLog. Again, thanks for working on that, it'll definitely be useful :) Samuel
