RFC: [PATCH hurd 0/6] Add file record locking support (updated)

2016-02-08 Thread Svante Signell
Hi, Attached in subsequent mails is an updated patch series for file record locking support, mainly developed by Neal Walfield in 2001. The patch was published by Marcus Brinkmann and later re-diffed by Michael Banck in 2002. Now modified to use libpthread instead of cthreads. Additional fixes sin

Re: [PATCH hurd 0/6] Add file record locking support

2015-01-22 Thread Svante Signell
On Thu, 2015-01-08 at 16:54 +0100, Samuel Thibault wrote: > Which wouldn't be a good thing, as I said it's better to split the > changes where it can be, to make bisecting easier. > > > To be a little more constructive: Is this patch order correct? > > 1) libfshelp_rlock.patch: implement fshelp_r

Re: [PATCH hurd 0/6] Add file record locking support

2015-01-20 Thread Samuel Thibault
Svante Signell, le Tue 20 Jan 2015 11:19:21 +0100, a écrit : > > I don't think tdbtorture forks with locks held: AIUI it just starts > > several processes and let them play at will with locks, without creating > > or terminating them. > > Looking at the code of tdbtorture.c it forks a lot of proce

Re: [PATCH hurd 0/6] Add file record locking support

2015-01-20 Thread Samuel Thibault
Svante Signell, le Tue 20 Jan 2015 11:19:21 +0100, a écrit : > On Tue, 2015-01-20 at 01:37 +0100, Samuel Thibault wrote: > > Hello, > > > > Thanks for reviving this, it'll definitely be useful! > > > > Svante Signell, le Thu 08 Jan 2015 12:28:05 +0100, a écrit : > > > 1) l_pid of struct flock is

Re: [PATCH hurd 0/6] Add file record locking support

2015-01-20 Thread Svante Signell
On Tue, 2015-01-20 at 01:37 +0100, Samuel Thibault wrote: > Hello, > > Thanks for reviving this, it'll definitely be useful! > > Svante Signell, le Thu 08 Jan 2015 12:28:05 +0100, a écrit : > > 1) l_pid of struct flock is not set. According to the manpage (and > > posix) the PID of the process bl

Re: [PATCH hurd 0/6] Add file record locking support

2015-01-19 Thread Samuel Thibault
Hello, Thanks for reviving this, it'll definitely be useful! Svante Signell, le Thu 08 Jan 2015 12:28:05 +0100, a écrit : > 1) l_pid of struct flock is not set. According to the manpage (and > posix) the PID of the process blocking the lock should be reported. Can > maybe be solved by a shared me

Re: [PATCH hurd 0/6] Add file record locking support

2015-01-19 Thread Samuel Thibault
Svante Signell, le Thu 08 Jan 2015 12:28:05 +0100, a écrit : > 3/6: libfshelp_rlock.patch: implement fshelp_rlock_* functions It seems this one didn't make its way to the list. Samuel

Re: [PATCH hurd 0/6] Add file record locking support

2015-01-19 Thread Samuel Thibault
Svante Signell, le Fri 09 Jan 2015 10:54:32 +0100, a écrit : > e.g. Debian Hurd patches are not even admitted to be used to make a new > release of Debian glibc until the Debian maintainer decides :( Now > during the freeze nothing happens with glibc, and e.g. the symbol file > update lingers in -p

Re: [PATCH hurd 0/6] Add file record locking support

2015-01-09 Thread Justus Winter
Quoting Svante Signell (2015-01-09 12:01:15) > On Fri, 2015-01-09 at 10:22 +0100, Justus Winter wrote: > > Quoting Svante Signell (2015-01-09 09:06:34) > > > > > I don't recommend that. Instead, hack on a branch that sits on top of > > the current master. Then, drop the Debian packaging bits fr

Re: [PATCH hurd 0/6] Add file record locking support

2015-01-09 Thread Svante Signell
On Fri, 2015-01-09 at 10:22 +0100, Justus Winter wrote: > Quoting Svante Signell (2015-01-09 09:06:34) > > I don't recommend that. Instead, hack on a branch that sits on top of > the current master. Then, drop the Debian packaging bits from my > repository here: > > http://darnassus.sceen.net/

Re: [PATCH hurd 0/6] Add file record locking support

2015-01-09 Thread Svante Signell
On Fri, 2015-01-09 at 10:22 +0100, Justus Winter wrote: > Quoting Svante Signell (2015-01-09 09:06:34) > > Cloning hurd git from debian > > git clone git://git.debian.org/git/pkg-hurd/hurd.git > > shows that no patches are committed to the git tree > > That is unfortunately correct. The Debian Hu

Re: [PATCH hurd 0/6] Add file record locking support

2015-01-09 Thread Justus Winter
Quoting Svante Signell (2015-01-09 09:06:34) > Cloning hurd git from debian > git clone git://git.debian.org/git/pkg-hurd/hurd.git > shows that no patches are committed to the git tree That is unfortunately correct. The Debian Hurd package is patched beyond recognition, to the point that if you b

Re: [PATCH hurd 0/6] Add file record locking support

2015-01-09 Thread Svante Signell
On Thu, 2015-01-08 at 16:54 +0100, Samuel Thibault wrote: > Svante Signell, le Thu 08 Jan 2015 16:46:55 +0100, a écrit : > > On Thu, 2015-01-08 at 13:38 +0100, Justus Winter wrote: > > > Hello Svante :) > > > > > > > > > 1/6: hurd_new_RPC.patch: add new RPC: file_record_lock > > > > 2/6: libdiskf

Re: [PATCH hurd 0/6] Add file record locking support

2015-01-08 Thread Samuel Thibault
Svante Signell, le Thu 08 Jan 2015 16:46:55 +0100, a écrit : > On Thu, 2015-01-08 at 13:38 +0100, Justus Winter wrote: > > Hello Svante :) > > > > > > 1/6: hurd_new_RPC.patch: add new RPC: file_record_lock > > > 2/6: libdiskfs_file_record_lock.patch: implement > > > diskfs_S_file_record_lock and

Re: [PATCH hurd 0/6] Add file record locking support

2015-01-08 Thread Svante Signell
On Thu, 2015-01-08 at 13:38 +0100, Justus Winter wrote: > Hello Svante :) > > > 1/6: hurd_new_RPC.patch: add new RPC: file_record_lock > > 2/6: libdiskfs_file_record_lock.patch: implement > > diskfs_S_file_record_lock and modify diskfs_S_* accordingly, initialize > > and release lock_status. > >

Re: [PATCH hurd 0/6] Add file record locking support

2015-01-08 Thread Samuel Thibault
Svante Signell, le Thu 08 Jan 2015 14:04:50 +0100, a écrit : > On Thu, 2015-01-08 at 13:57 +0100, Samuel Thibault wrote: > > Svante Signell, le Thu 08 Jan 2015 13:55:28 +0100, a écrit : > > > Well, I was expecting that all patches should be applied (when modified > > > and OKed), not each one separ

Re: [PATCH hurd 0/6] Add file record locking support

2015-01-08 Thread Svante Signell
On Thu, 2015-01-08 at 13:57 +0100, Samuel Thibault wrote: > Svante Signell, le Thu 08 Jan 2015 13:55:28 +0100, a écrit : > > Well, I was expecting that all patches should be applied (when modified > > and OKed), not each one separately. I can fix that, but what's the use > > of applying parts of pa

Re: [PATCH hurd 0/6] Add file record locking support

2015-01-08 Thread Samuel Thibault
Svante Signell, le Thu 08 Jan 2015 13:55:28 +0100, a écrit : > Well, I was expecting that all patches should be applied (wneh modified > and OKed), not each one separately. I can fix that, but what's the use > of applying parts of patches in a patch series? To be able to git bisect. Samuel

Re: [PATCH hurd 0/6] Add file record locking support

2015-01-08 Thread Svante Signell
On Thu, 2015-01-08 at 13:38 +0100, Justus Winter wrote: > Hello Svante :) > > Quoting Svante Signell (2015-01-08 12:28:05) > > Hi, > > > > Attached in subsequent mails is a patch series for file record locking > > support, mainly developed by Neal Walfield in 2001. The patch was > > published by

Re: [PATCH hurd 0/6] Add file record locking support

2015-01-08 Thread Justus Winter
Hello Svante :) Quoting Svante Signell (2015-01-08 12:28:05) > Hi, > > Attached in subsequent mails is a patch series for file record locking > support, mainly developed by Neal Walfield in 2001. The patch was > published by Marcus Brinkmann and later re-diffed by Michael Banck in > 2002. Now mod

[PATCH hurd 0/6] Add file record locking support

2015-01-08 Thread Svante Signell
Hi, Attached in subsequent mails is a patch series for file record locking support, mainly developed by Neal Walfield in 2001. The patch was published by Marcus Brinkmann and later re-diffed by Michael Banck in 2002. Now modified to use libpthread instead of cthreads and some additional fixes. Li