Re: [PATCH rust] Add new target for GNU/Hurd

2023-07-11 Thread Samuel Thibault
Sergey Bugaev, le mar. 11 juil. 2023 17:52:41 +0300, a ecrit: > On Mon, Jul 10, 2023 at 10:53 PM Samuel Thibault > wrote: > > llvm calls it i686-unknown-hurd-gnu (that was an intended behavior, even > > when knowing that gnu tools call it i686-unknown-gnu), so we should > > probably stick to that.

Re: [PATCH v6 1/2 hurd] libirqhelp: Add library

2023-07-11 Thread Samuel Thibault
Samuel Thibault, le mar. 11 juil. 2023 10:20:45 +0200, a ecrit: > Damien Zammit, le mar. 11 juil. 2023 07:58:39 +, a ecrit: > > On 11/7/23 05:47, Samuel Thibault wrote: > > > Damien Zammit, le lun. 10 juil. 2023 09:02:10 +, a ecrit: > > >> +void > > >> +irqhelp_wait_init(struct irq *irq) >

Re: [PATCH rust] Add new target for GNU/Hurd

2023-07-11 Thread Sergey Bugaev
On Mon, Jul 10, 2023 at 10:53 PM Samuel Thibault wrote: > llvm calls it i686-unknown-hurd-gnu (that was an intended behavior, even > when knowing that gnu tools call it i686-unknown-gnu), so we should > probably stick to that. > > I'd tend to keep it "hurd", because "gnu" is confusing for people.

Re: [PATCH v6 1/2 hurd] libirqhelp: Add library

2023-07-11 Thread Samuel Thibault
Damien Zammit, le mar. 11 juil. 2023 07:58:39 +, a ecrit: > On 11/7/23 05:47, Samuel Thibault wrote: > > Damien Zammit, le lun. 10 juil. 2023 09:02:10 +, a ecrit: > >> +void > >> +irqhelp_wait_init(struct irq *irq) > >> +{ > >> + if (!irq) > >> +{ > >> + log_error("cannot wait on

Re: [PATCH rust] Add new target for GNU/Hurd

2023-07-11 Thread Samuel Thibault
Damien Zammit, le mar. 11 juil. 2023 01:53:27 +, a ecrit: > On 11/7/23 05:53, Samuel Thibault wrote: > > Sergey Bugaev, le lun. 10 juil. 2023 12:22:21 +0300, a ecrit: > >> I don't think that's correct. For one thing, dev_t is __UWORD_TYPE > >> (like Rust usize) since glibc commit > >> 0ec48e333

Re: [PATCH v6 1/2 hurd] libirqhelp: Add library

2023-07-11 Thread Damien Zammit
Hi, On 11/7/23 05:47, Samuel Thibault wrote: > Damien Zammit, le lun. 10 juil. 2023 09:02:10 +, a ecrit: >> +void >> +irqhelp_wait_init(struct irq *irq) >> +{ >> + if (!irq) >> +{ >> + log_error("cannot wait on this irq to be ready\n"); >> + return; >> +} >> + >> + sem_wait