Thanks again Samuel!

2022-08-31 Thread Nathan Dehnel
Agreed!

Re: [PATCH 2/3] pfinet: New RPC S_pfinet_getroutes to get routing table

2022-08-31 Thread Damien Zammit
Hi, On 1/9/22 5:45 am, Samuel Thibault wrote: > Ah, you are just dumping the routing table in ascii format? I don't > think we want that, and rather get a series of route structures. procfs > can then do the ascii rendering. OK, I didn't think of that. But my code works and is proof of concept.

Re: [PATCH 2/3] pfinet: New RPC S_pfinet_getroutes to get routing table

2022-08-31 Thread Samuel Thibault
Damien Zammit, le mer. 31 août 2022 14:37:29 +, a ecrit: > +error_t > +S_pfinet_getroutes (io_t port, > + vm_size_t amount, > + data_t *routes, > + mach_msg_type_number_t *len) > +{ > + error_t err = 0; > + char rs[(MAX_ROUTES + 1) * 128]; > +

Re: [PATCH hurd] defs: Fix typing of iioctl

2022-08-31 Thread Samuel Thibault
Damien Zammit, le mer. 31 août 2022 14:30:56 +, a ecrit: > After much digging this fixes the new routing ioctls Applied, thanks! > --- > hurd/iioctl.defs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hurd/iioctl.defs b/hurd/iioctl.defs > index 6701d8ec7..c1007b2a6

Re: [PATCH 1/3] pfinet: Dump initial routing table at start up

2022-08-31 Thread Almudena Garcia
> > > Damien Zammit, le mer. 31 août 2022 14:37:23 +, a ecrit: > >> --- > >> pfinet/iioctl-ops.c | 21 + > >> pfinet/linux-src/net/ipv4/fib_hash.c | 6 -- > >> pfinet/linux-src/net/ipv4/fib_semantics.c | 4 > >> pfinet/options.c

Re: [PATCH 1/3] pfinet: Dump initial routing table at start up

2022-08-31 Thread Samuel Thibault
Damien Zammit, le mer. 31 août 2022 15:14:17 +, a ecrit: > > Damien Zammit, le mer. 31 août 2022 14:37:23 +, a ecrit: > >> --- > >> pfinet/iioctl-ops.c | 21 + > >> pfinet/linux-src/net/ipv4/fib_hash.c | 6 -- > >> pfinet/linux-src/net/ip

Re: [PATCH 1/3] pfinet: Dump initial routing table at start up

2022-08-31 Thread Damien Zammit
Hi, > Damien Zammit, le mer. 31 août 2022 14:37:23 +, a ecrit: >> --- >> pfinet/iioctl-ops.c | 21 + >> pfinet/linux-src/net/ipv4/fib_hash.c | 6 -- >> pfinet/linux-src/net/ipv4/fib_semantics.c | 4 >> pfinet/options.c

Re: [PATCH 1/3] pfinet: Dump initial routing table at start up

2022-08-31 Thread Samuel Thibault
Hello, I don't think we want this commited? Samuel Damien Zammit, le mer. 31 août 2022 14:37:23 +, a ecrit: > --- > pfinet/iioctl-ops.c | 21 + > pfinet/linux-src/net/ipv4/fib_hash.c | 6 -- > pfinet/linux-src/net/ipv4/fib_semantics.c | 4

[PATCH 3/3] procfs: Populate /proc/route with network routes

2022-08-31 Thread Damien Zammit
--- procfs/Makefile | 2 +- procfs/rootdir.c | 43 +++ 2 files changed, 44 insertions(+), 1 deletion(-) diff --git a/procfs/Makefile b/procfs/Makefile index 13ee026c4..d32328d28 100644 --- a/procfs/Makefile +++ b/procfs/Makefile @@ -21,7 +21,7 @@ makemode

[PATCH 2/3] pfinet: New RPC S_pfinet_getroutes to get routing table

2022-08-31 Thread Damien Zammit
--- hurd/pfinet.defs| 10 pfinet/pfinet-ops.c | 56 + 2 files changed, 66 insertions(+) diff --git a/hurd/pfinet.defs b/hurd/pfinet.defs index ec0b03e34..a6000142e 100644 --- a/hurd/pfinet.defs +++ b/hurd/pfinet.defs @@ -37,3 +37,13 @@ rout

[PATCH 1/3] pfinet: Dump initial routing table at start up

2022-08-31 Thread Damien Zammit
--- pfinet/iioctl-ops.c | 21 + pfinet/linux-src/net/ipv4/fib_hash.c | 6 -- pfinet/linux-src/net/ipv4/fib_semantics.c | 4 pfinet/options.c | 8 pfinet/pfinet.h | 4 +--- 5 file

Network routing table for pfinet

2022-08-31 Thread Damien Zammit
This patchset exposes a new /proc/route file containing the live routing table for pfinet on the procfs server. It does this by using a new RPC from pfinet to get the table. It also causes pfinet to dump its initial routing table at start up for debugging purposes.

[PATCH hurd] defs: Fix typing of iioctl

2022-08-31 Thread Damien Zammit
After much digging this fixes the new routing ioctls --- hurd/iioctl.defs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hurd/iioctl.defs b/hurd/iioctl.defs index 6701d8ec7..c1007b2a6 100644 --- a/hurd/iioctl.defs +++ b/hurd/iioctl.defs @@ -41,7 +41,7 @@ type ifname_t = array