On 22.11.2013 19:21:32, Guillem Jover wrote:
> On Thu, 2013-11-21 at 13:11:05 +0100, Marin Ramesa wrote:
> > diff --git a/ddb/db_sym.c b/ddb/db_sym.c
> > index 0819e08..359ec7c 100644
> > --- a/ddb/db_sym.c
> > +++ b/ddb/db_sym.c
> > @@ -276,7 +276,9 @@ db_name_is_ambiguous(sym_name)
> >
> >
On 22.11.2013 19:08:53, Guillem Jover wrote:
> I don't think it's appropriate to include stuff from the
> namespace from ddb/.
OK, but then we have an implicit declaration. I mean, it's not a big
problem, just a warning.
On 22.11.2013 19:10:57, Guillem Jover wrote:
> Is it really correct to add that copyright and license header when
> the stuff has just been moved? (The same for previous and subsequent
> similar patches.)
I don't know. Should the file be without copyright? What I'm really
worried about is that th
On Thu, 2013-11-21 at 13:11:05 +0100, Marin Ramesa wrote:
> diff --git a/ddb/db_sym.c b/ddb/db_sym.c
> index 0819e08..359ec7c 100644
> --- a/ddb/db_sym.c
> +++ b/ddb/db_sym.c
> @@ -276,7 +276,9 @@ db_name_is_ambiguous(sym_name)
>
> for (i = 0; i < db_nsymtab; i++) {
> db_sym_t
On Fri, 2013-11-22 at 18:30:36 +0100, Marin Ramesa wrote:
> diff --git a/ddb/db_mp.c b/ddb/db_mp.c
> index 831381f..81a567a 100644
> --- a/ddb/db_mp.c
> +++ b/ddb/db_mp.c
> @@ -56,11 +57,6 @@ intdb_slave[NCPUS] = { 0 };/* nonzero if
> cpu interrupted
>
> int db_enter_debug = 0;
On Fri, 2013-11-22 at 18:30:34 +0100, Marin Ramesa wrote:
> diff --git a/ddb/db_mp.c b/ddb/db_mp.c
> index 3ab00ce..831381f 100644
> --- a/ddb/db_mp.c
> +++ b/ddb/db_mp.c
> @@ -36,6 +36,8 @@
>
> #include
>
> +#include
> +
> #include
> #include
I don't think it's appropriate to include s
* ddb/db_examine.c: Trivial stylistic fix for consistency.
---
ddb/db_examine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ddb/db_examine.c b/ddb/db_examine.c
index 3d2c42b..a90ffa6 100644
--- a/ddb/db_examine.c
+++ b/ddb/db_examine.c
@@ -436,7 +436,7 @@ db_search(addr, s
* ddb/db_sym.c (db_lookup): Remove forward declaration.
* ddb/db_sym.h (db_lookup): Add prototype.
---
ddb/db_sym.c | 2 --
ddb/db_sym.h | 2 ++
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ddb/db_sym.c b/ddb/db_sym.c
index 359ec7c..38f0e5a 100644
--- a/ddb/db_sym.c
+++ b/ddb/db
* ddb/db_examine.c (db_disasm, db_search): Remove forward declarations.
* ddb/db_examine.h (db_disasm, db_search): Add prototypes.
---
ddb/db_examine.c | 4
ddb/db_examine.h | 18 --
2 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/ddb/db_examine.c b/ddb/db_ex
* Makefrag.am: Include device/chario.h.
* device/chario.c (queue_delayed_reply, tty_output, char_open_done,
char_read_done, char_write_done): Remove forward declarations.
* device/chario.h: New file.
Add copyright.
[_DEVICE_CHARIO_H_]: Add ifndef.
Include device/tty.h.
(queue_delayed_reply, tty_ou
* ddb/db_mp.c: Include i386at/kd.h for kdb_kintr().
---
ddb/db_mp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ddb/db_mp.c b/ddb/db_mp.c
index 3ab00ce..831381f 100644
--- a/ddb/db_mp.c
+++ b/ddb/db_mp.c
@@ -36,6 +36,8 @@
#include
+#include
+
#include
#include
--
1.8.1.4
* ddb/db_run.c (db_set_task_single_step, db_clear_task_single_step): Remove
forward declarations.
* ddb/db_run.h (db_set_task_single_step, db_clear_task_single_step): Add
prototypes.
---
ddb/db_run.c | 11 ---
ddb/db_run.h | 11 +++
2 files changed, 11 insertions(+), 11 deletion
* Makefrag.am: Include ddb/db_mp.h.
* ddb/db_mp.c (remote_db, lock_db, unlock_db): Remove forward declarations.
* ddb/db_mp.h: New file.
Add copyright.
[_DDB_DB_MP_H_]: Add ifndef.
(remote_db, lock_db, unlock_db): Add prototypes.
---
Makefrag.am | 1 +
ddb/db_mp.c | 6 +-
ddb/db_mp.h | 26 +
13 matches
Mail list logo
