Justus Winter, le Thu 21 Nov 2013 23:52:24 +0100, a écrit :
> Found using the Clang Static Analyzer.
>
> * pattern.c (patternlist_add): Fix memory leak.
Ack.
> ---
> pattern.c |3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/pattern.c b/pattern.c
> index 409ed23..fd38cf5 100644
>
Found using the Clang Static Analyzer.
* pattern.c (patternlist_add): Fix memory leak.
---
pattern.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/pattern.c b/pattern.c
index 409ed23..fd38cf5 100644
--- a/pattern.c
+++ b/pattern.c
@@ -52,7 +52,10 @@ patternlist_add (struct patternlist
* ddb/db_macro.c (db_arg_variable): Make function void.
* ddb/db_macro.h (db_arg_variable): Declare void return.
* ddb/db_task_thread.c (db_set_default_thread): Make function void.
(db_get_task_thread): Make function void.
* ddb/db_variables.c (db_set_default_thread, db_get_task_thread,
db_arg_var
* ddb/db_break.c: Don't include ddb/db_access.h.
---
ddb/db_break.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/ddb/db_break.c b/ddb/db_break.c
index c32f557..562c41a 100644
--- a/ddb/db_break.c
+++ b/ddb/db_break.c
@@ -47,7 +47,6 @@
#include
#include
#include
-#include
#define
Marin Ramesa, le Thu 21 Nov 2013 18:48:40 +0100, a écrit :
> On 21.11.2013 18:19:52, Samuel Thibault wrote:
> > Marin Ramesa, le Thu 21 Nov 2013 13:11:08 +0100, a écrit :
> > > - { "cs", (long *)&ddb_regs.cs, db_i386_reg_value },
> > > + { "cs", (long *)&ddb_regs.cs, (void
> *)db_i386_reg_value }
Marin Ramesa, le Thu 21 Nov 2013 13:11:08 +0100, a écrit :
> - { "cs", (long *)&ddb_regs.cs, db_i386_reg_value },
> + { "cs", (long *)&ddb_regs.cs, (void *)db_i386_reg_value },
Mmm, you shouldn't need this cast.
Samuel
On 21.11.2013 18:58:28, Samuel Thibault wrote:
> Marin Ramesa, le Thu 21 Nov 2013 18:56:09 +0100, a écrit :
> > On 21.11.2013 18:50:20, Samuel Thibault wrote:
> > > Marin Ramesa, le Thu 21 Nov 2013 18:48:40 +0100, a écrit :
> > > > On 21.11.2013 18:19:52, Samuel Thibault wrote:
> > > > > Marin Rame
On 21.11.2013 18:19:52, Samuel Thibault wrote:
> Marin Ramesa, le Thu 21 Nov 2013 13:11:08 +0100, a écrit :
> > - { "cs", (long *)&ddb_regs.cs, db_i386_reg_value },
> > + { "cs", (long *)&ddb_regs.cs, (void
*)db_i386_reg_value },
>
> Mmm, you shouldn't need this cast.
GCC complains otherwis
On 21.11.2013 18:50:20, Samuel Thibault wrote:
> Marin Ramesa, le Thu 21 Nov 2013 18:48:40 +0100, a écrit :
> > On 21.11.2013 18:19:52, Samuel Thibault wrote:
> > > Marin Ramesa, le Thu 21 Nov 2013 13:11:08 +0100, a écrit :
> > > > - { "cs", (long *)&ddb_regs.cs, db_i386_reg_value
> },
> > >
Marin Ramesa, le Thu 21 Nov 2013 19:02:34 +0100, a écrit :
> > Mmm, you didn't modify the struct db_variable, so that's not
> > surprising
> > :)
>
> It's used in other places. I think modification would break things.
Not that many places, it should be feasible without much harm.
Samuel
Samuel Thibault, le Thu 21 Nov 2013 19:08:17 +0100, a écrit :
> Marin Ramesa, le Thu 21 Nov 2013 19:02:34 +0100, a écrit :
> > > Mmm, you didn't modify the struct db_variable, so that's not
> > > surprising
> > > :)
> >
> > It's used in other places. I think modification would break things.
>
> N
On 21.11.2013 19:08:17, Samuel Thibault wrote:
> Marin Ramesa, le Thu 21 Nov 2013 19:02:34 +0100, a écrit :
> > > Mmm, you didn't modify the struct db_variable, so that's not
> > > surprising
> > > :)
> >
> > It's used in other places. I think modification would break things.
>
> Not that many pl
Marin Ramesa, le Thu 21 Nov 2013 18:56:09 +0100, a écrit :
> On 21.11.2013 18:50:20, Samuel Thibault wrote:
> > Marin Ramesa, le Thu 21 Nov 2013 18:48:40 +0100, a écrit :
> > > On 21.11.2013 18:19:52, Samuel Thibault wrote:
> > > > Marin Ramesa, le Thu 21 Nov 2013 13:11:08 +0100, a écrit :
> > > >
* ddb/db_sym.c: Move assignment outside of if.
(db_lookup): New variable.
---
ddb/db_sym.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ddb/db_sym.c b/ddb/db_sym.c
index 0819e08..359ec7c 100644
--- a/ddb/db_sym.c
+++ b/ddb/db_sym.c
@@ -276,7 +276,9 @@ db_name_is_ambiguou
* i386/i386/db_interface.h (cnpollc): Add prototype.
---
i386/i386/db_interface.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/i386/i386/db_interface.h b/i386/i386/db_interface.h
index 3f6821d..82bfec7 100644
--- a/i386/i386/db_interface.h
+++ b/i386/i386/db_interface.h
@@ -99,4 +99,6 @@
* i386/i386/db_trace.c (db_i386_reg_value): Make function void.
(db_regs): Cast to (void *).
---
i386/i386/db_trace.c | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/i386/i386/db_trace.c b/i386/i386/db_trace.c
index 8bad6b0..17ceb66 10064
* i386/i386at/kd.h [MACH_KDB] (kdb_kintr): Add prototype.
---
i386/i386at/kd.h | 4
1 file changed, 4 insertions(+)
diff --git a/i386/i386at/kd.h b/i386/i386at/kd.h
index 1d53538..b29a5bf 100644
--- a/i386/i386at/kd.h
+++ b/i386/i386at/kd.h
@@ -742,4 +742,8 @@ extern void kd_slmscd (void *f
* ddb/db_break.c: Include machine/db_interface.h.
---
ddb/db_break.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ddb/db_break.c b/ddb/db_break.c
index b26e1f0..c32f557 100644
--- a/ddb/db_break.c
+++ b/ddb/db_break.c
@@ -36,6 +36,7 @@
*/
#include
#include
+#include
#include
#inc
18 matches
Mail list logo
